[INFO] updating cached repository kongra/nc3 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kongra/nc3 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kongra/nc3" "work/ex/clippy-test-run/sources/stable/gh/kongra/nc3"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kongra/nc3'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kongra/nc3" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kongra/nc3"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kongra/nc3'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] efca6f84374ea9571dd2815b47a2ff601f80cf6b [INFO] sha for GitHub repo kongra/nc3: efca6f84374ea9571dd2815b47a2ff601f80cf6b [INFO] validating manifest of kongra/nc3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kongra/nc3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kongra/nc3 [INFO] finished frobbing kongra/nc3 [INFO] frobbed toml for kongra/nc3 written to work/ex/clippy-test-run/sources/stable/gh/kongra/nc3/Cargo.toml [INFO] started frobbing kongra/nc3 [INFO] finished frobbing kongra/nc3 [INFO] frobbed toml for kongra/nc3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kongra/nc3/Cargo.toml [INFO] crate kongra/nc3 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kongra/nc3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kongra/nc3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dae2211373a3551d7558c8280456b3766985a0cb5228f4da98b096c0249b8800 [INFO] running `"docker" "start" "-a" "dae2211373a3551d7558c8280456b3766985a0cb5228f4da98b096c0249b8800"` [INFO] [stderr] Checking nc3 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csp/model.rs:51:7 [INFO] [stderr] | [INFO] [stderr] 51 | vals: vals, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vals` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csp/model.rs:165:7 [INFO] [stderr] | [INFO] [stderr] 165 | domspecs: domspecs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `domspecs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csp/model.rs:51:7 [INFO] [stderr] | [INFO] [stderr] 51 | vals: vals, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vals` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csp/model.rs:165:7 [INFO] [stderr] | [INFO] [stderr] 165 | domspecs: domspecs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `domspecs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: field is never used: `pred` [INFO] [stderr] --> src/csp/model.rs:109:3 [INFO] [stderr] | [INFO] [stderr] 109 | pred: Pred, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `domspecs` [INFO] [stderr] --> src/csp/model.rs:110:3 [INFO] [stderr] | [INFO] [stderr] 110 | domspecs: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn get(&self, v: &V) -> Val { [INFO] [stderr] | ^^ help: consider passing by value instead: `V` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn has(&self, v: &V, val: &Val) -> bool { [INFO] [stderr] | ^^ help: consider passing by value instead: `V` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:78:25 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn is_a(&self, v: &V) -> bool { [INFO] [stderr] | ^^ help: consider passing by value instead: `V` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:82:27 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn is_una(&self, v: &V) -> bool { [INFO] [stderr] | ^^ help: consider passing by value instead: `V` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn is(&self, val: Val) -> Pred { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn is_not(&self, val: Val) -> Pred { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | pub fn one_of(&self, vals: Vec) -> Domspec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/csp/model.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | assert!(vals.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vals.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:140:18 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn none_of(&self, vals: Vec) -> Domspec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/csp/model.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | assert!(vals.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vals.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/csp/model.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | assert!(domspecs.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!domspecs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: field is never used: `pred` [INFO] [stderr] --> src/csp/model.rs:109:3 [INFO] [stderr] | [INFO] [stderr] 109 | pred: Pred, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `domspecs` [INFO] [stderr] --> src/csp/model.rs:110:3 [INFO] [stderr] | [INFO] [stderr] 110 | domspecs: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn get(&self, v: &V) -> Val { [INFO] [stderr] | ^^ help: consider passing by value instead: `V` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn has(&self, v: &V, val: &Val) -> bool { [INFO] [stderr] | ^^ help: consider passing by value instead: `V` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:78:25 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn is_a(&self, v: &V) -> bool { [INFO] [stderr] | ^^ help: consider passing by value instead: `V` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:82:27 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn is_una(&self, v: &V) -> bool { [INFO] [stderr] | ^^ help: consider passing by value instead: `V` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | pub fn is(&self, val: Val) -> Pred { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn is_not(&self, val: Val) -> Pred { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | pub fn one_of(&self, vals: Vec) -> Domspec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/csp/model.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | assert!(vals.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vals.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/csp/model.rs:140:18 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn none_of(&self, vals: Vec) -> Domspec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/csp/model.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | assert!(vals.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vals.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/csp/model.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | assert!(domspecs.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!domspecs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.54s [INFO] running `"docker" "inspect" "dae2211373a3551d7558c8280456b3766985a0cb5228f4da98b096c0249b8800"` [INFO] running `"docker" "rm" "-f" "dae2211373a3551d7558c8280456b3766985a0cb5228f4da98b096c0249b8800"` [INFO] [stdout] dae2211373a3551d7558c8280456b3766985a0cb5228f4da98b096c0249b8800