[INFO] updating cached repository komamitsu/tiny-rust-lisp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/komamitsu/tiny-rust-lisp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/komamitsu/tiny-rust-lisp" "work/ex/clippy-test-run/sources/stable/gh/komamitsu/tiny-rust-lisp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/komamitsu/tiny-rust-lisp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/komamitsu/tiny-rust-lisp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/komamitsu/tiny-rust-lisp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/komamitsu/tiny-rust-lisp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6da2dc40d3a3f382f2530509cab95995da6f3451 [INFO] sha for GitHub repo komamitsu/tiny-rust-lisp: 6da2dc40d3a3f382f2530509cab95995da6f3451 [INFO] validating manifest of komamitsu/tiny-rust-lisp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of komamitsu/tiny-rust-lisp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing komamitsu/tiny-rust-lisp [INFO] finished frobbing komamitsu/tiny-rust-lisp [INFO] frobbed toml for komamitsu/tiny-rust-lisp written to work/ex/clippy-test-run/sources/stable/gh/komamitsu/tiny-rust-lisp/Cargo.toml [INFO] started frobbing komamitsu/tiny-rust-lisp [INFO] finished frobbing komamitsu/tiny-rust-lisp [INFO] frobbed toml for komamitsu/tiny-rust-lisp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/komamitsu/tiny-rust-lisp/Cargo.toml [INFO] crate komamitsu/tiny-rust-lisp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting komamitsu/tiny-rust-lisp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/komamitsu/tiny-rust-lisp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 78023d45d10ec08978e41d34e23858bb61b870ba3c9a5690c2f74da372f4c97f [INFO] running `"docker" "start" "-a" "78023d45d10ec08978e41d34e23858bb61b870ba3c9a5690c2f74da372f4c97f"` [INFO] [stderr] Checking tiny-rust-lisp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:12:25 [INFO] [stderr] | [INFO] [stderr] 12 | ExtendedToken { token: token, index: index, len: len } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:12:39 [INFO] [stderr] | [INFO] [stderr] 12 | ExtendedToken { token: token, index: index, len: len } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:12:53 [INFO] [stderr] | [INFO] [stderr] 12 | ExtendedToken { token: token, index: index, len: len } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | Parser { tokens: tokens } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:12:25 [INFO] [stderr] | [INFO] [stderr] 12 | ExtendedToken { token: token, index: index, len: len } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:12:39 [INFO] [stderr] | [INFO] [stderr] 12 | ExtendedToken { token: token, index: index, len: len } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:12:53 [INFO] [stderr] | [INFO] [stderr] 12 | ExtendedToken { token: token, index: index, len: len } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | Parser { tokens: tokens } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval.rs:214:22 [INFO] [stderr] | [INFO] [stderr] 214 | else { [INFO] [stderr] | ______________________^ [INFO] [stderr] 215 | | if let Node::Keyword(ref k) = *arg.clone() { [INFO] [stderr] 216 | | key = Some(k.clone()) [INFO] [stderr] 217 | | } [INFO] [stderr] ... | [INFO] [stderr] 221 | | } [INFO] [stderr] 222 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 214 | else if let Node::Keyword(ref k) = *arg.clone() { [INFO] [stderr] 215 | key = Some(k.clone()) [INFO] [stderr] 216 | } [INFO] [stderr] 217 | else { [INFO] [stderr] 218 | return Err(EvalError(format!( [INFO] [stderr] 219 | "`setq` accepts only Node::Keyword as a key, but got {:?}", arg))); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eval.rs:214:22 [INFO] [stderr] | [INFO] [stderr] 214 | else { [INFO] [stderr] | ______________________^ [INFO] [stderr] 215 | | if let Node::Keyword(ref k) = *arg.clone() { [INFO] [stderr] 216 | | key = Some(k.clone()) [INFO] [stderr] 217 | | } [INFO] [stderr] ... | [INFO] [stderr] 221 | | } [INFO] [stderr] 222 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 214 | else if let Node::Keyword(ref k) = *arg.clone() { [INFO] [stderr] 215 | key = Some(k.clone()) [INFO] [stderr] 216 | } [INFO] [stderr] 217 | else { [INFO] [stderr] 218 | return Err(EvalError(format!( [INFO] [stderr] 219 | "`setq` accepts only Node::Keyword as a key, but got {:?}", arg))); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused variable: `node` [INFO] [stderr] --> src/eval.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | node: &Rc) -> Result, EvalError> { [INFO] [stderr] | ^^^^ help: consider using `_node` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `env` [INFO] [stderr] --> src/eval.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | env: &mut Env, [INFO] [stderr] | ^^^ help: consider using `_env` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `node` [INFO] [stderr] --> src/eval.rs:168:12 [INFO] [stderr] | [INFO] [stderr] 168 | node: &Rc) -> Result, EvalError> { [INFO] [stderr] | ^^^^ help: consider using `_node` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `env` [INFO] [stderr] --> src/eval.rs:183:12 [INFO] [stderr] | [INFO] [stderr] 183 | env: &mut Env, [INFO] [stderr] | ^^^ help: consider using `_env` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `node` [INFO] [stderr] --> src/eval.rs:185:12 [INFO] [stderr] | [INFO] [stderr] 185 | node: &Rc) -> Result, EvalError> { [INFO] [stderr] | ^^^^ help: consider using `_node` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `env` [INFO] [stderr] --> src/eval.rs:231:22 [INFO] [stderr] | [INFO] [stderr] 231 | fn lambda(&self, env: &mut Env, args: &[Rc], node: &Rc) -> Result, EvalError> { [INFO] [stderr] | ^^^ help: consider using `_env` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `node` [INFO] [stderr] --> src/eval.rs:231:56 [INFO] [stderr] | [INFO] [stderr] 231 | fn lambda(&self, env: &mut Env, args: &[Rc], node: &Rc) -> Result, EvalError> { [INFO] [stderr] | ^^^^ help: consider using `_node` instead [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `eval::Env` [INFO] [stderr] --> src/eval.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Self { [INFO] [stderr] 17 | | Env { [INFO] [stderr] 18 | | envs: vec![HashMap::new()] [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/eval.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn get(&self, key: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/eval.rs:48:33 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn remove(&mut self, k: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `eval::Eval` [INFO] [stderr] --> src/eval.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / pub fn new() -> Self { [INFO] [stderr] 69 | | Eval {} [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:101:35 [INFO] [stderr] | [INFO] [stderr] 101 | None => Err(EvalError(format!("Empty argument"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Empty argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:136:35 [INFO] [stderr] | [INFO] [stderr] 136 | None => Err(EvalError(format!("Empty argument"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Empty argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/eval.rs:191:69 [INFO] [stderr] | [INFO] [stderr] 191 | Some((_, tl)) => Rc::new(Node::QuotedList((*tl.clone()).to_vec())), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 191 | Some((_, tl)) => Rc::new(Node::QuotedList((*&(*tl).clone()).to_vec())), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 191 | Some((_, tl)) => Rc::new(Node::QuotedList((*&[std::rc::Rc]::clone(tl)).to_vec())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/eval.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | / match (&*args[0].clone(), &*args[1].clone()) { [INFO] [stderr] 234 | | (&Node::List(ref xs), &Node::List(ref body)) => { [INFO] [stderr] 235 | | let mut fargs = Vec::new(); [INFO] [stderr] 236 | | let mut errors = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 255 | | _ => () [INFO] [stderr] 256 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 233 | if let (&Node::List(ref xs), &Node::List(ref body)) = (&*args[0].clone(), &*args[1].clone()) { [INFO] [stderr] 234 | let mut fargs = Vec::new(); [INFO] [stderr] 235 | let mut errors = Vec::new(); [INFO] [stderr] 236 | [INFO] [stderr] 237 | for x in xs { [INFO] [stderr] 238 | match *x.clone() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/eval.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | / match *node.clone() { [INFO] [stderr] 265 | | Node::Func(ref xs, ref body) => { [INFO] [stderr] 266 | | if xs.len() != args.len() { [INFO] [stderr] 267 | | panic!("The numbers of argments don't match: expected({:?}), got({:?})", xs, args); [INFO] [stderr] ... | [INFO] [stderr] 283 | | _ => () [INFO] [stderr] 284 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 264 | if let Node::Func(ref xs, ref body) = *node.clone() { [INFO] [stderr] 265 | if xs.len() != args.len() { [INFO] [stderr] 266 | panic!("The numbers of argments don't match: expected({:?}), got({:?})", xs, args); [INFO] [stderr] 267 | } [INFO] [stderr] 268 | [INFO] [stderr] 269 | env.push_env(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | / match &*node.clone() { [INFO] [stderr] 293 | | &Node::Integer(_) => Ok(node), [INFO] [stderr] 294 | | &Node::Keyword(ref kwd) => { [INFO] [stderr] 295 | | let nd = match env.get(&kwd) { [INFO] [stderr] ... | [INFO] [stderr] 304 | | _ => Ok(node), [INFO] [stderr] 305 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 292 | match *node.clone() { [INFO] [stderr] 293 | Node::Integer(_) => Ok(node), [INFO] [stderr] 294 | Node::Keyword(ref kwd) => { [INFO] [stderr] 295 | let nd = match env.get(&kwd) { [INFO] [stderr] 296 | Some(x) => x, [INFO] [stderr] 297 | None => return Ok(Rc::new(Node::Keyword(kwd.clone()))), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/eval.rs:308:61 [INFO] [stderr] | [INFO] [stderr] 308 | fn eval_func(&self, env: &mut Env, node: &Rc, xs: &Vec>) -> Result, EvalError> { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Rc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | / if let &Node::Keyword(ref kwd) = &*hd.clone() { [INFO] [stderr] 311 | | match kwd.as_str() { [INFO] [stderr] 312 | | "+" => self.calc_integer(env, &|a, i| a + i, tl, node), [INFO] [stderr] 313 | | "-" => self.calc_integer(env, &|a, i| a - i, tl, node), [INFO] [stderr] ... | [INFO] [stderr] 337 | | Err(EvalError(format!("Unexpected node: {:?}", node))) [INFO] [stderr] 338 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 310 | if let Node::Keyword(ref kwd) = *hd.clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Lisp` [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Self { [INFO] [stderr] 36 | | Lisp { [INFO] [stderr] 37 | | eval: Eval::new(), [INFO] [stderr] 38 | | env: Env::new(), [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | impl Default for Lisp { [INFO] [stderr] 35 | fn default() -> Self { [INFO] [stderr] 36 | Self::new() [INFO] [stderr] 37 | } [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tiny-rust-lisp`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `node` [INFO] [stderr] --> src/eval.rs:143:21 [INFO] [stderr] | [INFO] [stderr] 143 | node: &Rc) -> Result, EvalError> { [INFO] [stderr] | ^^^^ help: consider using `_node` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `env` [INFO] [stderr] --> src/eval.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | env: &mut Env, [INFO] [stderr] | ^^^ help: consider using `_env` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `node` [INFO] [stderr] --> src/eval.rs:168:12 [INFO] [stderr] | [INFO] [stderr] 168 | node: &Rc) -> Result, EvalError> { [INFO] [stderr] | ^^^^ help: consider using `_node` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `env` [INFO] [stderr] --> src/eval.rs:183:12 [INFO] [stderr] | [INFO] [stderr] 183 | env: &mut Env, [INFO] [stderr] | ^^^ help: consider using `_env` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `node` [INFO] [stderr] --> src/eval.rs:185:12 [INFO] [stderr] | [INFO] [stderr] 185 | node: &Rc) -> Result, EvalError> { [INFO] [stderr] | ^^^^ help: consider using `_node` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `env` [INFO] [stderr] --> src/eval.rs:231:22 [INFO] [stderr] | [INFO] [stderr] 231 | fn lambda(&self, env: &mut Env, args: &[Rc], node: &Rc) -> Result, EvalError> { [INFO] [stderr] | ^^^ help: consider using `_env` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `node` [INFO] [stderr] --> src/eval.rs:231:56 [INFO] [stderr] | [INFO] [stderr] 231 | fn lambda(&self, env: &mut Env, args: &[Rc], node: &Rc) -> Result, EvalError> { [INFO] [stderr] | ^^^^ help: consider using `_node` instead [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `eval::Env` [INFO] [stderr] --> src/eval.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Self { [INFO] [stderr] 17 | | Env { [INFO] [stderr] 18 | | envs: vec![HashMap::new()] [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/eval.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn get(&self, key: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/eval.rs:48:33 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn remove(&mut self, k: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `eval::Eval` [INFO] [stderr] --> src/eval.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / pub fn new() -> Self { [INFO] [stderr] 69 | | Eval {} [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:101:35 [INFO] [stderr] | [INFO] [stderr] 101 | None => Err(EvalError(format!("Empty argument"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Empty argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/eval.rs:136:35 [INFO] [stderr] | [INFO] [stderr] 136 | None => Err(EvalError(format!("Empty argument"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Empty argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/eval.rs:191:69 [INFO] [stderr] | [INFO] [stderr] 191 | Some((_, tl)) => Rc::new(Node::QuotedList((*tl.clone()).to_vec())), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 191 | Some((_, tl)) => Rc::new(Node::QuotedList((*&(*tl).clone()).to_vec())), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 191 | Some((_, tl)) => Rc::new(Node::QuotedList((*&[std::rc::Rc]::clone(tl)).to_vec())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/eval.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | / match (&*args[0].clone(), &*args[1].clone()) { [INFO] [stderr] 234 | | (&Node::List(ref xs), &Node::List(ref body)) => { [INFO] [stderr] 235 | | let mut fargs = Vec::new(); [INFO] [stderr] 236 | | let mut errors = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 255 | | _ => () [INFO] [stderr] 256 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 233 | if let (&Node::List(ref xs), &Node::List(ref body)) = (&*args[0].clone(), &*args[1].clone()) { [INFO] [stderr] 234 | let mut fargs = Vec::new(); [INFO] [stderr] 235 | let mut errors = Vec::new(); [INFO] [stderr] 236 | [INFO] [stderr] 237 | for x in xs { [INFO] [stderr] 238 | match *x.clone() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/eval.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | / match *node.clone() { [INFO] [stderr] 265 | | Node::Func(ref xs, ref body) => { [INFO] [stderr] 266 | | if xs.len() != args.len() { [INFO] [stderr] 267 | | panic!("The numbers of argments don't match: expected({:?}), got({:?})", xs, args); [INFO] [stderr] ... | [INFO] [stderr] 283 | | _ => () [INFO] [stderr] 284 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 264 | if let Node::Func(ref xs, ref body) = *node.clone() { [INFO] [stderr] 265 | if xs.len() != args.len() { [INFO] [stderr] 266 | panic!("The numbers of argments don't match: expected({:?}), got({:?})", xs, args); [INFO] [stderr] 267 | } [INFO] [stderr] 268 | [INFO] [stderr] 269 | env.push_env(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | / match &*node.clone() { [INFO] [stderr] 293 | | &Node::Integer(_) => Ok(node), [INFO] [stderr] 294 | | &Node::Keyword(ref kwd) => { [INFO] [stderr] 295 | | let nd = match env.get(&kwd) { [INFO] [stderr] ... | [INFO] [stderr] 304 | | _ => Ok(node), [INFO] [stderr] 305 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 292 | match *node.clone() { [INFO] [stderr] 293 | Node::Integer(_) => Ok(node), [INFO] [stderr] 294 | Node::Keyword(ref kwd) => { [INFO] [stderr] 295 | let nd = match env.get(&kwd) { [INFO] [stderr] 296 | Some(x) => x, [INFO] [stderr] 297 | None => return Ok(Rc::new(Node::Keyword(kwd.clone()))), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/eval.rs:308:61 [INFO] [stderr] | [INFO] [stderr] 308 | fn eval_func(&self, env: &mut Env, node: &Rc, xs: &Vec>) -> Result, EvalError> { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Rc]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/eval.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | / if let &Node::Keyword(ref kwd) = &*hd.clone() { [INFO] [stderr] 311 | | match kwd.as_str() { [INFO] [stderr] 312 | | "+" => self.calc_integer(env, &|a, i| a + i, tl, node), [INFO] [stderr] 313 | | "-" => self.calc_integer(env, &|a, i| a - i, tl, node), [INFO] [stderr] ... | [INFO] [stderr] 337 | | Err(EvalError(format!("Unexpected node: {:?}", node))) [INFO] [stderr] 338 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 310 | if let Node::Keyword(ref kwd) = *hd.clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/eval.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | / Eval::new().eval( [INFO] [stderr] 443 | | env1, [INFO] [stderr] 444 | | Rc::new(Node::List( [INFO] [stderr] 445 | | vec![ [INFO] [stderr] ... | [INFO] [stderr] 467 | | )) [INFO] [stderr] 468 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Lisp` [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Self { [INFO] [stderr] 36 | | Lisp { [INFO] [stderr] 37 | | eval: Eval::new(), [INFO] [stderr] 38 | | env: Env::new(), [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | impl Default for Lisp { [INFO] [stderr] 35 | fn default() -> Self { [INFO] [stderr] 36 | Self::new() [INFO] [stderr] 37 | } [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tiny-rust-lisp`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "78023d45d10ec08978e41d34e23858bb61b870ba3c9a5690c2f74da372f4c97f"` [INFO] running `"docker" "rm" "-f" "78023d45d10ec08978e41d34e23858bb61b870ba3c9a5690c2f74da372f4c97f"` [INFO] [stdout] 78023d45d10ec08978e41d34e23858bb61b870ba3c9a5690c2f74da372f4c97f