[INFO] updating cached repository kolgotko/command-pattern.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kolgotko/command-pattern.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kolgotko/command-pattern.rs" "work/ex/clippy-test-run/sources/stable/gh/kolgotko/command-pattern.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kolgotko/command-pattern.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kolgotko/command-pattern.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kolgotko/command-pattern.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kolgotko/command-pattern.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eba781b92bbdcf1fa831ff36ac9df160259c2520 [INFO] sha for GitHub repo kolgotko/command-pattern.rs: eba781b92bbdcf1fa831ff36ac9df160259c2520 [INFO] validating manifest of kolgotko/command-pattern.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kolgotko/command-pattern.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kolgotko/command-pattern.rs [INFO] finished frobbing kolgotko/command-pattern.rs [INFO] frobbed toml for kolgotko/command-pattern.rs written to work/ex/clippy-test-run/sources/stable/gh/kolgotko/command-pattern.rs/Cargo.toml [INFO] started frobbing kolgotko/command-pattern.rs [INFO] finished frobbing kolgotko/command-pattern.rs [INFO] frobbed toml for kolgotko/command-pattern.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kolgotko/command-pattern.rs/Cargo.toml [INFO] crate kolgotko/command-pattern.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kolgotko/command-pattern.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kolgotko/command-pattern.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cbe086eae43ad4cf5cd9a5e1d327867d37a197f233a3f1594a03e414ac72c288 [INFO] running `"docker" "start" "-a" "cbe086eae43ad4cf5cd9a5e1d327867d37a197f233a3f1594a03e414ac72c288"` [INFO] [stderr] Checking command_pattern v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:5:27 [INFO] [stderr] | [INFO] [stderr] 5 | fn get_exec(&self) -> &Box Result + Send + Sync>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&Fn() -> Result + Send + Sync` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:6:29 [INFO] [stderr] | [INFO] [stderr] 6 | fn get_unexec(&self) -> &Box Result<(), U> + Send + Sync>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&Fn() -> Result<(), U> + Send + Sync` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Invoker` [INFO] [stderr] --> src/lib.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn new() -> Self { [INFO] [stderr] 37 | | Invoker { [INFO] [stderr] 38 | | commands: Vec::new(), [INFO] [stderr] 39 | | undo_commands: Vec::new(), [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:5:27 [INFO] [stderr] | [INFO] [stderr] 5 | fn get_exec(&self) -> &Box Result + Send + Sync>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&Fn() -> Result + Send + Sync` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:6:29 [INFO] [stderr] | [INFO] [stderr] 6 | fn get_unexec(&self) -> &Box Result<(), U> + Send + Sync>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&Fn() -> Result<(), U> + Send + Sync` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Invoker` [INFO] [stderr] --> src/lib.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn new() -> Self { [INFO] [stderr] 37 | | Invoker { [INFO] [stderr] 38 | | commands: Vec::new(), [INFO] [stderr] 39 | | undo_commands: Vec::new(), [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.65s [INFO] running `"docker" "inspect" "cbe086eae43ad4cf5cd9a5e1d327867d37a197f233a3f1594a03e414ac72c288"` [INFO] running `"docker" "rm" "-f" "cbe086eae43ad4cf5cd9a5e1d327867d37a197f233a3f1594a03e414ac72c288"` [INFO] [stdout] cbe086eae43ad4cf5cd9a5e1d327867d37a197f233a3f1594a03e414ac72c288