[INFO] updating cached repository kolen/mm_map_tools [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kolen/mm_map_tools [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kolen/mm_map_tools" "work/ex/clippy-test-run/sources/stable/gh/kolen/mm_map_tools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kolen/mm_map_tools'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kolen/mm_map_tools" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kolen/mm_map_tools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kolen/mm_map_tools'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 70d2a608a3cf6f3541db646a6c309c47fe05821a [INFO] sha for GitHub repo kolen/mm_map_tools: 70d2a608a3cf6f3541db646a6c309c47fe05821a [INFO] validating manifest of kolen/mm_map_tools on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kolen/mm_map_tools on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kolen/mm_map_tools [INFO] finished frobbing kolen/mm_map_tools [INFO] frobbed toml for kolen/mm_map_tools written to work/ex/clippy-test-run/sources/stable/gh/kolen/mm_map_tools/Cargo.toml [INFO] started frobbing kolen/mm_map_tools [INFO] finished frobbing kolen/mm_map_tools [INFO] frobbed toml for kolen/mm_map_tools written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kolen/mm_map_tools/Cargo.toml [INFO] crate kolen/mm_map_tools has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kolen/mm_map_tools against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kolen/mm_map_tools:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 09b90e7b98120f43a446685b104fedb63ef6f13aa44f70197c9e5696b3094b41 [INFO] running `"docker" "start" "-a" "09b90e7b98120f43a446685b104fedb63ef6f13aa44f70197c9e5696b3094b41"` [INFO] [stderr] Compiling gio v0.5.1 [INFO] [stderr] Compiling gdk-pixbuf v0.5.0 [INFO] [stderr] Compiling gdk v0.9.0 [INFO] [stderr] Compiling gtk v0.5.0 [INFO] [stderr] Compiling glib-sys v0.7.0 [INFO] [stderr] Compiling gobject-sys v0.7.0 [INFO] [stderr] Compiling gio-sys v0.7.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.7.0 [INFO] [stderr] Compiling pango-sys v0.7.0 [INFO] [stderr] Compiling gdk-sys v0.7.0 [INFO] [stderr] Compiling gtk-sys v0.7.0 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking deflate v0.7.17 [INFO] [stderr] Checking gif v0.10.1 [INFO] [stderr] Compiling mm_map_tools v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking num-complex v0.2.1 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking num-iter v0.1.35 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] warning: src/mmdecrypt.c: In function 'prng_init': [INFO] [stderr] warning: src/mmdecrypt.c:236:21: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] [INFO] [stderr] warning: *p = HIDWORD(t) & 0xFFFF0000 | ((uint32_t)t >> 16); [INFO] [stderr] warning: ^ [INFO] [stderr] warning: src/mmdecrypt.c:241:5: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] [INFO] [stderr] warning: q = table + 5; [INFO] [stderr] warning: ^ [INFO] [stderr] warning: src/mmdecrypt.c:244:16: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] [INFO] [stderr] warning: *q = k | a & b; [INFO] [stderr] warning: ~~^~~ [INFO] [stderr] warning: src/mmdecrypt.c:213:10: warning: variable 'count' set but not used [-Wunused-but-set-variable] [INFO] [stderr] warning: int i, count; [INFO] [stderr] warning: ^~~~~ [INFO] [stderr] Compiling cairo-sys-rs v0.7.0 [INFO] [stderr] Compiling atk-sys v0.7.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Compiling cairo-rs v0.5.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking glib v0.6.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking nalgebra v0.16.11 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking pango v0.5.0 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite_file.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | frames: frames, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `frames` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite_file.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | pallette: pallette, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pallette` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decompress.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | DecompressError::FileError { error: error } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map_section.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | contents: contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite_file.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | frames: frames, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `frames` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprite_file.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | pallette: pallette, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pallette` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decompress.rs:82:38 [INFO] [stderr] | [INFO] [stderr] 82 | DecompressError::FileError { error: error } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/map_section.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | contents: contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: function is never used: `indexed_to_rgba` [INFO] [stderr] --> src/sprite_file.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | fn indexed_to_rgba(pixel: Option, pallette: Pallette) -> Rgba8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `rotate_tile_coordinates` [INFO] [stderr] --> src/render/mod.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / fn rotate_tile_coordinates( [INFO] [stderr] 18 | | source: TileCoordinates, [INFO] [stderr] 19 | | size_x: u32, [INFO] [stderr] 20 | | size_y: u32, [INFO] [stderr] ... | [INFO] [stderr] 43 | | Vector3::new(tilexy2.x, tilexy2.y, source.z) [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.map` [INFO] [stderr] --> src/sprite_file.rs:60:22 [INFO] [stderr] | [INFO] [stderr] 60 | let frames = header [INFO] [stderr] | ______________________^ [INFO] [stderr] 61 | | .frame_offsets [INFO] [stderr] 62 | | .iter() [INFO] [stderr] 63 | | .filter_map(|&offset| { [INFO] [stderr] ... | [INFO] [stderr] 68 | | ) [INFO] [stderr] 69 | | }).collect(); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/sprite_file.rs:66:26 [INFO] [stderr] | [INFO] [stderr] 66 | .expect(&format!("Can't decode frame at {}", offset)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't decode frame at {}", offset))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sprite_file.rs:115:15 [INFO] [stderr] | [INFO] [stderr] 115 | pallette: &Pallette, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sprite_file.rs:138:26 [INFO] [stderr] | [INFO] [stderr] 138 | frame<'a>(pallettes: &'a Vec) <&'a [u8], Frame>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Pallette]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/render/mod.rs:98:1 [INFO] [stderr] | [INFO] [stderr] 98 | / fn map_rendering_order<'a>( [INFO] [stderr] 99 | | map_section: &'a MapSection, [INFO] [stderr] 100 | | max_z: u32, [INFO] [stderr] 101 | | ) -> impl Iterator { [INFO] [stderr] ... | [INFO] [stderr] 109 | | }) [INFO] [stderr] 110 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: function is never used: `indexed_to_rgba` [INFO] [stderr] --> src/sprite_file.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | fn indexed_to_rgba(pixel: Option, pallette: Pallette) -> Rgba8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `rotate_tile_coordinates` [INFO] [stderr] --> src/render/mod.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / fn rotate_tile_coordinates( [INFO] [stderr] 18 | | source: TileCoordinates, [INFO] [stderr] 19 | | size_x: u32, [INFO] [stderr] 20 | | size_y: u32, [INFO] [stderr] ... | [INFO] [stderr] 43 | | Vector3::new(tilexy2.x, tilexy2.y, source.z) [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_file_contents` [INFO] [stderr] --> src/test_utils.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn test_file_contents(filename: &str) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.map` [INFO] [stderr] --> src/sprite_file.rs:60:22 [INFO] [stderr] | [INFO] [stderr] 60 | let frames = header [INFO] [stderr] | ______________________^ [INFO] [stderr] 61 | | .frame_offsets [INFO] [stderr] 62 | | .iter() [INFO] [stderr] 63 | | .filter_map(|&offset| { [INFO] [stderr] ... | [INFO] [stderr] 68 | | ) [INFO] [stderr] 69 | | }).collect(); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/sprite_file.rs:66:26 [INFO] [stderr] | [INFO] [stderr] 66 | .expect(&format!("Can't decode frame at {}", offset)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't decode frame at {}", offset))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sprite_file.rs:115:15 [INFO] [stderr] | [INFO] [stderr] 115 | pallette: &Pallette, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sprite_file.rs:138:26 [INFO] [stderr] | [INFO] [stderr] 138 | frame<'a>(pallettes: &'a Vec) <&'a [u8], Frame>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Pallette]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/decompress.rs:186:34 [INFO] [stderr] | [INFO] [stderr] 186 | let decoded = decompress(&mut vec![0; 10]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0; 10]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/render/mod.rs:98:1 [INFO] [stderr] | [INFO] [stderr] 98 | / fn map_rendering_order<'a>( [INFO] [stderr] 99 | | map_section: &'a MapSection, [INFO] [stderr] 100 | | max_z: u32, [INFO] [stderr] 101 | | ) -> impl Iterator { [INFO] [stderr] ... | [INFO] [stderr] 109 | | }) [INFO] [stderr] 110 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/viewer.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | max_layer: max_layer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_layer` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/viewer.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | max_layer: max_layer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_layer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0061]: this function takes 3 parameters but 2 parameters were supplied [INFO] [stderr] --> src/bin/render_map_section.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | let image = render_map_section(&map_section, &sprites); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected 3 parameters [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0061`. [INFO] [stderr] The following warnings were emitted during compilation: [INFO] [stderr] [INFO] [stderr] warning: src/mmdecrypt.c: In function 'prng_init': [INFO] [stderr] warning: src/mmdecrypt.c:236:21: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] [INFO] [stderr] warning: *p = HIDWORD(t) & 0xFFFF0000 | ((uint32_t)t >> 16); [INFO] [stderr] warning: ^ [INFO] [stderr] warning: src/mmdecrypt.c:241:5: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] [INFO] [stderr] warning: q = table + 5; [INFO] [stderr] warning: ^ [INFO] [stderr] warning: src/mmdecrypt.c:244:16: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] [INFO] [stderr] warning: *q = k | a & b; [INFO] [stderr] warning: ~~^~~ [INFO] [stderr] warning: src/mmdecrypt.c:213:10: warning: variable 'count' set but not used [-Wunused-but-set-variable] [INFO] [stderr] warning: int i, count; [INFO] [stderr] warning: ^~~~~ [INFO] [stderr] [INFO] [stderr] error: Could not compile `mm_map_tools`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0061]: this function takes 3 parameters but 2 parameters were supplied [INFO] [stderr] --> src/bin/render_map_section.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | let image = render_map_section(&map_section, &sprites); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected 3 parameters [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0061`. [INFO] [stderr] The following warnings were emitted during compilation: [INFO] [stderr] [INFO] [stderr] warning: src/mmdecrypt.c: In function 'prng_init': [INFO] [stderr] warning: src/mmdecrypt.c:236:21: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] [INFO] [stderr] warning: *p = HIDWORD(t) & 0xFFFF0000 | ((uint32_t)t >> 16); [INFO] [stderr] warning: ^ [INFO] [stderr] warning: src/mmdecrypt.c:241:5: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] [INFO] [stderr] warning: q = table + 5; [INFO] [stderr] warning: ^ [INFO] [stderr] warning: src/mmdecrypt.c:244:16: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] [INFO] [stderr] warning: *q = k | a & b; [INFO] [stderr] warning: ~~^~~ [INFO] [stderr] warning: src/mmdecrypt.c:213:10: warning: variable 'count' set but not used [-Wunused-but-set-variable] [INFO] [stderr] warning: int i, count; [INFO] [stderr] warning: ^~~~~ [INFO] [stderr] [INFO] [stderr] error: Could not compile `mm_map_tools`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/viewer.rs:238:21 [INFO] [stderr] | [INFO] [stderr] 238 | current_max_layer.borrow().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_max_layer.borrow()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bin/viewer.rs:238:21 [INFO] [stderr] | [INFO] [stderr] 238 | current_max_layer.borrow().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_max_layer.borrow()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "09b90e7b98120f43a446685b104fedb63ef6f13aa44f70197c9e5696b3094b41"` [INFO] running `"docker" "rm" "-f" "09b90e7b98120f43a446685b104fedb63ef6f13aa44f70197c9e5696b3094b41"` [INFO] [stdout] 09b90e7b98120f43a446685b104fedb63ef6f13aa44f70197c9e5696b3094b41