[INFO] updating cached repository kojole/benchmark-concurrent-io [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kojole/benchmark-concurrent-io [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kojole/benchmark-concurrent-io" "work/ex/clippy-test-run/sources/stable/gh/kojole/benchmark-concurrent-io"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kojole/benchmark-concurrent-io'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kojole/benchmark-concurrent-io" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kojole/benchmark-concurrent-io"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kojole/benchmark-concurrent-io'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5670befbccd0f25b281482f1fa0009f0e321a18a [INFO] sha for GitHub repo kojole/benchmark-concurrent-io: 5670befbccd0f25b281482f1fa0009f0e321a18a [INFO] validating manifest of kojole/benchmark-concurrent-io on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kojole/benchmark-concurrent-io on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kojole/benchmark-concurrent-io [INFO] finished frobbing kojole/benchmark-concurrent-io [INFO] frobbed toml for kojole/benchmark-concurrent-io written to work/ex/clippy-test-run/sources/stable/gh/kojole/benchmark-concurrent-io/Cargo.toml [INFO] started frobbing kojole/benchmark-concurrent-io [INFO] finished frobbing kojole/benchmark-concurrent-io [INFO] frobbed toml for kojole/benchmark-concurrent-io written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kojole/benchmark-concurrent-io/Cargo.toml [INFO] crate kojole/benchmark-concurrent-io has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kojole/benchmark-concurrent-io against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kojole/benchmark-concurrent-io:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8e9abccab6217cad4638b6538862f2bfd8d3db9f1e77bdaef804fa2afe6c7dbb [INFO] running `"docker" "start" "-a" "8e9abccab6217cad4638b6538862f2bfd8d3db9f1e77bdaef804fa2afe6c7dbb"` [INFO] [stderr] Checking docopt v1.0.0 [INFO] [stderr] Checking conio v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/cmd/read.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | let count = (num_segments as f64 / num_threads as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_segments)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/cmd/read.rs:17:40 [INFO] [stderr] | [INFO] [stderr] 17 | let count = (num_segments as f64 / num_threads as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_threads)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cmd/read.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | for i in 0..(num_threads as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(num_threads)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cmd/read.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | let pos = self.range.start as u64 * SEGMENT_SIZE as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.range.start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cmd/read.rs:69:20 [INFO] [stderr] | [INFO] [stderr] 69 | sum += segment.id() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(segment.id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/cmd/write.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | let count = (num_segments as f64 / num_threads as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_segments)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/cmd/write.rs:17:40 [INFO] [stderr] | [INFO] [stderr] 17 | let count = (num_segments as f64 / num_threads as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_threads)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cmd/write.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | for i in 0..(num_threads as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(num_threads)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cmd/write.rs:60:19 [INFO] [stderr] | [INFO] [stderr] 60 | let pos = self.range.start as u64 * SEGMENT_SIZE as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.range.start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/segment.rs:24:33 [INFO] [stderr] | [INFO] [stderr] 24 | let p: *const u32 = transmute(self.inner); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.inner as *const u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/segment.rs:31:31 [INFO] [stderr] | [INFO] [stderr] 31 | let p: *mut u32 = transmute(self.inner); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.inner as *mut u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/cmd/read.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | let count = (num_segments as f64 / num_threads as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_segments)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/cmd/read.rs:17:40 [INFO] [stderr] | [INFO] [stderr] 17 | let count = (num_segments as f64 / num_threads as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_threads)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cmd/read.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | for i in 0..(num_threads as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(num_threads)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cmd/read.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | let pos = self.range.start as u64 * SEGMENT_SIZE as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.range.start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cmd/read.rs:69:20 [INFO] [stderr] | [INFO] [stderr] 69 | sum += segment.id() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(segment.id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/cmd/write.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | let count = (num_segments as f64 / num_threads as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_segments)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/cmd/write.rs:17:40 [INFO] [stderr] | [INFO] [stderr] 17 | let count = (num_segments as f64 / num_threads as f64).ceil() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_threads)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cmd/write.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | for i in 0..(num_threads as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(num_threads)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cmd/write.rs:60:19 [INFO] [stderr] | [INFO] [stderr] 60 | let pos = self.range.start as u64 * SEGMENT_SIZE as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.range.start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/segment.rs:24:33 [INFO] [stderr] | [INFO] [stderr] 24 | let p: *const u32 = transmute(self.inner); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.inner as *const u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/segment.rs:31:31 [INFO] [stderr] | [INFO] [stderr] 31 | let p: *mut u32 = transmute(self.inner); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.inner as *mut u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.80s [INFO] running `"docker" "inspect" "8e9abccab6217cad4638b6538862f2bfd8d3db9f1e77bdaef804fa2afe6c7dbb"` [INFO] running `"docker" "rm" "-f" "8e9abccab6217cad4638b6538862f2bfd8d3db9f1e77bdaef804fa2afe6c7dbb"` [INFO] [stdout] 8e9abccab6217cad4638b6538862f2bfd8d3db9f1e77bdaef804fa2afe6c7dbb