[INFO] updating cached repository kogai/sync-memo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kogai/sync-memo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kogai/sync-memo" "work/ex/clippy-test-run/sources/stable/gh/kogai/sync-memo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kogai/sync-memo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kogai/sync-memo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/sync-memo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/sync-memo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c8c680b298287852b20c38116a9f1a00624400ee [INFO] sha for GitHub repo kogai/sync-memo: c8c680b298287852b20c38116a9f1a00624400ee [INFO] validating manifest of kogai/sync-memo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kogai/sync-memo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kogai/sync-memo [INFO] finished frobbing kogai/sync-memo [INFO] frobbed toml for kogai/sync-memo written to work/ex/clippy-test-run/sources/stable/gh/kogai/sync-memo/Cargo.toml [INFO] started frobbing kogai/sync-memo [INFO] finished frobbing kogai/sync-memo [INFO] frobbed toml for kogai/sync-memo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/sync-memo/Cargo.toml [INFO] crate kogai/sync-memo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kogai/sync-memo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kogai/sync-memo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 60fca3e071620d6c21e17363e3e557520801513b563b6f4baa9a9a86f30571b7 [INFO] running `"docker" "start" "-a" "60fca3e071620d6c21e17363e3e557520801513b563b6f4baa9a9a86f30571b7"` [INFO] [stderr] Checking serde v1.0.2 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking thread-id v3.0.0 [INFO] [stderr] Checking term_size v0.2.3 [INFO] [stderr] Checking inotify v0.3.0 [INFO] [stderr] Checking filetime v0.1.10 [INFO] [stderr] Checking daemonize v0.2.3 [INFO] [stderr] Checking net2 v0.2.27 [INFO] [stderr] Checking unsafe-any v0.4.1 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking libflate v0.1.5 [INFO] [stderr] Checking humantime v1.0.0 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking ordered-float v0.4.0 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking clap v2.22.2 [INFO] [stderr] Checking backtrace-sys v0.1.10 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Compiling serde_derive_internals v0.15.0 [INFO] [stderr] Compiling derive-error-chain v0.10.0 [INFO] [stderr] Compiling serde_codegen_internals v0.14.2 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking openssl v0.9.11 [INFO] [stderr] Checking serde_urlencoded v0.4.2 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking backtrace v0.3.0 [INFO] [stderr] Checking chrono v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.2 [INFO] [stderr] Compiling serde_derive v0.9.15 [INFO] [stderr] Checking hyper v0.10.9 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking config_file_handler v0.6.0 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking native-tls v0.1.2 [INFO] [stderr] Checking serde_json v1.0.1 [INFO] [stderr] Checking serde_yaml v0.7.0 [INFO] [stderr] Checking serde-value v0.5.0 [INFO] [stderr] Checking notify v4.0.1 [INFO] [stderr] Checking dotenv v0.10.0 [INFO] [stderr] Checking hyper-native-tls v0.2.2 [INFO] [stderr] Checking reqwest v0.5.1 [INFO] [stderr] Checking log4rs v0.7.0 [INFO] [stderr] Checking sync-memo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/github.rs:97:46 [INFO] [stderr] | [INFO] [stderr] 97 | files.insert(file_name_string, Content { content: content }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/github.rs:97:46 [INFO] [stderr] | [INFO] [stderr] 97 | files.insert(file_name_string, Content { content: content }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/github.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/github.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | file_path: file_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/github.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/github.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/handler.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | file_path: file_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/github.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | const GITHUB_API: &'static str = "https://api.github.com"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/daemon.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | pub const SOCKET_ADDR: &'static str = "/tmp/sync-memo.sock"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/daemon.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | pub const PID_FILE: &'static str = "/tmp/sync-memo.pid"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/github.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | const GITHUB_API: &'static str = "https://api.github.com"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/daemon.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | pub const SOCKET_ADDR: &'static str = "/tmp/sync-memo.sock"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/daemon.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | pub const PID_FILE: &'static str = "/tmp/sync-memo.pid"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/client.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/client.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/github.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | let path_to_env = env::home_dir().and_then(|a| Some(a.join("sync-memo").join(".env"))); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | let log_config_path = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | let path = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/github.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | let path_to_env = env::home_dir().and_then(|a| Some(a.join("sync-memo").join(".env"))); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | let log_config_path = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:35:16 [INFO] [stderr] | [INFO] [stderr] 35 | let path = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/github.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / match path_to_env { [INFO] [stderr] 15 | | Some(x) => { [INFO] [stderr] 16 | | dotenv::from_path(x.as_path()).ok(); [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | None => {} [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | if let Some(x) = path_to_env { [INFO] [stderr] 15 | dotenv::from_path(x.as_path()).ok(); [INFO] [stderr] 16 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/github.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | .expect(&format!("Missing environment parameter GITHUB_ACCESS_TOKEN")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Missing environment parameter GITHUB_ACCESS_TOKEN"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/github.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | .expect(&format!("Missing environment parameter GITHUB_ACCESS_TOKEN")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Missing environment parameter GITHUB_ACCESS_TOKEN".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/github.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / match self { [INFO] [stderr] 48 | | &GistResponse::Success(ref gist_files) => { [INFO] [stderr] 49 | | let gist_file_names = gist_files [INFO] [stderr] 50 | | .files [INFO] [stderr] ... | [INFO] [stderr] 60 | | &GistResponse::NotFound { ref message } => write!(formatter, "{}", message), [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | match *self { [INFO] [stderr] 48 | GistResponse::Success(ref gist_files) => { [INFO] [stderr] 49 | let gist_file_names = gist_files [INFO] [stderr] 50 | .files [INFO] [stderr] 51 | .iter() [INFO] [stderr] 52 | .map(|(file_name, _)| file_name.to_owned()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/watcher.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn watch(path: &String, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 12 | pub fn watch(path: &str, [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `path.as_str()` to [INFO] [stderr] | [INFO] [stderr] 16 | let path_to_file = path; [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `path.clone()` to [INFO] [stderr] | [INFO] [stderr] 27 | let gist_modified = github::modify_gist(gist_id, path.to_string(), contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/daemon.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | / loop { [INFO] [stderr] 109 | | match stream.read(&mut buffer) { [INFO] [stderr] 110 | | Ok(chunk_size) => { [INFO] [stderr] 111 | | println!("chunk size -> {}", chunk_size); [INFO] [stderr] ... | [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/client.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn to_string<'a>(&self) -> String { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / match self { [INFO] [stderr] 47 | | &Response::Info(ref payload) => { [INFO] [stderr] 48 | | info!("{}", payload); [INFO] [stderr] 49 | | } [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 46 | match *self { [INFO] [stderr] 47 | Response::Info(ref payload) => { [INFO] [stderr] 48 | info!("{}", payload); [INFO] [stderr] 49 | } [INFO] [stderr] 50 | Response::Error(ref payload) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sync-memo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/github.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / match path_to_env { [INFO] [stderr] 15 | | Some(x) => { [INFO] [stderr] 16 | | dotenv::from_path(x.as_path()).ok(); [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | None => {} [INFO] [stderr] 19 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | if let Some(x) = path_to_env { [INFO] [stderr] 15 | dotenv::from_path(x.as_path()).ok(); [INFO] [stderr] 16 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/github.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | .expect(&format!("Missing environment parameter GITHUB_ACCESS_TOKEN")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Missing environment parameter GITHUB_ACCESS_TOKEN"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/github.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | .expect(&format!("Missing environment parameter GITHUB_ACCESS_TOKEN")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Missing environment parameter GITHUB_ACCESS_TOKEN".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/github.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / match self { [INFO] [stderr] 48 | | &GistResponse::Success(ref gist_files) => { [INFO] [stderr] 49 | | let gist_file_names = gist_files [INFO] [stderr] 50 | | .files [INFO] [stderr] ... | [INFO] [stderr] 60 | | &GistResponse::NotFound { ref message } => write!(formatter, "{}", message), [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | match *self { [INFO] [stderr] 48 | GistResponse::Success(ref gist_files) => { [INFO] [stderr] 49 | let gist_file_names = gist_files [INFO] [stderr] 50 | .files [INFO] [stderr] 51 | .iter() [INFO] [stderr] 52 | .map(|(file_name, _)| file_name.to_owned()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/watcher.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn watch(path: &String, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 12 | pub fn watch(path: &str, [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `path.as_str()` to [INFO] [stderr] | [INFO] [stderr] 16 | let path_to_file = path; [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `path.clone()` to [INFO] [stderr] | [INFO] [stderr] 27 | let gist_modified = github::modify_gist(gist_id, path.to_string(), contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/daemon.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | / loop { [INFO] [stderr] 109 | | match stream.read(&mut buffer) { [INFO] [stderr] 110 | | Ok(chunk_size) => { [INFO] [stderr] 111 | | println!("chunk size -> {}", chunk_size); [INFO] [stderr] ... | [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/client.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn to_string<'a>(&self) -> String { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / match self { [INFO] [stderr] 47 | | &Response::Info(ref payload) => { [INFO] [stderr] 48 | | info!("{}", payload); [INFO] [stderr] 49 | | } [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 46 | match *self { [INFO] [stderr] 47 | Response::Info(ref payload) => { [INFO] [stderr] 48 | info!("{}", payload); [INFO] [stderr] 49 | } [INFO] [stderr] 50 | Response::Error(ref payload) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/client.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | / server [INFO] [stderr] 95 | | .read(&mut buffer) [INFO] [stderr] 96 | | .expect("server couldnt read request"); [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sync-memo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "60fca3e071620d6c21e17363e3e557520801513b563b6f4baa9a9a86f30571b7"` [INFO] running `"docker" "rm" "-f" "60fca3e071620d6c21e17363e3e557520801513b563b6f4baa9a9a86f30571b7"` [INFO] [stdout] 60fca3e071620d6c21e17363e3e557520801513b563b6f4baa9a9a86f30571b7