[INFO] updating cached repository kogai/arisama [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kogai/arisama [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kogai/arisama" "work/ex/clippy-test-run/sources/stable/gh/kogai/arisama"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kogai/arisama'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kogai/arisama" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/arisama"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/arisama'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b957ed9dbf035f464fa31c95c0203daac3631357 [INFO] sha for GitHub repo kogai/arisama: b957ed9dbf035f464fa31c95c0203daac3631357 [INFO] validating manifest of kogai/arisama on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kogai/arisama on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kogai/arisama [INFO] finished frobbing kogai/arisama [INFO] frobbed toml for kogai/arisama written to work/ex/clippy-test-run/sources/stable/gh/kogai/arisama/Cargo.toml [INFO] started frobbing kogai/arisama [INFO] finished frobbing kogai/arisama [INFO] frobbed toml for kogai/arisama written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kogai/arisama/Cargo.toml [INFO] crate kogai/arisama has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kogai/arisama against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kogai/arisama:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ddba91c8a0dc1b4576acadba02f59b991b4df1225a4faddcb686481fa0c24b38 [INFO] running `"docker" "start" "-a" "ddba91c8a0dc1b4576acadba02f59b991b4df1225a4faddcb686481fa0c24b38"` [INFO] [stderr] Checking serde v0.9.14 [INFO] [stderr] Checking conduit-mime-types v0.7.3 [INFO] [stderr] Checking uuid v0.2.3 [INFO] [stderr] Compiling syn v0.11.10 [INFO] [stderr] Checking backtrace-sys v0.1.10 [INFO] [stderr] Checking openssl-sys v0.9.11 [INFO] [stderr] Checking hyper v0.10.9 [INFO] [stderr] Checking backtrace v0.3.0 [INFO] [stderr] Checking openssl v0.9.11 [INFO] [stderr] Checking error-chain v0.7.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking cookie v0.5.1 [INFO] [stderr] Compiling derive-error-chain v0.10.0 [INFO] [stderr] Checking persistent v0.3.0 [INFO] [stderr] Checking iron-test v0.5.0 [INFO] [stderr] Checking iron-sessionstorage v0.6.6 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking mount v0.3.0 [INFO] [stderr] Checking bodyparser v0.5.0 [INFO] [stderr] Checking dotenv v0.10.0 [INFO] [stderr] Checking urlencoded v0.5.0 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking arisama v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/routes/main_controller.rs:13:62 [INFO] [stderr] | [INFO] [stderr] 13 | let queries = req.get::().unwrap_or((HashMap::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/routes/main_controller.rs:13:62 [INFO] [stderr] | [INFO] [stderr] 13 | let queries = req.get::().unwrap_or((HashMap::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/utils/mod.rs:4:20 [INFO] [stderr] | [INFO] [stderr] 4 | env::var(kind).expect(&format!("Missing environment parameter {}", kind)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Missing environment parameter {}", kind))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/routes/main_controller.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | let queries = req.get::().unwrap_or((HashMap::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `req.get::().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/routes/main_controller.rs:14:44 [INFO] [stderr] | [INFO] [stderr] 14 | let response = to_string(&queries).unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/routes/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Router { [INFO] [stderr] 10 | | let mut router = Router::new(); [INFO] [stderr] 11 | | router.get("/", main_controller::Index, "index"); [INFO] [stderr] 12 | | router [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/routes/main_controller.rs:13:62 [INFO] [stderr] | [INFO] [stderr] 13 | let queries = req.get::().unwrap_or((HashMap::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/routes/main_controller.rs:13:62 [INFO] [stderr] | [INFO] [stderr] 13 | let queries = req.get::().unwrap_or((HashMap::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/utils/mod.rs:4:20 [INFO] [stderr] | [INFO] [stderr] 4 | env::var(kind).expect(&format!("Missing environment parameter {}", kind)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Missing environment parameter {}", kind))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/routes/main_controller.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | let queries = req.get::().unwrap_or((HashMap::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `req.get::().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/routes/main_controller.rs:14:44 [INFO] [stderr] | [INFO] [stderr] 14 | let response = to_string(&queries).unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/routes/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Router { [INFO] [stderr] 10 | | let mut router = Router::new(); [INFO] [stderr] 11 | | router.get("/", main_controller::Index, "index"); [INFO] [stderr] 12 | | router [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.44s [INFO] running `"docker" "inspect" "ddba91c8a0dc1b4576acadba02f59b991b4df1225a4faddcb686481fa0c24b38"` [INFO] running `"docker" "rm" "-f" "ddba91c8a0dc1b4576acadba02f59b991b4df1225a4faddcb686481fa0c24b38"` [INFO] [stdout] ddba91c8a0dc1b4576acadba02f59b991b4df1225a4faddcb686481fa0c24b38