[INFO] updating cached repository kodek16/rs-view-tracker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kodek16/rs-view-tracker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kodek16/rs-view-tracker" "work/ex/clippy-test-run/sources/stable/gh/kodek16/rs-view-tracker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kodek16/rs-view-tracker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kodek16/rs-view-tracker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kodek16/rs-view-tracker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kodek16/rs-view-tracker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] de52bbe24b285feba1f0241792f746cc2943effa [INFO] sha for GitHub repo kodek16/rs-view-tracker: de52bbe24b285feba1f0241792f746cc2943effa [INFO] validating manifest of kodek16/rs-view-tracker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kodek16/rs-view-tracker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kodek16/rs-view-tracker [INFO] finished frobbing kodek16/rs-view-tracker [INFO] frobbed toml for kodek16/rs-view-tracker written to work/ex/clippy-test-run/sources/stable/gh/kodek16/rs-view-tracker/Cargo.toml [INFO] started frobbing kodek16/rs-view-tracker [INFO] finished frobbing kodek16/rs-view-tracker [INFO] frobbed toml for kodek16/rs-view-tracker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kodek16/rs-view-tracker/Cargo.toml [INFO] crate kodek16/rs-view-tracker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kodek16/rs-view-tracker against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kodek16/rs-view-tracker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6e443f25e6d0806ef7fae50cd64f6d514f42ae6aa28aa5ed5d84b9ba115941f1 [INFO] running `"docker" "start" "-a" "6e443f25e6d0806ef7fae50cd64f6d514f42ae6aa28aa5ed5d84b9ba115941f1"` [INFO] [stderr] Compiling memchr v2.0.1 [INFO] [stderr] Compiling regex-syntax v0.5.3 [INFO] [stderr] Compiling proc-macro2 v0.3.5 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Compiling thread_local v0.3.5 [INFO] [stderr] Compiling aho-corasick v0.6.4 [INFO] [stderr] Compiling quote v0.5.1 [INFO] [stderr] Compiling syn v0.13.1 [INFO] [stderr] Compiling regex v0.2.10 [INFO] [stderr] Compiling serde_derive_internals v0.23.0 [INFO] [stderr] Compiling serde_derive v1.0.37 [INFO] [stderr] Compiling parse-zoneinfo v0.1.1 [INFO] [stderr] Compiling chrono-tz v0.4.1 [INFO] [stderr] Checking rs-view-tracker v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | timezone: timezone [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `timezone` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | timezone: timezone [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `timezone` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:6:21 [INFO] [stderr] | [INFO] [stderr] 6 | const CONFIG_PATH: &'static str = "/etc/rs-view-tracker.conf"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:6:21 [INFO] [stderr] | [INFO] [stderr] 6 | const CONFIG_PATH: &'static str = "/etc/rs-view-tracker.conf"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:84:10 [INFO] [stderr] | [INFO] [stderr] 84 | .expect(&format!("Couldn't open log file '{}'.", file_path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't open log file '{}'.", file_path.display()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | Err(_) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:84:10 [INFO] [stderr] | [INFO] [stderr] 84 | .expect(&format!("Couldn't open log file '{}'.", file_path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't open log file '{}'.", file_path.display()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.14s [INFO] running `"docker" "inspect" "6e443f25e6d0806ef7fae50cd64f6d514f42ae6aa28aa5ed5d84b9ba115941f1"` [INFO] running `"docker" "rm" "-f" "6e443f25e6d0806ef7fae50cd64f6d514f42ae6aa28aa5ed5d84b9ba115941f1"` [INFO] [stdout] 6e443f25e6d0806ef7fae50cd64f6d514f42ae6aa28aa5ed5d84b9ba115941f1