[INFO] updating cached repository koba04/react-fiber-basic-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/koba04/react-fiber-basic-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/koba04/react-fiber-basic-rs" "work/ex/clippy-test-run/sources/stable/gh/koba04/react-fiber-basic-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/koba04/react-fiber-basic-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/koba04/react-fiber-basic-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/koba04/react-fiber-basic-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/koba04/react-fiber-basic-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 849e14b9b3fcc6c99f6c9da7395f410fd36e764f [INFO] sha for GitHub repo koba04/react-fiber-basic-rs: 849e14b9b3fcc6c99f6c9da7395f410fd36e764f [INFO] validating manifest of koba04/react-fiber-basic-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of koba04/react-fiber-basic-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing koba04/react-fiber-basic-rs [INFO] finished frobbing koba04/react-fiber-basic-rs [INFO] frobbed toml for koba04/react-fiber-basic-rs written to work/ex/clippy-test-run/sources/stable/gh/koba04/react-fiber-basic-rs/Cargo.toml [INFO] started frobbing koba04/react-fiber-basic-rs [INFO] finished frobbing koba04/react-fiber-basic-rs [INFO] frobbed toml for koba04/react-fiber-basic-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/koba04/react-fiber-basic-rs/Cargo.toml [INFO] crate koba04/react-fiber-basic-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting koba04/react-fiber-basic-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/koba04/react-fiber-basic-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c5646fa2f19502bd9c183441b257464e7170d1de05e83b693a073c4a68e11d3e [INFO] running `"docker" "start" "-a" "c5646fa2f19502bd9c183441b257464e7170d1de05e83b693a073c4a68e11d3e"` [INFO] [stderr] Checking react-fiber-basic-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | let mut markup = String::from(format!("<{}>", fiber.type_)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("<{}>", fiber.type_)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / fn render<'a>(fiber: &'a Fiber) -> String { [INFO] [stderr] 28 | | create_markup(fiber) [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | let mut markup = String::from(format!("<{}>", fiber.type_)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("<{}>", fiber.type_)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / fn render<'a>(fiber: &'a Fiber) -> String { [INFO] [stderr] 28 | | create_markup(fiber) [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.66s [INFO] running `"docker" "inspect" "c5646fa2f19502bd9c183441b257464e7170d1de05e83b693a073c4a68e11d3e"` [INFO] running `"docker" "rm" "-f" "c5646fa2f19502bd9c183441b257464e7170d1de05e83b693a073c4a68e11d3e"` [INFO] [stdout] c5646fa2f19502bd9c183441b257464e7170d1de05e83b693a073c4a68e11d3e