[INFO] updating cached repository koba-e964/rust-number-theory [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/koba-e964/rust-number-theory [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/koba-e964/rust-number-theory" "work/ex/clippy-test-run/sources/stable/gh/koba-e964/rust-number-theory"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/koba-e964/rust-number-theory'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/koba-e964/rust-number-theory" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/koba-e964/rust-number-theory"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/koba-e964/rust-number-theory'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6585894b5b711fd471dcb52a402a289eca26a1df [INFO] sha for GitHub repo koba-e964/rust-number-theory: 6585894b5b711fd471dcb52a402a289eca26a1df [INFO] validating manifest of koba-e964/rust-number-theory on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of koba-e964/rust-number-theory on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing koba-e964/rust-number-theory [INFO] finished frobbing koba-e964/rust-number-theory [INFO] frobbed toml for koba-e964/rust-number-theory written to work/ex/clippy-test-run/sources/stable/gh/koba-e964/rust-number-theory/Cargo.toml [INFO] started frobbing koba-e964/rust-number-theory [INFO] finished frobbing koba-e964/rust-number-theory [INFO] frobbed toml for koba-e964/rust-number-theory written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/koba-e964/rust-number-theory/Cargo.toml [INFO] crate koba-e964/rust-number-theory has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting koba-e964/rust-number-theory against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/koba-e964/rust-number-theory:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb1a56ec1332fcda06d527fae2847aa648cd4534e24f1e84c9a386e98d3e5323 [INFO] running `"docker" "start" "-a" "eb1a56ec1332fcda06d527fae2847aa648cd4534e24f1e84c9a386e98d3e5323"` [INFO] [stderr] Compiling num-bigint v0.2.1 [INFO] [stderr] Compiling num-complex v0.2.1 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking rust-number-theory v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/polynomial.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | dat: dat [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dat` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/resultant.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut s = 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/resultant.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | let (_, h) = pseudo_div_rem_bigint(&f, &g); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/polynomial.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | dat: dat [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dat` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/resultant.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut s = 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/resultant.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | let (_, h) = pseudo_div_rem_bigint(&f, &g); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `BigInt` [INFO] [stderr] --> src/determinant.rs:3:11 [INFO] [stderr] | [INFO] [stderr] 3 | use num::{BigInt, BigRational, One, Zero}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | assert_eq!(res, 335159672.into()); [INFO] [stderr] | ^^^^^^^^^ help: consider: `335_159_672` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `num::BigInt` [INFO] [stderr] --> src/algebraic.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | use num::BigInt; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/factorize.rs:39:34 [INFO] [stderr] | [INFO] [stderr] 39 | let mut res = factorize(&36355439941184i64.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `36_355_439_941_184i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/factorize.rs:43:31 [INFO] [stderr] | [INFO] [stderr] 43 | (149.into(), 1), (41894959.into(), 1)]); [INFO] [stderr] | ^^^^^^^^ help: consider: `41_894_959` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/resultant.rs:87:41 [INFO] [stderr] | [INFO] [stderr] 87 | assert_eq!(resultant(&p1, &p2), 335159672.into()); [INFO] [stderr] | ^^^^^^^^^ help: consider: `335_159_672` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `BigInt` [INFO] [stderr] --> src/determinant.rs:3:11 [INFO] [stderr] | [INFO] [stderr] 3 | use num::{BigInt, BigRational, One, Zero}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/determinant.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | /// det((2, -1; 5, -4)) = -3 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/determinant.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | /// det((3, 2, 1; -1, 2, 2; -2, -3, 2)) = 33 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | assert_eq!(res, 335159672.into()); [INFO] [stderr] | ^^^^^^^^^ help: consider: `335_159_672` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `cur` [INFO] [stderr] --> src/algebraic.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | for i in 0 .. b_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 92 | for (i, ) in cur.iter_mut().enumerate().take(b_deg + 1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/algebraic.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | for i in 0 .. b_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try replacing the loop by: `cur[..b_deg + 1].clone_from_slice(&b.dat[..b_deg + 1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/algebraic.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | for i in 0 .. b_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=b_deg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/algebraic.rs:96:14 [INFO] [stderr] | [INFO] [stderr] 96 | for i in 0 .. a_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=a_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `cur` [INFO] [stderr] --> src/algebraic.rs:107:22 [INFO] [stderr] | [INFO] [stderr] 107 | for j in 0 .. n { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 107 | for (j, ) in cur.iter_mut().enumerate().take(n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:16:12 [INFO] [stderr] | [INFO] [stderr] 16 | if self.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | self.dat.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `tmp` [INFO] [stderr] --> src/polynomial.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | for i in 0 .. deg { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 48 | for (i, ) in tmp.iter_mut().enumerate().take(deg) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | if self.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:69:12 [INFO] [stderr] | [INFO] [stderr] 69 | if other.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `tmp` [INFO] [stderr] --> src/polynomial.rs:76:18 [INFO] [stderr] | [INFO] [stderr] 76 | for i in 0 .. ret_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 76 | for (i, ) in tmp.iter_mut().enumerate().take(ret_deg + 1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:76:18 [INFO] [stderr] | [INFO] [stderr] 76 | for i in 0 .. ret_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=ret_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:90:12 [INFO] [stderr] | [INFO] [stderr] 90 | if self.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:93:12 [INFO] [stderr] | [INFO] [stderr] 93 | if other.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dat`. [INFO] [stderr] --> src/polynomial.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | for i in 0 .. dat.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 104 | for in &mut dat { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:128:12 [INFO] [stderr] | [INFO] [stderr] 128 | if self.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | if other.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/polynomial.rs:137:47 [INFO] [stderr] | [INFO] [stderr] 137 | let mut tmp = vec![R::zero(); ret_deg + 1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `tmp` [INFO] [stderr] --> src/polynomial.rs:138:18 [INFO] [stderr] | [INFO] [stderr] 138 | for i in 0 .. ret_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 138 | for (i, ) in tmp.iter_mut().enumerate().take(ret_deg + 1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:138:18 [INFO] [stderr] | [INFO] [stderr] 138 | for i in 0 .. ret_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=ret_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/polynomial.rs:138:31 [INFO] [stderr] | [INFO] [stderr] 138 | for i in 0 .. ret_deg + 1 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:152:12 [INFO] [stderr] | [INFO] [stderr] 152 | if self.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:155:12 [INFO] [stderr] | [INFO] [stderr] 155 | if other.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/polynomial.rs:166:37 [INFO] [stderr] | [INFO] [stderr] 166 | if self.is_zero_primitive() || other.is_zero_primitive() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:172:18 [INFO] [stderr] | [INFO] [stderr] 172 | for i in 0 .. a_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=a_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/polynomial.rs:172:29 [INFO] [stderr] | [INFO] [stderr] 172 | for i in 0 .. a_deg + 1 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:173:22 [INFO] [stderr] | [INFO] [stderr] 173 | for j in 0 .. b_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=b_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/polynomial.rs:173:33 [INFO] [stderr] | [INFO] [stderr] 173 | for j in 0 .. b_deg + 1 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/polynomial.rs:174:26 [INFO] [stderr] | [INFO] [stderr] 174 | result[i + j] += &self.dat[i] * &other.dat[j]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:209:18 [INFO] [stderr] | [INFO] [stderr] 209 | for i in (0 .. d + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(0..=d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `tmp`. [INFO] [stderr] --> src/polynomial.rs:249:14 [INFO] [stderr] | [INFO] [stderr] 249 | for i in 0 .. a_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 249 | for in tmp.iter_mut().take(a_deg + 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:249:14 [INFO] [stderr] | [INFO] [stderr] 249 | for i in 0 .. a_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=a_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:254:14 [INFO] [stderr] | [INFO] [stderr] 254 | for i in (0 .. diff + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `(0..=diff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:256:18 [INFO] [stderr] | [INFO] [stderr] 256 | for j in 0 .. b_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=b_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:277:14 [INFO] [stderr] | [INFO] [stderr] 277 | for i in (0 .. a_deg - b_deg + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=a_deg - b_deg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:279:18 [INFO] [stderr] | [INFO] [stderr] 279 | for j in 0 .. b_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=b_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `a` [INFO] [stderr] --> src/determinant.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | for j in i .. n { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 14 | for (j, ) in a.iter().enumerate().take(n).skip(i) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-number-theory`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the loop variable `i` is used to index `cur` [INFO] [stderr] --> src/algebraic.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | for i in 0 .. b_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 92 | for (i, ) in cur.iter_mut().enumerate().take(b_deg + 1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/algebraic.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | for i in 0 .. b_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try replacing the loop by: `cur[..b_deg + 1].clone_from_slice(&b.dat[..b_deg + 1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/algebraic.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | for i in 0 .. b_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=b_deg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/algebraic.rs:96:14 [INFO] [stderr] | [INFO] [stderr] 96 | for i in 0 .. a_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=a_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `cur` [INFO] [stderr] --> src/algebraic.rs:107:22 [INFO] [stderr] | [INFO] [stderr] 107 | for j in 0 .. n { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 107 | for (j, ) in cur.iter_mut().enumerate().take(n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:16:12 [INFO] [stderr] | [INFO] [stderr] 16 | if self.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | self.dat.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `tmp` [INFO] [stderr] --> src/polynomial.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | for i in 0 .. deg { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 48 | for (i, ) in tmp.iter_mut().enumerate().take(deg) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | if self.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:69:12 [INFO] [stderr] | [INFO] [stderr] 69 | if other.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `tmp` [INFO] [stderr] --> src/polynomial.rs:76:18 [INFO] [stderr] | [INFO] [stderr] 76 | for i in 0 .. ret_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 76 | for (i, ) in tmp.iter_mut().enumerate().take(ret_deg + 1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:76:18 [INFO] [stderr] | [INFO] [stderr] 76 | for i in 0 .. ret_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=ret_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:90:12 [INFO] [stderr] | [INFO] [stderr] 90 | if self.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:93:12 [INFO] [stderr] | [INFO] [stderr] 93 | if other.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dat`. [INFO] [stderr] --> src/polynomial.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | for i in 0 .. dat.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 104 | for in &mut dat { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:128:12 [INFO] [stderr] | [INFO] [stderr] 128 | if self.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | if other.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/polynomial.rs:137:47 [INFO] [stderr] | [INFO] [stderr] 137 | let mut tmp = vec![R::zero(); ret_deg + 1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `tmp` [INFO] [stderr] --> src/polynomial.rs:138:18 [INFO] [stderr] | [INFO] [stderr] 138 | for i in 0 .. ret_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 138 | for (i, ) in tmp.iter_mut().enumerate().take(ret_deg + 1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:138:18 [INFO] [stderr] | [INFO] [stderr] 138 | for i in 0 .. ret_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=ret_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/polynomial.rs:138:31 [INFO] [stderr] | [INFO] [stderr] 138 | for i in 0 .. ret_deg + 1 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:152:12 [INFO] [stderr] | [INFO] [stderr] 152 | if self.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/polynomial.rs:155:12 [INFO] [stderr] | [INFO] [stderr] 155 | if other.dat.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.dat.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/polynomial.rs:166:37 [INFO] [stderr] | [INFO] [stderr] 166 | if self.is_zero_primitive() || other.is_zero_primitive() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:172:18 [INFO] [stderr] | [INFO] [stderr] 172 | for i in 0 .. a_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=a_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/polynomial.rs:172:29 [INFO] [stderr] | [INFO] [stderr] 172 | for i in 0 .. a_deg + 1 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:173:22 [INFO] [stderr] | [INFO] [stderr] 173 | for j in 0 .. b_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=b_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/polynomial.rs:173:33 [INFO] [stderr] | [INFO] [stderr] 173 | for j in 0 .. b_deg + 1 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/polynomial.rs:174:26 [INFO] [stderr] | [INFO] [stderr] 174 | result[i + j] += &self.dat[i] * &other.dat[j]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:209:18 [INFO] [stderr] | [INFO] [stderr] 209 | for i in (0 .. d + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(0..=d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `tmp`. [INFO] [stderr] --> src/polynomial.rs:249:14 [INFO] [stderr] | [INFO] [stderr] 249 | for i in 0 .. a_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 249 | for in tmp.iter_mut().take(a_deg + 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:249:14 [INFO] [stderr] | [INFO] [stderr] 249 | for i in 0 .. a_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=a_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:254:14 [INFO] [stderr] | [INFO] [stderr] 254 | for i in (0 .. diff + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `(0..=diff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:256:18 [INFO] [stderr] | [INFO] [stderr] 256 | for j in 0 .. b_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=b_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:277:14 [INFO] [stderr] | [INFO] [stderr] 277 | for i in (0 .. a_deg - b_deg + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=a_deg - b_deg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/polynomial.rs:279:18 [INFO] [stderr] | [INFO] [stderr] 279 | for j in 0 .. b_deg + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=b_deg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `a` [INFO] [stderr] --> src/determinant.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | for j in i .. n { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 14 | for (j, ) in a.iter().enumerate().take(n).skip(i) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-number-theory`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "eb1a56ec1332fcda06d527fae2847aa648cd4534e24f1e84c9a386e98d3e5323"` [INFO] running `"docker" "rm" "-f" "eb1a56ec1332fcda06d527fae2847aa648cd4534e24f1e84c9a386e98d3e5323"` [INFO] [stdout] eb1a56ec1332fcda06d527fae2847aa648cd4534e24f1e84c9a386e98d3e5323