[INFO] updating cached repository koba-e964/min-caml-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/koba-e964/min-caml-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/koba-e964/min-caml-rust" "work/ex/clippy-test-run/sources/stable/gh/koba-e964/min-caml-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/koba-e964/min-caml-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/koba-e964/min-caml-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/koba-e964/min-caml-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/koba-e964/min-caml-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7a95be0533af3ab7ed8ae7c63c008ff596a73c58 [INFO] sha for GitHub repo koba-e964/min-caml-rust: 7a95be0533af3ab7ed8ae7c63c008ff596a73c58 [INFO] validating manifest of koba-e964/min-caml-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of koba-e964/min-caml-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing koba-e964/min-caml-rust [INFO] finished frobbing koba-e964/min-caml-rust [INFO] frobbed toml for koba-e964/min-caml-rust written to work/ex/clippy-test-run/sources/stable/gh/koba-e964/min-caml-rust/Cargo.toml [INFO] started frobbing koba-e964/min-caml-rust [INFO] finished frobbing koba-e964/min-caml-rust [INFO] frobbed toml for koba-e964/min-caml-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/koba-e964/min-caml-rust/Cargo.toml [INFO] crate koba-e964/min-caml-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting koba-e964/min-caml-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/koba-e964/min-caml-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd4c91402fc275cafab8060b0822e757be1ba9d1eef1f896ba49f3a0e8a8e624 [INFO] running `"docker" "start" "-a" "bd4c91402fc275cafab8060b0822e757be1ba9d1eef1f896ba49f3a0e8a8e624"` [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking ordered-float v0.5.2 [INFO] [stderr] Checking min-caml-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/closure.rs:116:40 [INFO] [stderr] | [INFO] [stderr] 116 | let Cls { entry: id::L(l), actual_fv: fv } = cls; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/x86/virtual_asm.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | let z = id_gen.gen_id("l"); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/x86/simm.rs:45:52 [INFO] [stderr] | [INFO] [stderr] 45 | Exp::StDF(ref x, ref y, IdOrImm::V(ref z), i) if env.contains_key(z) => [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/closure.rs:116:40 [INFO] [stderr] | [INFO] [stderr] 116 | let Cls { entry: id::L(l), actual_fv: fv } = cls; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/x86/virtual_asm.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | let z = id_gen.gen_id("l"); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/x86/simm.rs:45:52 [INFO] [stderr] | [INFO] [stderr] 45 | Exp::StDF(ref x, ref y, IdOrImm::V(ref z), i) if env.contains_key(z) => [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/parser.rs:726:44 [INFO] [stderr] | [INFO] [stderr] 726 | LetRec(Fundef { name: (id, _), args: _, body: e1 }, e2) => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Fundef { name: (id, _), body: e1, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:340:1 [INFO] [stderr] | [INFO] [stderr] 340 | / named!(ident, ws!(do_parse!( [INFO] [stderr] 341 | | s: verify!(take_till!(is_not_ident_u8), is_ident) >> [INFO] [stderr] 342 | | (String::from_utf8((&s as &[u8]).to_vec()).unwrap()) [INFO] [stderr] 343 | | ))); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/typing.rs:321:55 [INFO] [stderr] | [INFO] [stderr] 321 | pub fn f(e: &Syntax, id_gen: &mut IdGen, extenv: &mut HashMap) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 321 | pub fn f(e: &Syntax, id_gen: &mut IdGen, extenv: &mut HashMap) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 324 | let typed = g(&HashMap::default(), e, extenv, &mut tyenv, id_gen) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/k_normal.rs:110:26 [INFO] [stderr] | [INFO] [stderr] 110 | for _ in 0 .. level + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=level` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/k_normal.rs:346:25 [INFO] [stderr] | [INFO] [stderr] 346 | / fn bind(mut xs: Vec, p: usize, id_gen: &mut IdGen, extenv: &HashMap, env: &HashMap, e2s: &[Syntax], t: Type, f: String) -> (KNormal, Type) { [INFO] [stderr] 347 | | let n = e2s.len(); [INFO] [stderr] 348 | | if p == n { [INFO] [stderr] 349 | | (KNormal::App( [INFO] [stderr] ... | [INFO] [stderr] 360 | | } [INFO] [stderr] 361 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/k_normal.rs:376:25 [INFO] [stderr] | [INFO] [stderr] 376 | / fn bind(mut xs: Vec, p: usize, id_gen: &mut IdGen, extenv: &HashMap, env: &HashMap, e2s: &[Syntax], t: Type, f: String) -> (KNormal, Type) { [INFO] [stderr] 377 | | let n = e2s.len(); [INFO] [stderr] 378 | | if p == n { [INFO] [stderr] 379 | | (KNormal::ExtFunApp( [INFO] [stderr] ... | [INFO] [stderr] 390 | | } [INFO] [stderr] 391 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/k_normal.rs:479:50 [INFO] [stderr] | [INFO] [stderr] 479 | pub fn f(e: Syntax, id_gen: &mut IdGen, extenv: &HashMap) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 479 | pub fn f(e: Syntax, id_gen: &mut IdGen, extenv: &HashMap) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 481 | g(&HashMap::default(), e, id_gen, extenv) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/alpha.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn g(env: &HashMap, e: KNormal, id_gen: &mut IdGen) -> KNormal { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 8 | pub fn g(env: &HashMap, e: KNormal, id_gen: &mut IdGen) -> KNormal { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parser.rs:340:1 [INFO] [stderr] | [INFO] [stderr] 340 | / named!(ident, ws!(do_parse!( [INFO] [stderr] 341 | | s: verify!(take_till!(is_not_ident_u8), is_ident) >> [INFO] [stderr] 342 | | (String::from_utf8((&s as &[u8]).to_vec()).unwrap()) [INFO] [stderr] 343 | | ))); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/typing.rs:321:55 [INFO] [stderr] | [INFO] [stderr] 321 | pub fn f(e: &Syntax, id_gen: &mut IdGen, extenv: &mut HashMap) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 321 | pub fn f(e: &Syntax, id_gen: &mut IdGen, extenv: &mut HashMap) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 324 | let typed = g(&HashMap::default(), e, extenv, &mut tyenv, id_gen) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/k_normal.rs:110:26 [INFO] [stderr] | [INFO] [stderr] 110 | for _ in 0 .. level + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=level` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/k_normal.rs:346:25 [INFO] [stderr] | [INFO] [stderr] 346 | / fn bind(mut xs: Vec, p: usize, id_gen: &mut IdGen, extenv: &HashMap, env: &HashMap, e2s: &[Syntax], t: Type, f: String) -> (KNormal, Type) { [INFO] [stderr] 347 | | let n = e2s.len(); [INFO] [stderr] 348 | | if p == n { [INFO] [stderr] 349 | | (KNormal::App( [INFO] [stderr] ... | [INFO] [stderr] 360 | | } [INFO] [stderr] 361 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/k_normal.rs:376:25 [INFO] [stderr] | [INFO] [stderr] 376 | / fn bind(mut xs: Vec, p: usize, id_gen: &mut IdGen, extenv: &HashMap, env: &HashMap, e2s: &[Syntax], t: Type, f: String) -> (KNormal, Type) { [INFO] [stderr] 377 | | let n = e2s.len(); [INFO] [stderr] 378 | | if p == n { [INFO] [stderr] 379 | | (KNormal::ExtFunApp( [INFO] [stderr] ... | [INFO] [stderr] 390 | | } [INFO] [stderr] 391 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/k_normal.rs:479:50 [INFO] [stderr] | [INFO] [stderr] 479 | pub fn f(e: Syntax, id_gen: &mut IdGen, extenv: &HashMap) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 479 | pub fn f(e: Syntax, id_gen: &mut IdGen, extenv: &HashMap) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 481 | g(&HashMap::default(), e, id_gen, extenv) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/alpha.rs:8:16 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn g(env: &HashMap, e: KNormal, id_gen: &mut IdGen) -> KNormal { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 8 | pub fn g(env: &HashMap, e: KNormal, id_gen: &mut IdGen) -> KNormal { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized] target(s) in 11.40s [INFO] running `"docker" "inspect" "bd4c91402fc275cafab8060b0822e757be1ba9d1eef1f896ba49f3a0e8a8e624"` [INFO] running `"docker" "rm" "-f" "bd4c91402fc275cafab8060b0822e757be1ba9d1eef1f896ba49f3a0e8a8e624"` [INFO] [stdout] bd4c91402fc275cafab8060b0822e757be1ba9d1eef1f896ba49f3a0e8a8e624