[INFO] updating cached repository knknkn1162/rust_server_test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/knknkn1162/rust_server_test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/knknkn1162/rust_server_test" "work/ex/clippy-test-run/sources/stable/gh/knknkn1162/rust_server_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/knknkn1162/rust_server_test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/knknkn1162/rust_server_test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knknkn1162/rust_server_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knknkn1162/rust_server_test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 08eb0ad0f81838ed253bb2870c88af01c51a104d [INFO] sha for GitHub repo knknkn1162/rust_server_test: 08eb0ad0f81838ed253bb2870c88af01c51a104d [INFO] validating manifest of knknkn1162/rust_server_test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of knknkn1162/rust_server_test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing knknkn1162/rust_server_test [INFO] finished frobbing knknkn1162/rust_server_test [INFO] frobbed toml for knknkn1162/rust_server_test written to work/ex/clippy-test-run/sources/stable/gh/knknkn1162/rust_server_test/Cargo.toml [INFO] started frobbing knknkn1162/rust_server_test [INFO] finished frobbing knknkn1162/rust_server_test [INFO] frobbed toml for knknkn1162/rust_server_test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knknkn1162/rust_server_test/Cargo.toml [INFO] crate knknkn1162/rust_server_test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting knknkn1162/rust_server_test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/knknkn1162/rust_server_test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 70d324a30fa76e88e0a0e336f0cfe682c5fa7bed637b0b43909c9a76f743bac5 [INFO] running `"docker" "start" "-a" "70d324a30fa76e88e0a0e336f0cfe682c5fa7bed637b0b43909c9a76f743bac5"` [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking simple_line v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Future` [INFO] [stderr] --> src/main.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | use futures::{future, Future}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Future` [INFO] [stderr] --> src/main.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | use futures::{future, Future}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | let mut server = TcpServer::new(Http, addr); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:55:63 [INFO] [stderr] | [INFO] [stderr] 55 | debug!(" {} call decode({:?}) => complete", if line!=&""[..] {"<"} else {" "}, line); [INFO] [stderr] | ^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `""[..]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | return if &line[0..4] == &b"GET "[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 56 | return if line[0..4] == b"GET "[..] { [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | let mut server = TcpServer::new(Http, addr); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:55:63 [INFO] [stderr] | [INFO] [stderr] 55 | debug!(" {} call decode({:?}) => complete", if line!=&""[..] {"<"} else {" "}, line); [INFO] [stderr] | ^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `""[..]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | return if &line[0..4] == &b"GET "[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 56 | return if line[0..4] == b"GET "[..] { [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.08s [INFO] running `"docker" "inspect" "70d324a30fa76e88e0a0e336f0cfe682c5fa7bed637b0b43909c9a76f743bac5"` [INFO] running `"docker" "rm" "-f" "70d324a30fa76e88e0a0e336f0cfe682c5fa7bed637b0b43909c9a76f743bac5"` [INFO] [stdout] 70d324a30fa76e88e0a0e336f0cfe682c5fa7bed637b0b43909c9a76f743bac5