[INFO] updating cached repository knight42/Yuki-cli [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/knight42/Yuki-cli [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/knight42/Yuki-cli" "work/ex/clippy-test-run/sources/stable/gh/knight42/Yuki-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/knight42/Yuki-cli'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/knight42/Yuki-cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knight42/Yuki-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knight42/Yuki-cli'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8e5a0b9f9b1db5d5c81e3d0d2772de7787d01c82 [INFO] sha for GitHub repo knight42/Yuki-cli: 8e5a0b9f9b1db5d5c81e3d0d2772de7787d01c82 [INFO] validating manifest of knight42/Yuki-cli on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of knight42/Yuki-cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing knight42/Yuki-cli [INFO] finished frobbing knight42/Yuki-cli [INFO] frobbed toml for knight42/Yuki-cli written to work/ex/clippy-test-run/sources/stable/gh/knight42/Yuki-cli/Cargo.toml [INFO] started frobbing knight42/Yuki-cli [INFO] finished frobbing knight42/Yuki-cli [INFO] frobbed toml for knight42/Yuki-cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/knight42/Yuki-cli/Cargo.toml [INFO] crate knight42/Yuki-cli has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting knight42/Yuki-cli against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/knight42/Yuki-cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34b7b97c92962dd73f7b8cf75d9932d54c7b08f56d8a123b986d10a528e07aa4 [INFO] running `"docker" "start" "-a" "34b7b97c92962dd73f7b8cf75d9932d54c7b08f56d8a123b986d10a528e07aa4"` [INFO] [stderr] Compiling serde v1.0.58 [INFO] [stderr] Checking rpassword v2.0.0 [INFO] [stderr] Checking bytes v0.4.7 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Compiling syn v0.13.11 [INFO] [stderr] Checking tokio-threadpool v0.1.3 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Compiling serde_derive v1.0.58 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking yuki_cli v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | return Local.timestamp(0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Local.timestamp(0, 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands/mod.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | const FORMAT: &'static str = "%Y-%m-%d %H:%M:%S"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | let homedir = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/commands/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | return Local.timestamp(0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Local.timestamp(0, 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands/mod.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | const FORMAT: &'static str = "%Y-%m-%d %H:%M:%S"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | let homedir = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/commands/mod.rs:24:36 [INFO] [stderr] | [INFO] [stderr] 24 | pub(crate) fn pretty_size(size: &i64, serializer: S) -> Result [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/commands/mod.rs:24:36 [INFO] [stderr] | [INFO] [stderr] 24 | pub(crate) fn pretty_size(size: &i64, serializer: S) -> Result [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/commands/repo/update.rs:23:39 [INFO] [stderr] | [INFO] [stderr] 23 | if v.contains("=") { [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/commands/repo/update.rs:40:42 [INFO] [stderr] | [INFO] [stderr] 40 | let l: Vec<_> = kv.splitn(2, "=").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/token.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .ok_or(err_msg("no such host")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("no such host"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/token.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / ts.into_iter() [INFO] [stderr] 17 | | .filter(|x| x.host == host) [INFO] [stderr] 18 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|x| x.host == host).next()` with `find(|x| x.host == host)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/commands/repo/update.rs:23:39 [INFO] [stderr] | [INFO] [stderr] 23 | if v.contains("=") { [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/commands/repo/update.rs:40:42 [INFO] [stderr] | [INFO] [stderr] 40 | let l: Vec<_> = kv.splitn(2, "=").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/token.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .ok_or(err_msg("no such host")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("no such host"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/token.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / ts.into_iter() [INFO] [stderr] 17 | | .filter(|x| x.host == host) [INFO] [stderr] 18 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|x| x.host == host).next()` with `find(|x| x.host == host)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.11s [INFO] running `"docker" "inspect" "34b7b97c92962dd73f7b8cf75d9932d54c7b08f56d8a123b986d10a528e07aa4"` [INFO] running `"docker" "rm" "-f" "34b7b97c92962dd73f7b8cf75d9932d54c7b08f56d8a123b986d10a528e07aa4"` [INFO] [stdout] 34b7b97c92962dd73f7b8cf75d9932d54c7b08f56d8a123b986d10a528e07aa4