[INFO] updating cached repository kngwyu/rogue-ai-2nd [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kngwyu/rogue-ai-2nd [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kngwyu/rogue-ai-2nd" "work/ex/clippy-test-run/sources/stable/gh/kngwyu/rogue-ai-2nd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kngwyu/rogue-ai-2nd'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kngwyu/rogue-ai-2nd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kngwyu/rogue-ai-2nd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kngwyu/rogue-ai-2nd'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5a9d6897b14489f68f7c6b35798ce5c1b04c1f0a [INFO] sha for GitHub repo kngwyu/rogue-ai-2nd: 5a9d6897b14489f68f7c6b35798ce5c1b04c1f0a [INFO] validating manifest of kngwyu/rogue-ai-2nd on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kngwyu/rogue-ai-2nd on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kngwyu/rogue-ai-2nd [INFO] finished frobbing kngwyu/rogue-ai-2nd [INFO] frobbed toml for kngwyu/rogue-ai-2nd written to work/ex/clippy-test-run/sources/stable/gh/kngwyu/rogue-ai-2nd/Cargo.toml [INFO] started frobbing kngwyu/rogue-ai-2nd [INFO] finished frobbing kngwyu/rogue-ai-2nd [INFO] frobbed toml for kngwyu/rogue-ai-2nd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kngwyu/rogue-ai-2nd/Cargo.toml [INFO] crate kngwyu/rogue-ai-2nd has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kngwyu/rogue-ai-2nd against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kngwyu/rogue-ai-2nd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 726ebc158c22ce10a922ad788a339f8d600208c06d8d8eca71fb72d4966e193b [INFO] running `"docker" "start" "-a" "726ebc158c22ce10a922ad788a339f8d600208c06d8d8eca71fb72d4966e193b"` [INFO] [stderr] Checking slog v2.1.1 [INFO] [stderr] Checking take_mut v0.2.0 [INFO] [stderr] Checking utf8parse v0.1.0 [INFO] [stderr] Checking ascii v0.8.6 [INFO] [stderr] Checking num_alias v0.1.7 [INFO] [stderr] Checking assert_approx_eq v1.0.0 [INFO] [stderr] Checking isatty v0.1.6 [INFO] [stderr] Checking atty v0.2.4 [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking vte v0.3.2 [INFO] [stderr] Checking clap v2.29.0 [INFO] [stderr] Checking slog-scope v4.0.1 [INFO] [stderr] Checking slog-term v2.3.0 [INFO] [stderr] Checking slog-async v2.2.0 [INFO] [stderr] Checking slog-stdlog v3.0.2 [INFO] [stderr] Checking sloggers v0.2.6 [INFO] [stderr] Checking curses-game-wrapper v0.0.4 [INFO] [stderr] Checking rogue-ai-2nd v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:410:13 [INFO] [stderr] | [INFO] [stderr] 410 | cd: cd, [INFO] [stderr] | ^^^^^^ help: replace it with: `cd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:737:13 [INFO] [stderr] | [INFO] [stderr] 737 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:739:13 [INFO] [stderr] | [INFO] [stderr] 739 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:740:13 [INFO] [stderr] | [INFO] [stderr] 740 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dangeon.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dangeon.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dangeon.rs:918:25 [INFO] [stderr] | [INFO] [stderr] 918 | Some(Rect { l: l, r: r }) [INFO] [stderr] | ^^^^ help: replace it with: `l` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dangeon.rs:918:31 [INFO] [stderr] | [INFO] [stderr] 918 | Some(Rect { l: l, r: r }) [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:410:13 [INFO] [stderr] | [INFO] [stderr] 410 | cd: cd, [INFO] [stderr] | ^^^^^^ help: replace it with: `cd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:737:13 [INFO] [stderr] | [INFO] [stderr] 737 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:739:13 [INFO] [stderr] | [INFO] [stderr] 739 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data.rs:740:13 [INFO] [stderr] | [INFO] [stderr] 740 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dangeon.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dangeon.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | rect: rect, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dangeon.rs:918:25 [INFO] [stderr] | [INFO] [stderr] 918 | Some(Rect { l: l, r: r }) [INFO] [stderr] | ^^^^ help: replace it with: `l` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dangeon.rs:918:31 [INFO] [stderr] | [INFO] [stderr] 918 | Some(Rect { l: l, r: r }) [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:435:29 [INFO] [stderr] | [INFO] [stderr] 435 | const MEAN = 0b0000000001; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:436:29 [INFO] [stderr] | [INFO] [stderr] 436 | const FLYING = 0b0000000010; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:437:29 [INFO] [stderr] | [INFO] [stderr] 437 | const REGENERATE = 0b0000000100; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:438:29 [INFO] [stderr] | [INFO] [stderr] 438 | const GREEDY = 0b0000001000; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:439:29 [INFO] [stderr] | [INFO] [stderr] 439 | const INVISIBLE = 0b0000010000; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:440:29 [INFO] [stderr] | [INFO] [stderr] 440 | const RUSTS_ARMOR = 0b0000100000; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:441:29 [INFO] [stderr] | [INFO] [stderr] 441 | const STEAL_GOLD = 0b0001000000; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:442:29 [INFO] [stderr] | [INFO] [stderr] 442 | const REDUCE_STR = 0b0010000000; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:443:29 [INFO] [stderr] | [INFO] [stderr] 443 | const FREEZES = 0b0100000000; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b01_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:444:29 [INFO] [stderr] | [INFO] [stderr] 444 | const RANDOM = 0b1000000000; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b10_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/agent.rs:708:9 [INFO] [stderr] | [INFO] [stderr] 708 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/agent.rs:646:19 [INFO] [stderr] | [INFO] [stderr] 646 | let ret = match max_act { [INFO] [stderr] | ___________________^ [INFO] [stderr] 647 | | 0 => Some( [INFO] [stderr] 648 | | self.play_info [INFO] [stderr] 649 | | .update(Tactics::Fight, fight_act, None, fight_val), [INFO] [stderr] ... | [INFO] [stderr] 706 | | _ => None, [INFO] [stderr] 707 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/agent.rs:760:24 [INFO] [stderr] | [INFO] [stderr] 760 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 761 | | if self.is_dest() { [INFO] [stderr] 762 | | Some(self.play_info.update_act_init(Action::Search)) [INFO] [stderr] 763 | | } else { [INFO] [stderr] 764 | | self.move_to_dest() [INFO] [stderr] 765 | | } [INFO] [stderr] 766 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 760 | } else if self.is_dest() { [INFO] [stderr] 761 | Some(self.play_info.update_act_init(Action::Search)) [INFO] [stderr] 762 | } else { [INFO] [stderr] 763 | self.move_to_dest() [INFO] [stderr] 764 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:13:28 [INFO] [stderr] | [INFO] [stderr] 13 | const VISITED = 0b000000001; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:14:28 [INFO] [stderr] | [INFO] [stderr] 14 | const UP = 0b000000010; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | const DOWN = 0b000000100; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:16:28 [INFO] [stderr] | [INFO] [stderr] 16 | const LEFT = 0b000001000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:17:28 [INFO] [stderr] | [INFO] [stderr] 17 | const RIGHT = 0b000010000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:18:28 [INFO] [stderr] | [INFO] [stderr] 18 | const LEFT_UP = 0b000100000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | const RIGHT_UP = 0b001000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:20:28 [INFO] [stderr] | [INFO] [stderr] 20 | const LEFT_DOWN = 0b010000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:21:28 [INFO] [stderr] | [INFO] [stderr] 21 | const RIGHT_DOWN = 0b100000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/dangeon.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | val [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/dangeon.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | let val = if self.surface == Surface::Road { [INFO] [stderr] | ___________________^ [INFO] [stderr] 69 | | (1.0 - FIND_RATE_ROAD).powi(searched_i) [INFO] [stderr] 70 | | } else { [INFO] [stderr] 71 | | (1.0 - FIND_RATE_DOOR).powi(searched_i) [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/dangeon.rs:174:20 [INFO] [stderr] | [INFO] [stderr] 174 | } else if cur_surface == Surface::DoorOrRoad { [INFO] [stderr] | ____________________^ [INFO] [stderr] 175 | | if cell_mut.obj != FieldObject::None { [INFO] [stderr] 176 | | cell_mut.surface = Surface::Road; [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 174 | } else if cur_surface == Surface::DoorOrRoad && cell_mut.obj != FieldObject::None { [INFO] [stderr] 175 | cell_mut.surface = Surface::Road; [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/dangeon.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | / if nxt_cell.surface == Surface::Trap { [INFO] [stderr] 327 | | if !is_enemy { [INFO] [stderr] 328 | | return Some(false); [INFO] [stderr] 329 | | } [INFO] [stderr] 330 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 326 | if nxt_cell.surface == Surface::Trap && !is_enemy { [INFO] [stderr] 327 | return Some(false); [INFO] [stderr] 328 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused imports: `BufRead`, `BufReader` [INFO] [stderr] --> src/testutils.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use std::io::{BufRead, BufReader}; [INFO] [stderr] | ^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::from_utf8` [INFO] [stderr] --> src/testutils.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::str::from_utf8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `dangeon::Dangeon` [INFO] [stderr] --> src/testutils.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use dangeon::Dangeon; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `consts::*` [INFO] [stderr] --> src/testutils.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use consts::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:435:29 [INFO] [stderr] | [INFO] [stderr] 435 | const MEAN = 0b0000000001; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:436:29 [INFO] [stderr] | [INFO] [stderr] 436 | const FLYING = 0b0000000010; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:437:29 [INFO] [stderr] | [INFO] [stderr] 437 | const REGENERATE = 0b0000000100; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:438:29 [INFO] [stderr] | [INFO] [stderr] 438 | const GREEDY = 0b0000001000; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:439:29 [INFO] [stderr] | [INFO] [stderr] 439 | const INVISIBLE = 0b0000010000; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:440:29 [INFO] [stderr] | [INFO] [stderr] 440 | const RUSTS_ARMOR = 0b0000100000; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:441:29 [INFO] [stderr] | [INFO] [stderr] 441 | const STEAL_GOLD = 0b0001000000; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:442:29 [INFO] [stderr] | [INFO] [stderr] 442 | const REDUCE_STR = 0b0010000000; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:443:29 [INFO] [stderr] | [INFO] [stderr] 443 | const FREEZES = 0b0100000000; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b01_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data.rs:444:29 [INFO] [stderr] | [INFO] [stderr] 444 | const RANDOM = 0b1000000000; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b10_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/agent.rs:708:9 [INFO] [stderr] | [INFO] [stderr] 708 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/agent.rs:646:19 [INFO] [stderr] | [INFO] [stderr] 646 | let ret = match max_act { [INFO] [stderr] | ___________________^ [INFO] [stderr] 647 | | 0 => Some( [INFO] [stderr] 648 | | self.play_info [INFO] [stderr] 649 | | .update(Tactics::Fight, fight_act, None, fight_val), [INFO] [stderr] ... | [INFO] [stderr] 706 | | _ => None, [INFO] [stderr] 707 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/agent.rs:760:24 [INFO] [stderr] | [INFO] [stderr] 760 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 761 | | if self.is_dest() { [INFO] [stderr] 762 | | Some(self.play_info.update_act_init(Action::Search)) [INFO] [stderr] 763 | | } else { [INFO] [stderr] 764 | | self.move_to_dest() [INFO] [stderr] 765 | | } [INFO] [stderr] 766 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 760 | } else if self.is_dest() { [INFO] [stderr] 761 | Some(self.play_info.update_act_init(Action::Search)) [INFO] [stderr] 762 | } else { [INFO] [stderr] 763 | self.move_to_dest() [INFO] [stderr] 764 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:13:28 [INFO] [stderr] | [INFO] [stderr] 13 | const VISITED = 0b000000001; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:14:28 [INFO] [stderr] | [INFO] [stderr] 14 | const UP = 0b000000010; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | const DOWN = 0b000000100; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:16:28 [INFO] [stderr] | [INFO] [stderr] 16 | const LEFT = 0b000001000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:17:28 [INFO] [stderr] | [INFO] [stderr] 17 | const RIGHT = 0b000010000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:18:28 [INFO] [stderr] | [INFO] [stderr] 18 | const LEFT_UP = 0b000100000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | const RIGHT_UP = 0b001000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:20:28 [INFO] [stderr] | [INFO] [stderr] 20 | const LEFT_DOWN = 0b010000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b0_1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dangeon.rs:21:28 [INFO] [stderr] | [INFO] [stderr] 21 | const RIGHT_DOWN = 0b100000000; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/dangeon.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | val [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/dangeon.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | let val = if self.surface == Surface::Road { [INFO] [stderr] | ___________________^ [INFO] [stderr] 69 | | (1.0 - FIND_RATE_ROAD).powi(searched_i) [INFO] [stderr] 70 | | } else { [INFO] [stderr] 71 | | (1.0 - FIND_RATE_DOOR).powi(searched_i) [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/dangeon.rs:174:20 [INFO] [stderr] | [INFO] [stderr] 174 | } else if cur_surface == Surface::DoorOrRoad { [INFO] [stderr] | ____________________^ [INFO] [stderr] 175 | | if cell_mut.obj != FieldObject::None { [INFO] [stderr] 176 | | cell_mut.surface = Surface::Road; [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 174 | } else if cur_surface == Surface::DoorOrRoad && cell_mut.obj != FieldObject::None { [INFO] [stderr] 175 | cell_mut.surface = Surface::Road; [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/dangeon.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | / if nxt_cell.surface == Surface::Trap { [INFO] [stderr] 327 | | if !is_enemy { [INFO] [stderr] 328 | | return Some(false); [INFO] [stderr] 329 | | } [INFO] [stderr] 330 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 326 | if nxt_cell.surface == Surface::Trap && !is_enemy { [INFO] [stderr] 327 | return Some(false); [INFO] [stderr] 328 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `drink_msgs` [INFO] [stderr] --> src/parse.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | let drink_msgs = vec![ [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_drink_msgs` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `scroll_msgs` [INFO] [stderr] --> src/parse.rs:314:13 [INFO] [stderr] | [INFO] [stderr] 314 | let scroll_msgs = vec!["Your armor is covered by a shimmering gold shield"]; [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_scroll_msgs` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `trap_msgs` [INFO] [stderr] --> src/parse.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | let trap_msgs = vec!["A small dart whizzes by your ear and vanishes"]; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_trap_msgs` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Fight` [INFO] [stderr] --> src/data.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | Fight(Direc), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `UpStair` [INFO] [stderr] --> src/data.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | UpStair, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Rest` [INFO] [stderr] --> src/data.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | Rest, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `QuaffPotion` [INFO] [stderr] --> src/data.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | QuaffPotion(u8), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ReadScroll` [INFO] [stderr] --> src/data.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | ReadScroll(u8), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `WieldWeapon` [INFO] [stderr] --> src/data.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | WieldWeapon(u8), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `WearArmor` [INFO] [stderr] --> src/data.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | WearArmor(u8), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TakeArmorOff` [INFO] [stderr] --> src/data.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | TakeArmorOff, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PutOnRing` [INFO] [stderr] --> src/data.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | PutOnRing(u8), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RemoveRing` [INFO] [stderr] --> src/data.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | RemoveRing, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DropObject` [INFO] [stderr] --> src/data.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | DropObject(u8), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SaveGame` [INFO] [stderr] --> src/data.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | SaveGame, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Quit` [INFO] [stderr] --> src/data.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | Quit, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `near_enemy` [INFO] [stderr] --> src/data.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | pub fn near_enemy(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_type` [INFO] [stderr] --> src/data.rs:418:5 [INFO] [stderr] | [INFO] [stderr] 418 | pub fn from_type(typ: Enemy) -> EnemyHist { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get` [INFO] [stderr] --> src/agent.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | fn get(&self, cd: Coord) -> Option<&EnemyHist> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `armor_id` [INFO] [stderr] --> src/agent.rs:457:5 [INFO] [stderr] | [INFO] [stderr] 457 | armor_id: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `rring_id` [INFO] [stderr] --> src/agent.rs:458:5 [INFO] [stderr] | [INFO] [stderr] 458 | rring_id: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `lring_id` [INFO] [stderr] --> src/agent.rs:459:5 [INFO] [stderr] | [INFO] [stderr] 459 | lring_id: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rect_iter` [INFO] [stderr] --> src/dangeon.rs:206:5 [INFO] [stderr] | [INFO] [stderr] 206 | pub fn rect_iter(&self, rect: Rect) -> RectIter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iter` [INFO] [stderr] --> src/dangeon.rs:652:5 [INFO] [stderr] | [INFO] [stderr] 652 | pub fn iter(&self) -> CoordIter> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iter_mut` [INFO] [stderr] --> src/dangeon.rs:658:5 [INFO] [stderr] | [INFO] [stderr] 658 | pub fn iter_mut(&mut self) -> CoordIterMut> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `RectIter` [INFO] [stderr] --> src/dangeon.rs:935:1 [INFO] [stderr] | [INFO] [stderr] 935 | / pub struct RectIter<'a, T> [INFO] [stderr] 936 | | where [INFO] [stderr] 937 | | T: CoordGet + 'a, [INFO] [stderr] 938 | | { [INFO] [stderr] ... | [INFO] [stderr] 941 | | rect: Rect, [INFO] [stderr] 942 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn to_cd(&self) -> Coord { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:87:19 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn rotate(&self) -> Direc { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn rotate_n(&self, n: usize) -> Direc { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:105:20 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn is_diag(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:872:25 [INFO] [stderr] | [INFO] [stderr] 872 | pub fn can_be_floor(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:878:24 [INFO] [stderr] | [INFO] [stderr] 878 | pub fn can_be_road(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:884:23 [INFO] [stderr] | [INFO] [stderr] 884 | pub fn is_unknown(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:920:20 [INFO] [stderr] | [INFO] [stderr] 920 | pub fn is_item(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | r"--More--", // 0 [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | r"Which direction", // 5 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | r"You scored", // 6 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | r"You have defeated", // 7 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | r"You now have ", // 10 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | r"You found", // 11 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | r"You are now wearing", // 12 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | r"You used to be wearing", // 13 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | r"Which object do you want to", // 14 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | r"Welcome to level", // 15 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | r"Yum", // 16 [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | r"There's no room in your pack", // 17 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | r"You moved onto", // 18 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | r"Dropped", // 19 [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | r"do you want to call", // 20 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | r"not a valid item", // 21 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | r"no way down", // 22 [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | r"potion", // 0 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | r"scroll", // 1 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | r"ring", // 2 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | r"food", // 3 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:117:17 [INFO] [stderr] | [INFO] [stderr] 117 | r"mold", // 4 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | r"eathor armor", // 5 [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | r"tudded leadther", // 6 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | r"ing mail", // 7 [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | r"cale mail", // 8 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | r"hain mail", // 9 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:123:17 [INFO] [stderr] | [INFO] [stderr] 123 | r"plint mail", // 10 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | r"anded mail", // 11 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | r"late mail", // 12 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | r"mace", // 13 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | r"long sword", // 14 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | r"bow", // 15 [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | r"arrow", // 16 [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | r"dagger", // 17 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | r"two handed sword", // 18 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | r"dart", // 19 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | r"shuriken", // 20 [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | r"spear", // 21 [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | r"wand", // 22 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | r"staff", // 23 [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | r"mulet", // 24 [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/agent.rs:823:5 [INFO] [stderr] | [INFO] [stderr] 823 | / fn action(&mut self, action_res: ActionResult, turn: usize) -> Option> { [INFO] [stderr] 824 | | trace!(LOGGER, "{:?} {}", action_res, turn); [INFO] [stderr] 825 | | trace!(LOGGER, "{:?}", self); [INFO] [stderr] 826 | | if self.dead { [INFO] [stderr] ... | [INFO] [stderr] 944 | | } [INFO] [stderr] 945 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/agent.rs:925:59 [INFO] [stderr] | [INFO] [stderr] 925 | let dangeon_msg = self.dangeon.merge(&map[1..(LINES + 1)]); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=LINES` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] warning: variant is never constructed: `Fight` [INFO] [stderr] --> src/data.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | Fight(Direc), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `UpStair` [INFO] [stderr] --> src/data.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | UpStair, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Rest` [INFO] [stderr] --> src/data.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | Rest, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `QuaffPotion` [INFO] [stderr] --> src/data.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | QuaffPotion(u8), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ReadScroll` [INFO] [stderr] --> src/data.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | ReadScroll(u8), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `WieldWeapon` [INFO] [stderr] --> src/data.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | WieldWeapon(u8), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `WearArmor` [INFO] [stderr] --> src/data.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | WearArmor(u8), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TakeArmorOff` [INFO] [stderr] --> src/data.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | TakeArmorOff, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `PutOnRing` [INFO] [stderr] --> src/data.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | PutOnRing(u8), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RemoveRing` [INFO] [stderr] --> src/data.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | RemoveRing, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DropObject` [INFO] [stderr] --> src/data.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | DropObject(u8), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SaveGame` [INFO] [stderr] --> src/data.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | SaveGame, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Quit` [INFO] [stderr] --> src/data.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | Quit, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `near_enemy` [INFO] [stderr] --> src/data.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | pub fn near_enemy(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get` [INFO] [stderr] --> src/agent.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | fn get(&self, cd: Coord) -> Option<&EnemyHist> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `armor_id` [INFO] [stderr] --> src/agent.rs:457:5 [INFO] [stderr] | [INFO] [stderr] 457 | armor_id: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `rring_id` [INFO] [stderr] --> src/agent.rs:458:5 [INFO] [stderr] | [INFO] [stderr] 458 | rring_id: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `lring_id` [INFO] [stderr] --> src/agent.rs:459:5 [INFO] [stderr] | [INFO] [stderr] 459 | lring_id: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iter` [INFO] [stderr] --> src/dangeon.rs:652:5 [INFO] [stderr] | [INFO] [stderr] 652 | pub fn iter(&self) -> CoordIter> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iter_mut` [INFO] [stderr] --> src/dangeon.rs:658:5 [INFO] [stderr] | [INFO] [stderr] 658 | pub fn iter_mut(&mut self) -> CoordIterMut> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `buf_to_str` [INFO] [stderr] --> src/testutils.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn buf_to_str(buf: &Vec>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn to_cd(&self) -> Coord { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:87:19 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn rotate(&self) -> Direc { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn rotate_n(&self, n: usize) -> Direc { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:105:20 [INFO] [stderr] | [INFO] [stderr] 105 | pub fn is_diag(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/agent.rs:983:22 [INFO] [stderr] | [INFO] [stderr] 983 | fn to_action(&self, agent: &FeudalAgent) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:872:25 [INFO] [stderr] | [INFO] [stderr] 872 | pub fn can_be_floor(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:878:24 [INFO] [stderr] | [INFO] [stderr] 878 | pub fn can_be_road(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:884:23 [INFO] [stderr] | [INFO] [stderr] 884 | pub fn is_unknown(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/data.rs:920:20 [INFO] [stderr] | [INFO] [stderr] 920 | pub fn is_item(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | r"--More--", // 0 [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | r"Which direction", // 5 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | r"You scored", // 6 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | r"You have defeated", // 7 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | r"You now have ", // 10 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | r"You found", // 11 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | r"You are now wearing", // 12 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | r"You used to be wearing", // 13 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | r"Which object do you want to", // 14 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | r"Welcome to level", // 15 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | r"Yum", // 16 [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | r"There's no room in your pack", // 17 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | r"You moved onto", // 18 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | r"Dropped", // 19 [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | r"do you want to call", // 20 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | r"not a valid item", // 21 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | r"no way down", // 22 [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | r"potion", // 0 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | r"scroll", // 1 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | r"ring", // 2 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | r"food", // 3 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:117:17 [INFO] [stderr] | [INFO] [stderr] 117 | r"mold", // 4 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | r"eathor armor", // 5 [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | r"tudded leadther", // 6 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | r"ing mail", // 7 [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | r"cale mail", // 8 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | r"hain mail", // 9 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:123:17 [INFO] [stderr] | [INFO] [stderr] 123 | r"plint mail", // 10 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | r"anded mail", // 11 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | r"late mail", // 12 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | r"mace", // 13 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | r"long sword", // 14 [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | r"bow", // 15 [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | r"arrow", // 16 [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | r"dagger", // 17 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | r"two handed sword", // 18 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | r"dart", // 19 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | r"shuriken", // 20 [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | r"spear", // 21 [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | r"wand", // 22 [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | r"staff", // 23 [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/parse.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | r"mulet", // 24 [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/dangeon.rs:432:15 [INFO] [stderr] | [INFO] [stderr] 432 | Some((non_visited_cd.clone(), non_visited_val)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*non_visited_cd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/agent.rs:823:5 [INFO] [stderr] | [INFO] [stderr] 823 | / fn action(&mut self, action_res: ActionResult, turn: usize) -> Option> { [INFO] [stderr] 824 | | trace!(LOGGER, "{:?} {}", action_res, turn); [INFO] [stderr] 825 | | trace!(LOGGER, "{:?}", self); [INFO] [stderr] 826 | | if self.dead { [INFO] [stderr] ... | [INFO] [stderr] 944 | | } [INFO] [stderr] 945 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/dangeon.rs:469:32 [INFO] [stderr] | [INFO] [stderr] 469 | if let Some(_) = adj { [INFO] [stderr] | _________________________- ^^^^^^^ [INFO] [stderr] 470 | | continue 'outer; [INFO] [stderr] 471 | | } else { [INFO] [stderr] 472 | | adj = Some(d.rotate_n(4)); [INFO] [stderr] 473 | | } [INFO] [stderr] | |_________________________- help: try this: `if adj.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/agent.rs:925:59 [INFO] [stderr] | [INFO] [stderr] 925 | let dangeon_msg = self.dangeon.merge(&map[1..(LINES + 1)]); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=LINES` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/agent.rs:983:22 [INFO] [stderr] | [INFO] [stderr] 983 | fn to_action(&self, agent: &FeudalAgent) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dangeon.rs:760:23 [INFO] [stderr] | [INFO] [stderr] 760 | pub fn direc_iter(&self, d: Direc) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dangeon.rs:771:17 [INFO] [stderr] | [INFO] [stderr] 771 | fn range_ok(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dangeon.rs:774:21 [INFO] [stderr] | [INFO] [stderr] 774 | pub fn dist_euc(&self, other: &Coord) -> EucDist { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dangeon.rs:774:35 [INFO] [stderr] | [INFO] [stderr] 774 | pub fn dist_euc(&self, other: &Coord) -> EucDist { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Coord` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dangeon.rs:785:18 [INFO] [stderr] | [INFO] [stderr] 785 | pub fn block(&self) -> BlockVal { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dangeon.rs:802:16 [INFO] [stderr] | [INFO] [stderr] 802 | fn iterate(&self, dir: Direc) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/dangeon.rs:432:15 [INFO] [stderr] | [INFO] [stderr] 432 | Some((non_visited_cd.clone(), non_visited_val)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*non_visited_cd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/damage.rs:48:54 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn hit_rate_deffence(player: &PlayerStatus, ene: &Enemy) -> ProbVal { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Enemy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/damage.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | let sum = (1..self.typ + 1).fold(0f64, |acc, x| acc + f64::from(x)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(1..=self.typ)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/dangeon.rs:469:32 [INFO] [stderr] | [INFO] [stderr] 469 | if let Some(_) = adj { [INFO] [stderr] | _________________________- ^^^^^^^ [INFO] [stderr] 470 | | continue 'outer; [INFO] [stderr] 471 | | } else { [INFO] [stderr] 472 | | adj = Some(d.rotate_n(4)); [INFO] [stderr] 473 | | } [INFO] [stderr] | |_________________________- help: try this: `if adj.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dangeon.rs:760:23 [INFO] [stderr] | [INFO] [stderr] 760 | pub fn direc_iter(&self, d: Direc) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dangeon.rs:771:17 [INFO] [stderr] | [INFO] [stderr] 771 | fn range_ok(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dangeon.rs:774:21 [INFO] [stderr] | [INFO] [stderr] 774 | pub fn dist_euc(&self, other: &Coord) -> EucDist { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dangeon.rs:774:35 [INFO] [stderr] | [INFO] [stderr] 774 | pub fn dist_euc(&self, other: &Coord) -> EucDist { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Coord` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dangeon.rs:785:18 [INFO] [stderr] | [INFO] [stderr] 785 | pub fn block(&self) -> BlockVal { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dangeon.rs:802:16 [INFO] [stderr] | [INFO] [stderr] 802 | fn iterate(&self, dir: Direc) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/damage.rs:48:54 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn hit_rate_deffence(player: &PlayerStatus, ene: &Enemy) -> ProbVal { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Enemy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/damage.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | let sum = (1..self.typ + 1).fold(0f64, |acc, x| acc + f64::from(x)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(1..=self.typ)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/testutils.rs:7:24 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn buf_to_str(buf: &Vec>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.03s [INFO] running `"docker" "inspect" "726ebc158c22ce10a922ad788a339f8d600208c06d8d8eca71fb72d4966e193b"` [INFO] running `"docker" "rm" "-f" "726ebc158c22ce10a922ad788a339f8d600208c06d8d8eca71fb72d4966e193b"` [INFO] [stdout] 726ebc158c22ce10a922ad788a339f8d600208c06d8d8eca71fb72d4966e193b