[INFO] updating cached repository kmc-jp/cerussite [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kmc-jp/cerussite [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kmc-jp/cerussite" "work/ex/clippy-test-run/sources/stable/gh/kmc-jp/cerussite"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kmc-jp/cerussite'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kmc-jp/cerussite" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kmc-jp/cerussite"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kmc-jp/cerussite'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d30b560bda1fe336aae2528edcb49bc24f58e127 [INFO] sha for GitHub repo kmc-jp/cerussite: d30b560bda1fe336aae2528edcb49bc24f58e127 [INFO] validating manifest of kmc-jp/cerussite on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kmc-jp/cerussite on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kmc-jp/cerussite [INFO] finished frobbing kmc-jp/cerussite [INFO] frobbed toml for kmc-jp/cerussite written to work/ex/clippy-test-run/sources/stable/gh/kmc-jp/cerussite/Cargo.toml [INFO] started frobbing kmc-jp/cerussite [INFO] finished frobbing kmc-jp/cerussite [INFO] frobbed toml for kmc-jp/cerussite written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kmc-jp/cerussite/Cargo.toml [INFO] crate kmc-jp/cerussite has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kmc-jp/cerussite against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kmc-jp/cerussite:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 25a62f5ff0dc1901a154fd1373e133cda27e1402b8417dd402b6eaf4c1010485 [INFO] running `"docker" "start" "-a" "25a62f5ff0dc1901a154fd1373e133cda27e1402b8417dd402b6eaf4c1010485"` [INFO] [stderr] Checking cerussite v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ast/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn parse<'a>(mut tokens: Tokens<'a>) -> Ast { [INFO] [stderr] 13 | | let stmt = Stmt::parse(&mut tokens); [INFO] [stderr] 14 | | if !tokens.is_empty() { [INFO] [stderr] 15 | | panic!("invalid tokens: {:?}", tokens); [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | Ast::Stmt(stmt) [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | let tokens = match &tokens[0..5] { [INFO] [stderr] | __________________^ [INFO] [stderr] 33 | | &[Token::TyInt, Token::Ident("main"), Token::SyLPar, Token::TyVoid, Token::SyRPar] => { [INFO] [stderr] 34 | | &tokens[5..] [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | _ => panic!("compilation error"), [INFO] [stderr] 37 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 32 | let tokens = match tokens[0..5] { [INFO] [stderr] 33 | [Token::TyInt, Token::Ident("main"), Token::SyLPar, Token::TyVoid, Token::SyRPar] => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ast/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn parse<'a>(mut tokens: Tokens<'a>) -> Ast { [INFO] [stderr] 13 | | let stmt = Stmt::parse(&mut tokens); [INFO] [stderr] 14 | | if !tokens.is_empty() { [INFO] [stderr] 15 | | panic!("invalid tokens: {:?}", tokens); [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | Ast::Stmt(stmt) [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | let tokens = match &tokens[0..5] { [INFO] [stderr] | __________________^ [INFO] [stderr] 33 | | &[Token::TyInt, Token::Ident("main"), Token::SyLPar, Token::TyVoid, Token::SyRPar] => { [INFO] [stderr] 34 | | &tokens[5..] [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | _ => panic!("compilation error"), [INFO] [stderr] 37 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 32 | let tokens = match tokens[0..5] { [INFO] [stderr] 33 | [Token::TyInt, Token::Ident("main"), Token::SyLPar, Token::TyVoid, Token::SyRPar] => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.60s [INFO] running `"docker" "inspect" "25a62f5ff0dc1901a154fd1373e133cda27e1402b8417dd402b6eaf4c1010485"` [INFO] running `"docker" "rm" "-f" "25a62f5ff0dc1901a154fd1373e133cda27e1402b8417dd402b6eaf4c1010485"` [INFO] [stdout] 25a62f5ff0dc1901a154fd1373e133cda27e1402b8417dd402b6eaf4c1010485