[INFO] updating cached repository kmate/hack-assembler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kmate/hack-assembler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kmate/hack-assembler" "work/ex/clippy-test-run/sources/stable/gh/kmate/hack-assembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kmate/hack-assembler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kmate/hack-assembler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kmate/hack-assembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kmate/hack-assembler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7916ac4eadf84d7adbd57482330881ee82d691ec [INFO] sha for GitHub repo kmate/hack-assembler: 7916ac4eadf84d7adbd57482330881ee82d691ec [INFO] validating manifest of kmate/hack-assembler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kmate/hack-assembler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kmate/hack-assembler [INFO] finished frobbing kmate/hack-assembler [INFO] frobbed toml for kmate/hack-assembler written to work/ex/clippy-test-run/sources/stable/gh/kmate/hack-assembler/Cargo.toml [INFO] started frobbing kmate/hack-assembler [INFO] finished frobbing kmate/hack-assembler [INFO] frobbed toml for kmate/hack-assembler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kmate/hack-assembler/Cargo.toml [INFO] crate kmate/hack-assembler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kmate/hack-assembler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kmate/hack-assembler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d50d2f9d3f18243f4bb6bb5e0a15876dcc28697fa093e62c6b4fc56b2020850f [INFO] running `"docker" "start" "-a" "d50d2f9d3f18243f4bb6bb5e0a15876dcc28697fa093e62c6b4fc56b2020850f"` [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking hack-assembler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:111:20 [INFO] [stderr] | [INFO] [stderr] 111 | Ok(AInst { address: address }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symtab.rs:83:32 [INFO] [stderr] | [INFO] [stderr] 83 | Err(AlreadyBound { symbol: symbol }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `symbol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:111:20 [INFO] [stderr] | [INFO] [stderr] 111 | Ok(AInst { address: address }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symtab.rs:83:32 [INFO] [stderr] | [INFO] [stderr] 83 | Err(AlreadyBound { symbol: symbol }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `symbol` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | table.insert("0", 0b0101010); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b010_1010` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:14:29 [INFO] [stderr] | [INFO] [stderr] 14 | table.insert("1", 0b0111111); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | table.insert("-1", 0b0111010); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:16:29 [INFO] [stderr] | [INFO] [stderr] 16 | table.insert("D", 0b0001100); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:17:29 [INFO] [stderr] | [INFO] [stderr] 17 | table.insert("A", 0b0110000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | table.insert("!D", 0b0001101); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | table.insert("!A", 0b0110001); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | table.insert("-D", 0b0001111); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:21:29 [INFO] [stderr] | [INFO] [stderr] 21 | table.insert("-A", 0b0110011); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | table.insert("D+1", 0b0011111); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | table.insert("A+1", 0b0110111); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | table.insert("D-1", 0b0001110); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | table.insert("A-1", 0b0110010); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:26:29 [INFO] [stderr] | [INFO] [stderr] 26 | table.insert("D+A", 0b0000010); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | table.insert("D-A", 0b0010011); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b001_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:28:29 [INFO] [stderr] | [INFO] [stderr] 28 | table.insert("A-D", 0b0000111); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:29:29 [INFO] [stderr] | [INFO] [stderr] 29 | table.insert("D&A", 0b0000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | table.insert("D|A", 0b0010101); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b001_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | table.insert("M", 0b1110000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:32:29 [INFO] [stderr] | [INFO] [stderr] 32 | table.insert("!M", 0b1110001); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b111_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | table.insert("-M", 0b1110011); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b111_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | table.insert("M+1", 0b1110111); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b111_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | table.insert("M-1", 0b1110010); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b111_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:36:29 [INFO] [stderr] | [INFO] [stderr] 36 | table.insert("D+M", 0b1000010); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:37:29 [INFO] [stderr] | [INFO] [stderr] 37 | table.insert("D-M", 0b1010011); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b101_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | table.insert("M-D", 0b1000111); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | table.insert("D&M", 0b1000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | table.insert("D|M", 0b1010101); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b101_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | table.insert("0", 0b0101010); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b010_1010` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:14:29 [INFO] [stderr] | [INFO] [stderr] 14 | table.insert("1", 0b0111111); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | table.insert("-1", 0b0111010); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:16:29 [INFO] [stderr] | [INFO] [stderr] 16 | table.insert("D", 0b0001100); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:17:29 [INFO] [stderr] | [INFO] [stderr] 17 | table.insert("A", 0b0110000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | table.insert("!D", 0b0001101); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | table.insert("!A", 0b0110001); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | table.insert("-D", 0b0001111); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:21:29 [INFO] [stderr] | [INFO] [stderr] 21 | table.insert("-A", 0b0110011); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | table.insert("D+1", 0b0011111); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | table.insert("A+1", 0b0110111); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | table.insert("D-1", 0b0001110); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | table.insert("A-1", 0b0110010); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b011_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:26:29 [INFO] [stderr] | [INFO] [stderr] 26 | table.insert("D+A", 0b0000010); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | table.insert("D-A", 0b0010011); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b001_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:28:29 [INFO] [stderr] | [INFO] [stderr] 28 | table.insert("A-D", 0b0000111); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:29:29 [INFO] [stderr] | [INFO] [stderr] 29 | table.insert("D&A", 0b0000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | table.insert("D|A", 0b0010101); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b001_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | table.insert("M", 0b1110000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:32:29 [INFO] [stderr] | [INFO] [stderr] 32 | table.insert("!M", 0b1110001); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b111_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | table.insert("-M", 0b1110011); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b111_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | table.insert("M+1", 0b1110111); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b111_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | table.insert("M-1", 0b1110010); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b111_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:36:29 [INFO] [stderr] | [INFO] [stderr] 36 | table.insert("D+M", 0b1000010); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:37:29 [INFO] [stderr] | [INFO] [stderr] 37 | table.insert("D-M", 0b1010011); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b101_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:38:29 [INFO] [stderr] | [INFO] [stderr] 38 | table.insert("M-D", 0b1000111); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | table.insert("D&M", 0b1000000); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | table.insert("D|M", 0b1010101); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0b101_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:145:16 [INFO] [stderr] | [INFO] [stderr] 145 | Ok(0b1111010101000000), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_0101_0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen.rs:153:16 [INFO] [stderr] | [INFO] [stderr] 153 | Ok(0b1110010101101011), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1110_0101_0110_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/codegen.rs:118:43 [INFO] [stderr] | [INFO] [stderr] 118 | let c = COMP_TABLE.get(&comp).ok_or(LookupMiss(Comp(comp)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| LookupMiss(Comp(comp)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/codegen.rs:121:53 [INFO] [stderr] | [INFO] [stderr] 121 | Some(dest) => *DEST_TABLE.get(dest).ok_or(LookupMiss(Dest(dest)))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| LookupMiss(Dest(dest)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/codegen.rs:125:53 [INFO] [stderr] | [INFO] [stderr] 125 | Some(jump) => *JUMP_TABLE.get(jump).ok_or(LookupMiss(Jump(jump)))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| LookupMiss(Jump(jump)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:87:12 [INFO] [stderr] | [INFO] [stderr] 87 | lines: &'a CleanLines, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/symtab.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | self.entries.get(symbol).map(|&x| x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.entries.get(symbol).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/codegen.rs:118:43 [INFO] [stderr] | [INFO] [stderr] 118 | let c = COMP_TABLE.get(&comp).ok_or(LookupMiss(Comp(comp)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| LookupMiss(Comp(comp)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/codegen.rs:121:53 [INFO] [stderr] | [INFO] [stderr] 121 | Some(dest) => *DEST_TABLE.get(dest).ok_or(LookupMiss(Dest(dest)))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| LookupMiss(Dest(dest)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/codegen.rs:125:53 [INFO] [stderr] | [INFO] [stderr] 125 | Some(jump) => *JUMP_TABLE.get(jump).ok_or(LookupMiss(Jump(jump)))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| LookupMiss(Jump(jump)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:87:12 [INFO] [stderr] | [INFO] [stderr] 87 | lines: &'a CleanLines, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/symtab.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | self.entries.get(symbol).map(|&x| x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.entries.get(symbol).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.89s [INFO] running `"docker" "inspect" "d50d2f9d3f18243f4bb6bb5e0a15876dcc28697fa093e62c6b4fc56b2020850f"` [INFO] running `"docker" "rm" "-f" "d50d2f9d3f18243f4bb6bb5e0a15876dcc28697fa093e62c6b4fc56b2020850f"` [INFO] [stdout] d50d2f9d3f18243f4bb6bb5e0a15876dcc28697fa093e62c6b4fc56b2020850f