[INFO] updating cached repository klnusbaum/bintree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/klnusbaum/bintree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/klnusbaum/bintree" "work/ex/clippy-test-run/sources/stable/gh/klnusbaum/bintree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/klnusbaum/bintree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/klnusbaum/bintree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/klnusbaum/bintree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/klnusbaum/bintree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 99eb2a05744b80bad6f4721f2861b97e1a7d70b4 [INFO] sha for GitHub repo klnusbaum/bintree: 99eb2a05744b80bad6f4721f2861b97e1a7d70b4 [INFO] validating manifest of klnusbaum/bintree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of klnusbaum/bintree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing klnusbaum/bintree [INFO] finished frobbing klnusbaum/bintree [INFO] frobbed toml for klnusbaum/bintree written to work/ex/clippy-test-run/sources/stable/gh/klnusbaum/bintree/Cargo.toml [INFO] started frobbing klnusbaum/bintree [INFO] finished frobbing klnusbaum/bintree [INFO] frobbed toml for klnusbaum/bintree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/klnusbaum/bintree/Cargo.toml [INFO] crate klnusbaum/bintree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting klnusbaum/bintree against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/klnusbaum/bintree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b096b47e02ac7fcaa8717f8aebca2f68b6a1d7e1bb02cad5345779c1fdaf5060 [INFO] running `"docker" "start" "-a" "b096b47e02ac7fcaa8717f8aebca2f68b6a1d7e1bb02cad5345779c1fdaf5060"` [INFO] [stderr] Checking bintree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:91:19 [INFO] [stderr] | [INFO] [stderr] 91 | } else if key < &self.key { [INFO] [stderr] | ^^^^^^--------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `BinaryTree` [INFO] [stderr] --> src/lib.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / pub fn new() -> BinaryTree { [INFO] [stderr] 136 | | BinaryTree{ [INFO] [stderr] 137 | | root: None, [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 129 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/lib.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | / if self.root.is_none() { [INFO] [stderr] 159 | | return None; [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `self.root?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | / match self.root { [INFO] [stderr] 174 | | None => true, [INFO] [stderr] 175 | | Some(_) => false, [INFO] [stderr] 176 | | } [INFO] [stderr] | |_________^ help: try this: `self.root.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:91:19 [INFO] [stderr] | [INFO] [stderr] 91 | } else if key < &self.key { [INFO] [stderr] | ^^^^^^--------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `BinaryTree` [INFO] [stderr] --> src/lib.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / pub fn new() -> BinaryTree { [INFO] [stderr] 136 | | BinaryTree{ [INFO] [stderr] 137 | | root: None, [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 129 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/lib.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | / if self.root.is_none() { [INFO] [stderr] 159 | | return None; [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `self.root?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | / match self.root { [INFO] [stderr] 174 | | None => true, [INFO] [stderr] 175 | | Some(_) => false, [INFO] [stderr] 176 | | } [INFO] [stderr] | |_________^ help: try this: `self.root.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.57s [INFO] running `"docker" "inspect" "b096b47e02ac7fcaa8717f8aebca2f68b6a1d7e1bb02cad5345779c1fdaf5060"` [INFO] running `"docker" "rm" "-f" "b096b47e02ac7fcaa8717f8aebca2f68b6a1d7e1bb02cad5345779c1fdaf5060"` [INFO] [stdout] b096b47e02ac7fcaa8717f8aebca2f68b6a1d7e1bb02cad5345779c1fdaf5060