[INFO] updating cached repository klemens/rconc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/klemens/rconc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/klemens/rconc" "work/ex/clippy-test-run/sources/stable/gh/klemens/rconc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/klemens/rconc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/klemens/rconc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/klemens/rconc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/klemens/rconc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d8fa852620aea8e75c5201e20eb08742c5a4082d [INFO] sha for GitHub repo klemens/rconc: d8fa852620aea8e75c5201e20eb08742c5a4082d [INFO] validating manifest of klemens/rconc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of klemens/rconc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing klemens/rconc [INFO] finished frobbing klemens/rconc [INFO] frobbed toml for klemens/rconc written to work/ex/clippy-test-run/sources/stable/gh/klemens/rconc/Cargo.toml [INFO] started frobbing klemens/rconc [INFO] finished frobbing klemens/rconc [INFO] frobbed toml for klemens/rconc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/klemens/rconc/Cargo.toml [INFO] crate klemens/rconc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting klemens/rconc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/klemens/rconc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5978378d9bd698965a0ed56139b8dc95952306260a3666e27afe3462716009c0 [INFO] running `"docker" "start" "-a" "5978378d9bd698965a0ed56139b8dc95952306260a3666e27afe3462716009c0"` [INFO] [stderr] Checking bufstream v0.1.2 [INFO] [stderr] Checking either v1.0.3 [INFO] [stderr] Checking xdg v2.0.0 [INFO] [stderr] Checking rust-ini v0.9.12 [INFO] [stderr] Checking clap v2.20.3 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking rcon v0.1.0 [INFO] [stderr] Checking app_dirs v1.1.1 [INFO] [stderr] Checking itertools v0.5.9 [INFO] [stderr] Checking error-chain v0.5.0 [INFO] [stderr] Checking rconc v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | ini: ini, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ini` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | ini: ini, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ini` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / return match (self.ini.get_from(Some(server), "address"), [INFO] [stderr] 52 | | self.ini.get_from(Some(server), "password")) { [INFO] [stderr] 53 | | (Some(addr), Some(pass)) => Some((addr, pass)), [INFO] [stderr] 54 | | _ => None [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | match (self.ini.get_from(Some(server), "address"), [INFO] [stderr] 52 | self.ini.get_from(Some(server), "password")) { [INFO] [stderr] 53 | (Some(addr), Some(pass)) => Some((addr, pass)), [INFO] [stderr] 54 | _ => None [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / return match (self.ini.get_from(Some(server), "address"), [INFO] [stderr] 52 | | self.ini.get_from(Some(server), "password")) { [INFO] [stderr] 53 | | (Some(addr), Some(pass)) => Some((addr, pass)), [INFO] [stderr] 54 | | _ => None [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | match (self.ini.get_from(Some(server), "address"), [INFO] [stderr] 52 | self.ini.get_from(Some(server), "password")) { [INFO] [stderr] 53 | (Some(addr), Some(pass)) => Some((addr, pass)), [INFO] [stderr] 54 | _ => None [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | / if let &Some(ref server) = key { [INFO] [stderr] 87 | | Some(&server) [INFO] [stderr] 88 | | } else { [INFO] [stderr] 89 | | // There is at most one empty section in an ini file [INFO] [stderr] 90 | | self.next() [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | if let Some(ref server) = *key { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/errors.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | error_chain! { } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:39:40 [INFO] [stderr] | [INFO] [stderr] 39 | if server.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:96:50 [INFO] [stderr] | [INFO] [stderr] 96 | let (address, password) = if server.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | / if let &Some(ref server) = key { [INFO] [stderr] 87 | | Some(&server) [INFO] [stderr] 88 | | } else { [INFO] [stderr] 89 | | // There is at most one empty section in an ini file [INFO] [stderr] 90 | | self.next() [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | if let Some(ref server) = *key { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/errors.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | error_chain! { } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:39:40 [INFO] [stderr] | [INFO] [stderr] 39 | if server.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:96:50 [INFO] [stderr] | [INFO] [stderr] 96 | let (address, password) = if server.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.21s [INFO] running `"docker" "inspect" "5978378d9bd698965a0ed56139b8dc95952306260a3666e27afe3462716009c0"` [INFO] running `"docker" "rm" "-f" "5978378d9bd698965a0ed56139b8dc95952306260a3666e27afe3462716009c0"` [INFO] [stdout] 5978378d9bd698965a0ed56139b8dc95952306260a3666e27afe3462716009c0