[INFO] updating cached repository kkostov/rust-aws-lambda-dynamodb [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kkostov/rust-aws-lambda-dynamodb [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kkostov/rust-aws-lambda-dynamodb" "work/ex/clippy-test-run/sources/stable/gh/kkostov/rust-aws-lambda-dynamodb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kkostov/rust-aws-lambda-dynamodb'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kkostov/rust-aws-lambda-dynamodb" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kkostov/rust-aws-lambda-dynamodb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kkostov/rust-aws-lambda-dynamodb'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d2de88877f1d1f28decf084685e07fc0b64b5211 [INFO] sha for GitHub repo kkostov/rust-aws-lambda-dynamodb: d2de88877f1d1f28decf084685e07fc0b64b5211 [INFO] validating manifest of kkostov/rust-aws-lambda-dynamodb on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kkostov/rust-aws-lambda-dynamodb on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kkostov/rust-aws-lambda-dynamodb [INFO] finished frobbing kkostov/rust-aws-lambda-dynamodb [INFO] frobbed toml for kkostov/rust-aws-lambda-dynamodb written to work/ex/clippy-test-run/sources/stable/gh/kkostov/rust-aws-lambda-dynamodb/Cargo.toml [INFO] started frobbing kkostov/rust-aws-lambda-dynamodb [INFO] finished frobbing kkostov/rust-aws-lambda-dynamodb [INFO] frobbed toml for kkostov/rust-aws-lambda-dynamodb written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kkostov/rust-aws-lambda-dynamodb/Cargo.toml [INFO] crate kkostov/rust-aws-lambda-dynamodb has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kkostov/rust-aws-lambda-dynamodb against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kkostov/rust-aws-lambda-dynamodb:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0a61fae721382756f7f3915f4a7acf76d0c669dd06bc7345713fb8d1cfaeebdb [INFO] running `"docker" "start" "-a" "0a61fae721382756f7f3915f4a7acf76d0c669dd06bc7345713fb8d1cfaeebdb"` [INFO] [stderr] Compiling ring v0.13.5 [INFO] [stderr] Compiling rusoto_core v0.35.0 [INFO] [stderr] Checking dirs v1.0.4 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking simple_logger v1.0.1 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking sct v0.4.0 [INFO] [stderr] Checking webpki v0.18.1 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking ct-logs v0.4.0 [INFO] [stderr] Checking rustls v0.13.1 [INFO] [stderr] Checking webpki-roots v0.15.0 [INFO] [stderr] Checking rusoto_credential v0.14.0 [INFO] [stderr] Checking lambda_runtime_client v0.1.0 [INFO] [stderr] Checking tokio-rustls v0.7.2 [INFO] [stderr] Checking hyper-rustls v0.14.0 [INFO] [stderr] Checking lambda_runtime v0.1.0 [INFO] [stderr] Checking rusoto_dynamodb v0.35.0 [INFO] [stderr] Checking aws_validate_serial v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | / match result.item { [INFO] [stderr] 97 | | Some(_) => false, // invalid, serial_number was found [INFO] [stderr] 98 | | None => true // valid, serial_number was not found [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____________^ help: try this: `result.item.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | / match result.item { [INFO] [stderr] 97 | | Some(_) => false, // invalid, serial_number was found [INFO] [stderr] 98 | | None => true // valid, serial_number was not found [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____________^ help: try this: `result.item.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 47.29s [INFO] running `"docker" "inspect" "0a61fae721382756f7f3915f4a7acf76d0c669dd06bc7345713fb8d1cfaeebdb"` [INFO] running `"docker" "rm" "-f" "0a61fae721382756f7f3915f4a7acf76d0c669dd06bc7345713fb8d1cfaeebdb"` [INFO] [stdout] 0a61fae721382756f7f3915f4a7acf76d0c669dd06bc7345713fb8d1cfaeebdb