[INFO] updating cached repository kirushik/nonchalance [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kirushik/nonchalance [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kirushik/nonchalance" "work/ex/clippy-test-run/sources/stable/gh/kirushik/nonchalance"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kirushik/nonchalance'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kirushik/nonchalance" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirushik/nonchalance"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirushik/nonchalance'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3ed8e91a6533319a6f85718ca6119e307f3804a5 [INFO] sha for GitHub repo kirushik/nonchalance: 3ed8e91a6533319a6f85718ca6119e307f3804a5 [INFO] validating manifest of kirushik/nonchalance on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kirushik/nonchalance on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kirushik/nonchalance [INFO] finished frobbing kirushik/nonchalance [INFO] frobbed toml for kirushik/nonchalance written to work/ex/clippy-test-run/sources/stable/gh/kirushik/nonchalance/Cargo.toml [INFO] started frobbing kirushik/nonchalance [INFO] finished frobbing kirushik/nonchalance [INFO] frobbed toml for kirushik/nonchalance written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirushik/nonchalance/Cargo.toml [INFO] crate kirushik/nonchalance has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kirushik/nonchalance against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kirushik/nonchalance:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d423880d14f1b635260adc135b595a394fe07befa08829ac1706eb06d4bf6898 [INFO] running `"docker" "start" "-a" "d423880d14f1b635260adc135b595a394fe07befa08829ac1706eb06d4bf6898"` [INFO] [stderr] Compiling libc v0.2.24 [INFO] [stderr] Compiling num-traits v0.1.39 [INFO] [stderr] Compiling scopeguard v0.3.2 [INFO] [stderr] Compiling futures v0.1.14 [INFO] [stderr] Compiling lazy_static v0.2.8 [INFO] [stderr] Checking fixedbitset v0.1.6 [INFO] [stderr] Checking untrusted v0.5.0 [INFO] [stderr] Checking ttf-noto-sans v0.1.1 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking unicode-bidi v0.3.3 [INFO] [stderr] Checking num-complex v0.1.38 [INFO] [stderr] Checking simple-signal v1.1.0 [INFO] [stderr] Compiling gl_generator v0.5.3 [INFO] [stderr] Checking num-bigint v0.1.39 [INFO] [stderr] Compiling coco v0.1.1 [INFO] [stderr] Checking petgraph v0.4.5 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking x11-dl v2.14.0 [INFO] [stderr] Checking idna v0.1.2 [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Compiling num_cpus v1.5.1 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking tempfile v2.1.5 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking num-rational v0.1.38 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking daggy v0.5.0 [INFO] [stderr] Compiling glutin v0.7.4 [INFO] [stderr] Compiling glium v0.16.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling rayon-core v1.2.1 [INFO] [stderr] Checking url v1.5.0 [INFO] [stderr] Checking num v0.1.39 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling rayon v0.7.1 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking ws v0.7.3 [INFO] [stderr] Compiling ring v0.9.7 [INFO] [stderr] Checking ring-pwhash v0.2.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking conrod v0.53.0 [INFO] [stderr] Checking nonchalance v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/websockets.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | WSHandler{out: out, url_request_sender: url_request_sender, origin: None, trust_origin_in_data: false} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/websockets.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | WSHandler{out: out, url_request_sender: url_request_sender, origin: None, trust_origin_in_data: false} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `url_request_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/websockets.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | WSHandler{out: out, url_request_sender: url_request_sender, origin: None, trust_origin_in_data: false} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/websockets.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | WSHandler{out: out, url_request_sender: url_request_sender, origin: None, trust_origin_in_data: false} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `url_request_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:33:42 [INFO] [stderr] | [INFO] [stderr] 33 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:33:56 [INFO] [stderr] | [INFO] [stderr] 33 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:35:51 [INFO] [stderr] | [INFO] [stderr] 35 | let mut url: String = std::env::args().nth(1).unwrap_or("https://ya.ru".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "https://ya.ru".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/main.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / if let Some(option) = url_request_receiver.try_recv().ok() { [INFO] [stderr] 65 | | if let Some((new_url, callback_channel)) = option { [INFO] [stderr] 66 | | url = new_url.into_string(); [INFO] [stderr] 67 | | callback = Some(callback_channel); [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(option)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:33:42 [INFO] [stderr] | [INFO] [stderr] 33 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:33:56 [INFO] [stderr] | [INFO] [stderr] 33 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:35:51 [INFO] [stderr] | [INFO] [stderr] 35 | let mut url: String = std::env::args().nth(1).unwrap_or("https://ya.ru".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "https://ya.ru".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/main.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / if let Some(option) = url_request_receiver.try_recv().ok() { [INFO] [stderr] 65 | | if let Some((new_url, callback_channel)) = option { [INFO] [stderr] 66 | | url = new_url.into_string(); [INFO] [stderr] 67 | | callback = Some(callback_channel); [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(option)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 10s [INFO] running `"docker" "inspect" "d423880d14f1b635260adc135b595a394fe07befa08829ac1706eb06d4bf6898"` [INFO] running `"docker" "rm" "-f" "d423880d14f1b635260adc135b595a394fe07befa08829ac1706eb06d4bf6898"` [INFO] [stdout] d423880d14f1b635260adc135b595a394fe07befa08829ac1706eb06d4bf6898