[INFO] updating cached repository kirmanak/rsh
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/kirmanak/rsh
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/kirmanak/rsh" "work/ex/clippy-test-run/sources/stable/gh/kirmanak/rsh"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kirmanak/rsh'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/kirmanak/rsh" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirmanak/rsh"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirmanak/rsh'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 67caa7c99d0ef16f8dbb8393f4904559444399e5
[INFO] sha for GitHub repo kirmanak/rsh: 67caa7c99d0ef16f8dbb8393f4904559444399e5
[INFO] validating manifest of kirmanak/rsh on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of kirmanak/rsh on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing kirmanak/rsh
[INFO] finished frobbing kirmanak/rsh
[INFO] frobbed toml for kirmanak/rsh written to work/ex/clippy-test-run/sources/stable/gh/kirmanak/rsh/Cargo.toml
[INFO] started frobbing kirmanak/rsh
[INFO] finished frobbing kirmanak/rsh
[INFO] frobbed toml for kirmanak/rsh written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirmanak/rsh/Cargo.toml
[INFO] crate kirmanak/rsh has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting kirmanak/rsh against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kirmanak/rsh:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a865627c35e8646d21e145645b337d8a13718c5abd00e7d32d106d8a5f4eff75
[INFO] running `"docker" "start" "-a" "a865627c35e8646d21e145645b337d8a13718c5abd00e7d32d106d8a5f4eff75"`
[INFO] [stderr]     Checking rsh v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/native/error.rs:63:20
[INFO] [stderr]    |
[INFO] [stderr] 63 |               } else {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 64 | |                 if let Ok(text) = unsafe { copy_string(text) } {
[INFO] [stderr] 65 | |                     Errno { code, text }
[INFO] [stderr] 66 | |                 } else {
[INFO] [stderr] 67 | |                     write_exit(3, "errno string is incorrect C string");
[INFO] [stderr] 68 | |                 }
[INFO] [stderr] 69 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 63 |             } else if let Ok(text) = unsafe { copy_string(text) } {
[INFO] [stderr] 64 |     Errno { code, text }
[INFO] [stderr] 65 | } else {
[INFO] [stderr] 66 |     write_exit(3, "errno string is incorrect C string");
[INFO] [stderr] 67 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/shell/mod.rs:144:17
[INFO] [stderr]     |
[INFO] [stderr] 144 |                 value
[INFO] [stderr]     |                 ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/shell/mod.rs:140:29
[INFO] [stderr]     |
[INFO] [stderr] 140 |                   let value = self.variables
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 141 | |                     .get(var_name)
[INFO] [stderr] 142 | |                     .map(String::to_owned)
[INFO] [stderr] 143 | |                     .unwrap_or(var(var_name).unwrap_or(String::new()));
[INFO] [stderr]     | |______________________________________________________________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/shell/mod.rs:222:9
[INFO] [stderr]     |
[INFO] [stderr] 222 | /         return if check_file(&rc_file)? {
[INFO] [stderr] 223 | |             self.interpret(&rc_file)
[INFO] [stderr] 224 | |         } else {
[INFO] [stderr] 225 | |             Ok(())
[INFO] [stderr] 226 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 222 |         if check_file(&rc_file)? {
[INFO] [stderr] 223 |             self.interpret(&rc_file)
[INFO] [stderr] 224 |         } else {
[INFO] [stderr] 225 |             Ok(())
[INFO] [stderr] 226 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:20:20
[INFO] [stderr]    |
[INFO] [stderr] 20 |               } else {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 21 | |                 if let Err(reason) = shell.interact() {
[INFO] [stderr] 22 | |                     let error = format!("{}\n", reason);
[INFO] [stderr] 23 | |                     write_exit(6, &error);
[INFO] [stderr] 24 | |                 }
[INFO] [stderr] 25 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 20 |             } else if let Err(reason) = shell.interact() {
[INFO] [stderr] 21 |     let error = format!("{}\n", reason);
[INFO] [stderr] 22 |     write_exit(6, &error);
[INFO] [stderr] 23 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/native/error.rs:63:20
[INFO] [stderr]    |
[INFO] [stderr] 63 |               } else {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 64 | |                 if let Ok(text) = unsafe { copy_string(text) } {
[INFO] [stderr] 65 | |                     Errno { code, text }
[INFO] [stderr] 66 | |                 } else {
[INFO] [stderr] 67 | |                     write_exit(3, "errno string is incorrect C string");
[INFO] [stderr] 68 | |                 }
[INFO] [stderr] 69 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 63 |             } else if let Ok(text) = unsafe { copy_string(text) } {
[INFO] [stderr] 64 |     Errno { code, text }
[INFO] [stderr] 65 | } else {
[INFO] [stderr] 66 |     write_exit(3, "errno string is incorrect C string");
[INFO] [stderr] 67 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/shell/mod.rs:144:17
[INFO] [stderr]     |
[INFO] [stderr] 144 |                 value
[INFO] [stderr]     |                 ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/shell/mod.rs:140:29
[INFO] [stderr]     |
[INFO] [stderr] 140 |                   let value = self.variables
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 141 | |                     .get(var_name)
[INFO] [stderr] 142 | |                     .map(String::to_owned)
[INFO] [stderr] 143 | |                     .unwrap_or(var(var_name).unwrap_or(String::new()));
[INFO] [stderr]     | |______________________________________________________________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/shell/mod.rs:222:9
[INFO] [stderr]     |
[INFO] [stderr] 222 | /         return if check_file(&rc_file)? {
[INFO] [stderr] 223 | |             self.interpret(&rc_file)
[INFO] [stderr] 224 | |         } else {
[INFO] [stderr] 225 | |             Ok(())
[INFO] [stderr] 226 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 222 |         if check_file(&rc_file)? {
[INFO] [stderr] 223 |             self.interpret(&rc_file)
[INFO] [stderr] 224 |         } else {
[INFO] [stderr] 225 |             Ok(())
[INFO] [stderr] 226 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:20:20
[INFO] [stderr]    |
[INFO] [stderr] 20 |               } else {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 21 | |                 if let Err(reason) = shell.interact() {
[INFO] [stderr] 22 | |                     let error = format!("{}\n", reason);
[INFO] [stderr] 23 | |                     write_exit(6, &error);
[INFO] [stderr] 24 | |                 }
[INFO] [stderr] 25 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 20 |             } else if let Err(reason) = shell.interact() {
[INFO] [stderr] 21 |     let error = format!("{}\n", reason);
[INFO] [stderr] 22 |     write_exit(6, &error);
[INFO] [stderr] 23 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/shell/mod.rs:34:14
[INFO] [stderr]    |
[INFO] [stderr] 34 |             .unwrap_or(String::from("/usr/bin"))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("/usr/bin"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unused label `'outer`
[INFO] [stderr]    --> src/shell/mod.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 | /         'outer: loop {
[INFO] [stderr] 130 | |             let mut arg = match arguments.next() {
[INFO] [stderr] 131 | |                 None => break,
[INFO] [stderr] 132 | |                 Some(value) => String::from(value),
[INFO] [stderr] ...   |
[INFO] [stderr] 176 | |             }
[INFO] [stderr] 177 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_label)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/shell/mod.rs:134:49
[INFO] [stderr]     |
[INFO] [stderr] 134 |             arg = if let Some(begin) = arg.find("$") {
[INFO] [stderr]     |                                                 ^^^ help: try using a char instead: `'$'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/shell/mod.rs:138:22
[INFO] [stderr]     |
[INFO] [stderr] 138 |                     .unwrap_or(arg.len());
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| arg.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/shell/mod.rs:143:22
[INFO] [stderr]     |
[INFO] [stderr] 143 |                     .unwrap_or(var(var_name).unwrap_or(String::new()));
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| var(var_name).unwrap_or(String::new()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/shell/mod.rs:143:32
[INFO] [stderr]     |
[INFO] [stderr] 143 |                     .unwrap_or(var(var_name).unwrap_or(String::new()));
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `var(var_name).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/shell/mod.rs:148:43
[INFO] [stderr]     |
[INFO] [stderr] 148 |             if let Some(index) = arg.find(">") {
[INFO] [stderr]     |                                           ^^^ help: try using a char instead: `'>'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/shell/mod.rs:149:49
[INFO] [stderr]     |
[INFO] [stderr] 149 |                 let old_fd = if arg.starts_with(">") {
[INFO] [stderr]     |                                                 ^^^ help: try using a char instead: `'>'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/shell/mod.rs:208:23
[INFO] [stderr]     |
[INFO] [stderr] 208 |     fn is_login(args: &Vec<String>) -> bool {
[INFO] [stderr]     |                       ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/shell/mod.rs:259:39
[INFO] [stderr]     |
[INFO] [stderr] 259 |             } else if arg.starts_with("-") {
[INFO] [stderr]     |                                       ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/shell/mod.rs:271:35
[INFO] [stderr]     |
[INFO] [stderr] 271 |     let hostname = get_hostname().unwrap_or(String::from("hostname"));
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("hostname"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/shell/mod.rs:34:14
[INFO] [stderr]    |
[INFO] [stderr] 34 |             .unwrap_or(String::from("/usr/bin"))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("/usr/bin"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unused label `'outer`
[INFO] [stderr]    --> src/shell/mod.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 | /         'outer: loop {
[INFO] [stderr] 130 | |             let mut arg = match arguments.next() {
[INFO] [stderr] 131 | |                 None => break,
[INFO] [stderr] 132 | |                 Some(value) => String::from(value),
[INFO] [stderr] ...   |
[INFO] [stderr] 176 | |             }
[INFO] [stderr] 177 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_label)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/shell/mod.rs:134:49
[INFO] [stderr]     |
[INFO] [stderr] 134 |             arg = if let Some(begin) = arg.find("$") {
[INFO] [stderr]     |                                                 ^^^ help: try using a char instead: `'$'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/shell/mod.rs:138:22
[INFO] [stderr]     |
[INFO] [stderr] 138 |                     .unwrap_or(arg.len());
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| arg.len())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/shell/mod.rs:143:22
[INFO] [stderr]     |
[INFO] [stderr] 143 |                     .unwrap_or(var(var_name).unwrap_or(String::new()));
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| var(var_name).unwrap_or(String::new()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/shell/mod.rs:143:32
[INFO] [stderr]     |
[INFO] [stderr] 143 |                     .unwrap_or(var(var_name).unwrap_or(String::new()));
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `var(var_name).unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/shell/mod.rs:148:43
[INFO] [stderr]     |
[INFO] [stderr] 148 |             if let Some(index) = arg.find(">") {
[INFO] [stderr]     |                                           ^^^ help: try using a char instead: `'>'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/shell/mod.rs:149:49
[INFO] [stderr]     |
[INFO] [stderr] 149 |                 let old_fd = if arg.starts_with(">") {
[INFO] [stderr]     |                                                 ^^^ help: try using a char instead: `'>'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/shell/mod.rs:208:23
[INFO] [stderr]     |
[INFO] [stderr] 208 |     fn is_login(args: &Vec<String>) -> bool {
[INFO] [stderr]     |                       ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/shell/mod.rs:259:39
[INFO] [stderr]     |
[INFO] [stderr] 259 |             } else if arg.starts_with("-") {
[INFO] [stderr]     |                                       ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/shell/mod.rs:271:35
[INFO] [stderr]     |
[INFO] [stderr] 271 |     let hostname = get_hostname().unwrap_or(String::from("hostname"));
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("hostname"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.13s
[INFO] running `"docker" "inspect" "a865627c35e8646d21e145645b337d8a13718c5abd00e7d32d106d8a5f4eff75"`
[INFO] running `"docker" "rm" "-f" "a865627c35e8646d21e145645b337d8a13718c5abd00e7d32d106d8a5f4eff75"`
[INFO] [stdout] a865627c35e8646d21e145645b337d8a13718c5abd00e7d32d106d8a5f4eff75