[INFO] updating cached repository kirjavascript/trueLMAO [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kirjavascript/trueLMAO [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kirjavascript/trueLMAO" "work/ex/clippy-test-run/sources/stable/gh/kirjavascript/trueLMAO"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kirjavascript/trueLMAO'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kirjavascript/trueLMAO" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirjavascript/trueLMAO"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirjavascript/trueLMAO'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8ba585c35bde4d892aa02654e08874516711bc58 [INFO] sha for GitHub repo kirjavascript/trueLMAO: 8ba585c35bde4d892aa02654e08874516711bc58 [INFO] validating manifest of kirjavascript/trueLMAO on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kirjavascript/trueLMAO on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kirjavascript/trueLMAO [INFO] finished frobbing kirjavascript/trueLMAO [INFO] frobbed toml for kirjavascript/trueLMAO written to work/ex/clippy-test-run/sources/stable/gh/kirjavascript/trueLMAO/Cargo.toml [INFO] started frobbing kirjavascript/trueLMAO [INFO] finished frobbing kirjavascript/trueLMAO [INFO] frobbed toml for kirjavascript/trueLMAO written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirjavascript/trueLMAO/Cargo.toml [INFO] crate kirjavascript/trueLMAO has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kirjavascript/trueLMAO against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kirjavascript/trueLMAO:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c10333b1dd94a6137c15d2d16675ae9e217fc2226514788ada141e912e1413ac [INFO] running `"docker" "start" "-a" "c10333b1dd94a6137c15d2d16675ae9e217fc2226514788ada141e912e1413ac"` [INFO] [stderr] Compiling cairo-rs v0.3.0 [INFO] [stderr] Compiling gio v0.3.0 [INFO] [stderr] Compiling gdk-pixbuf v0.3.0 [INFO] [stderr] Compiling gdk v0.7.0 [INFO] [stderr] Compiling gtk v0.3.0 [INFO] [stderr] Compiling gio-sys v0.5.0 [INFO] [stderr] Compiling pango-sys v0.5.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.5.0 [INFO] [stderr] Compiling cairo-sys-rs v0.5.0 [INFO] [stderr] Compiling gdk-sys v0.5.0 [INFO] [stderr] Compiling gtk-sys v0.5.0 [INFO] [stderr] Checking glib-sys v0.5.0 [INFO] [stderr] Checking gobject-sys v0.5.0 [INFO] [stderr] Checking glib v0.4.0 [INFO] [stderr] Checking atk-sys v0.5.0 [INFO] [stderr] Checking pango v0.3.0 [INFO] [stderr] Checking truelmao v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/opcodes/mod.rs:440:17 [INFO] [stderr] | [INFO] [stderr] 440 | src_value: src_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `src_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/opcodes/mod.rs:531:17 [INFO] [stderr] | [INFO] [stderr] 531 | src_value: src_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `src_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/opcodes/mod.rs:440:17 [INFO] [stderr] | [INFO] [stderr] 440 | src_value: src_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `src_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/opcodes/mod.rs:531:17 [INFO] [stderr] | [INFO] [stderr] 531 | src_value: src_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `src_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/console/mod.rs:168:61 [INFO] [stderr] | [INFO] [stderr] 168 | (word as u32) + 0xFFFF0000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/console/mod.rs:186:61 [INFO] [stderr] | [INFO] [stderr] 186 | (word as u32) + 0xFFFF0000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ram/mod.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | 0xFFFFFFFF [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:214:43 [INFO] [stderr] | [INFO] [stderr] 214 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:217:45 [INFO] [stderr] | [INFO] [stderr] 217 | let dst_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:243:43 [INFO] [stderr] | [INFO] [stderr] 243 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:246:45 [INFO] [stderr] | [INFO] [stderr] 246 | let dst_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:272:43 [INFO] [stderr] | [INFO] [stderr] 272 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:275:45 [INFO] [stderr] | [INFO] [stderr] 275 | let dst_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:302:45 [INFO] [stderr] | [INFO] [stderr] 302 | let src_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:341:45 [INFO] [stderr] | [INFO] [stderr] 341 | reg_num: Some((first_word & 0b111000000000) >> 9), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:361:43 [INFO] [stderr] | [INFO] [stderr] 361 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:364:47 [INFO] [stderr] | [INFO] [stderr] 364 | let first_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:376:45 [INFO] [stderr] | [INFO] [stderr] 376 | reg_num: Some((first_word & 0b111000000000) >> 9), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:379:43 [INFO] [stderr] | [INFO] [stderr] 379 | let direction = (first_word & 0b100000000) >> 8; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:413:43 [INFO] [stderr] | [INFO] [stderr] 413 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:424:45 [INFO] [stderr] | [INFO] [stderr] 424 | let dst_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:452:43 [INFO] [stderr] | [INFO] [stderr] 452 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:455:47 [INFO] [stderr] | [INFO] [stderr] 455 | let first_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:467:45 [INFO] [stderr] | [INFO] [stderr] 467 | reg_num: Some((first_word & 0b111000000000) >> 9), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:470:43 [INFO] [stderr] | [INFO] [stderr] 470 | let direction = (first_word & 0b100000000) >> 8; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:504:43 [INFO] [stderr] | [INFO] [stderr] 504 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:515:45 [INFO] [stderr] | [INFO] [stderr] 515 | let dst_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:543:43 [INFO] [stderr] | [INFO] [stderr] 543 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:546:47 [INFO] [stderr] | [INFO] [stderr] 546 | let first_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:558:45 [INFO] [stderr] | [INFO] [stderr] 558 | reg_num: Some((first_word & 0b111000000000) >> 9), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:578:43 [INFO] [stderr] | [INFO] [stderr] 578 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:581:47 [INFO] [stderr] | [INFO] [stderr] 581 | let first_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:593:45 [INFO] [stderr] | [INFO] [stderr] 593 | reg_num: Some((first_word & 0b111000000000) >> 9), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:596:43 [INFO] [stderr] | [INFO] [stderr] 596 | let direction = (first_word & 0b100000000) >> 8; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:630:43 [INFO] [stderr] | [INFO] [stderr] 630 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:633:47 [INFO] [stderr] | [INFO] [stderr] 633 | let first_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:645:45 [INFO] [stderr] | [INFO] [stderr] 645 | reg_num: Some((first_word & 0b111000000000) >> 9), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:648:43 [INFO] [stderr] | [INFO] [stderr] 648 | let direction = (first_word & 0b100000000) >> 8; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:682:43 [INFO] [stderr] | [INFO] [stderr] 682 | let size_bits = (first_word & 0b11000000000000) >> 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b11_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:685:45 [INFO] [stderr] | [INFO] [stderr] 685 | let src_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:695:46 [INFO] [stderr] | [INFO] [stderr] 695 | let dst_mode_reg = (first_word & 0b111000000000) >> 9; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:696:45 [INFO] [stderr] | [INFO] [stderr] 696 | let dst_mode_ea = (first_word & 0b111000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:757:47 [INFO] [stderr] | [INFO] [stderr] 757 | let first_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:825:45 [INFO] [stderr] | [INFO] [stderr] 825 | let dst_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:852:45 [INFO] [stderr] | [INFO] [stderr] 852 | let dst_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/opcodes/mod.rs:1037:14 [INFO] [stderr] | [INFO] [stderr] 1037 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 1038 | | if low_byte >> 7 == 1 { [INFO] [stderr] 1039 | | (0x100 - low_byte) as i64 * -1 [INFO] [stderr] 1040 | | } [INFO] [stderr] ... | [INFO] [stderr] 1043 | | } [INFO] [stderr] 1044 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1037 | else if low_byte >> 7 == 1 { [INFO] [stderr] 1038 | (0x100 - low_byte) as i64 * -1 [INFO] [stderr] 1039 | } [INFO] [stderr] 1040 | else { [INFO] [stderr] 1041 | low_byte as i64 [INFO] [stderr] 1042 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:1031:18 [INFO] [stderr] | [INFO] [stderr] 1031 | (0x100000000 - (long as i64)) * -1 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/opcodes/mod.rs:1191:4 [INFO] [stderr] | [INFO] [stderr] 1191 | x [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/opcodes/mod.rs:1190:12 [INFO] [stderr] | [INFO] [stderr] 1190 | let x = (x & 0x00FF) << 8 | (x & 0xFF00) >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `DrawingArea` [INFO] [stderr] --> src/ui/mod.rs:9:34 [INFO] [stderr] | [INFO] [stderr] 9 | use gtk::{Window, Button, Label, DrawingArea}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `gdk::ContextExt` [INFO] [stderr] --> src/ui/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use gdk::ContextExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gdk_pixbuf::Pixbuf` [INFO] [stderr] --> src/ui/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use gdk_pixbuf::Pixbuf; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/console/mod.rs:168:61 [INFO] [stderr] | [INFO] [stderr] 168 | (word as u32) + 0xFFFF0000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/console/mod.rs:186:61 [INFO] [stderr] | [INFO] [stderr] 186 | (word as u32) + 0xFFFF0000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ram/mod.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | 0xFFFFFFFF [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:214:43 [INFO] [stderr] | [INFO] [stderr] 214 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:217:45 [INFO] [stderr] | [INFO] [stderr] 217 | let dst_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:243:43 [INFO] [stderr] | [INFO] [stderr] 243 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:246:45 [INFO] [stderr] | [INFO] [stderr] 246 | let dst_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:272:43 [INFO] [stderr] | [INFO] [stderr] 272 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:275:45 [INFO] [stderr] | [INFO] [stderr] 275 | let dst_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:302:45 [INFO] [stderr] | [INFO] [stderr] 302 | let src_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:341:45 [INFO] [stderr] | [INFO] [stderr] 341 | reg_num: Some((first_word & 0b111000000000) >> 9), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:361:43 [INFO] [stderr] | [INFO] [stderr] 361 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:364:47 [INFO] [stderr] | [INFO] [stderr] 364 | let first_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:376:45 [INFO] [stderr] | [INFO] [stderr] 376 | reg_num: Some((first_word & 0b111000000000) >> 9), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:379:43 [INFO] [stderr] | [INFO] [stderr] 379 | let direction = (first_word & 0b100000000) >> 8; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:413:43 [INFO] [stderr] | [INFO] [stderr] 413 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:424:45 [INFO] [stderr] | [INFO] [stderr] 424 | let dst_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:452:43 [INFO] [stderr] | [INFO] [stderr] 452 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:455:47 [INFO] [stderr] | [INFO] [stderr] 455 | let first_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:467:45 [INFO] [stderr] | [INFO] [stderr] 467 | reg_num: Some((first_word & 0b111000000000) >> 9), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:470:43 [INFO] [stderr] | [INFO] [stderr] 470 | let direction = (first_word & 0b100000000) >> 8; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:504:43 [INFO] [stderr] | [INFO] [stderr] 504 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:515:45 [INFO] [stderr] | [INFO] [stderr] 515 | let dst_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:543:43 [INFO] [stderr] | [INFO] [stderr] 543 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:546:47 [INFO] [stderr] | [INFO] [stderr] 546 | let first_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:558:45 [INFO] [stderr] | [INFO] [stderr] 558 | reg_num: Some((first_word & 0b111000000000) >> 9), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:578:43 [INFO] [stderr] | [INFO] [stderr] 578 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:581:47 [INFO] [stderr] | [INFO] [stderr] 581 | let first_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:593:45 [INFO] [stderr] | [INFO] [stderr] 593 | reg_num: Some((first_word & 0b111000000000) >> 9), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:596:43 [INFO] [stderr] | [INFO] [stderr] 596 | let direction = (first_word & 0b100000000) >> 8; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:630:43 [INFO] [stderr] | [INFO] [stderr] 630 | let size_bits = (first_word & 0b11000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:633:47 [INFO] [stderr] | [INFO] [stderr] 633 | let first_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:645:45 [INFO] [stderr] | [INFO] [stderr] 645 | reg_num: Some((first_word & 0b111000000000) >> 9), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:648:43 [INFO] [stderr] | [INFO] [stderr] 648 | let direction = (first_word & 0b100000000) >> 8; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:682:43 [INFO] [stderr] | [INFO] [stderr] 682 | let size_bits = (first_word & 0b11000000000000) >> 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b11_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:685:45 [INFO] [stderr] | [INFO] [stderr] 685 | let src_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:695:46 [INFO] [stderr] | [INFO] [stderr] 695 | let dst_mode_reg = (first_word & 0b111000000000) >> 9; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0b1110_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:696:45 [INFO] [stderr] | [INFO] [stderr] 696 | let dst_mode_ea = (first_word & 0b111000000) >> 6; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:757:47 [INFO] [stderr] | [INFO] [stderr] 757 | let first_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:825:45 [INFO] [stderr] | [INFO] [stderr] 825 | let dst_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:852:45 [INFO] [stderr] | [INFO] [stderr] 852 | let dst_mode_ea = (first_word & 0b111000) >> 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/opcodes/mod.rs:1037:14 [INFO] [stderr] | [INFO] [stderr] 1037 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 1038 | | if low_byte >> 7 == 1 { [INFO] [stderr] 1039 | | (0x100 - low_byte) as i64 * -1 [INFO] [stderr] 1040 | | } [INFO] [stderr] ... | [INFO] [stderr] 1043 | | } [INFO] [stderr] 1044 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1037 | else if low_byte >> 7 == 1 { [INFO] [stderr] 1038 | (0x100 - low_byte) as i64 * -1 [INFO] [stderr] 1039 | } [INFO] [stderr] 1040 | else { [INFO] [stderr] 1041 | low_byte as i64 [INFO] [stderr] 1042 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/opcodes/mod.rs:1031:18 [INFO] [stderr] | [INFO] [stderr] 1031 | (0x100000000 - (long as i64)) * -1 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/opcodes/mod.rs:1191:4 [INFO] [stderr] | [INFO] [stderr] 1191 | x [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/opcodes/mod.rs:1190:12 [INFO] [stderr] | [INFO] [stderr] 1190 | let x = (x & 0x00FF) << 8 | (x & 0xFF00) >> 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `DrawingArea` [INFO] [stderr] --> src/ui/mod.rs:9:34 [INFO] [stderr] | [INFO] [stderr] 9 | use gtk::{Window, Button, Label, DrawingArea}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `gdk::ContextExt` [INFO] [stderr] --> src/ui/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use gdk::ContextExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gdk_pixbuf::Pixbuf` [INFO] [stderr] --> src/ui/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use gdk_pixbuf::Pixbuf; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/ram/mod.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn read_long(&self, addr: u32) -> u32 { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/ram/mod.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn read_word(&self, addr: u32) -> u16 { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/ram/mod.rs:28:29 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn read_byte(&self, addr: u32) -> u8 { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/opcodes/mod.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | let mut length = 2usize; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `n_set` [INFO] [stderr] --> src/m68k/mod.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn n_set(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/console/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match opcode.dst_mode.as_ref().unwrap() { [INFO] [stderr] 49 | | &Addr { typ: Mode::AbsLong, .. } => { [INFO] [stderr] 50 | | let mut new_cc = self.m68k.cc & 0b10000; [INFO] [stderr] 51 | | [INFO] [stderr] ... | [INFO] [stderr] 102 | | _ => { eprintln!("TST addr mode not supported"); }, [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *opcode.dst_mode.as_ref().unwrap() { [INFO] [stderr] 49 | Addr { typ: Mode::AbsLong, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/console/mod.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | / match opcode.size.as_ref().unwrap() { [INFO] [stderr] 53 | | &Size::Long => { [INFO] [stderr] 54 | | let value = self.ram.read_long( [INFO] [stderr] 55 | | opcode.dst_value.unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 97 | | }, [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | match *opcode.size.as_ref().unwrap() { [INFO] [stderr] 53 | Size::Long => { [INFO] [stderr] 54 | let value = self.ram.read_long( [INFO] [stderr] 55 | opcode.dst_value.unwrap(), [INFO] [stderr] 56 | ); [INFO] [stderr] 57 | // get msb [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/console/mod.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | / match opcode.src_mode.as_ref().unwrap() { [INFO] [stderr] 111 | | &Addr { typ: Mode::PCIndirectDisplace, .. } => { [INFO] [stderr] 112 | | let addr = (self.m68k.pc as i64 + opcode.src_ext.unwrap().displace) as u32; [INFO] [stderr] 113 | | self.m68k.addr[reg_num as usize] = addr +2; // for size of instruction maybe ?! TODO: confirm behaviour [INFO] [stderr] 114 | | }, [INFO] [stderr] 115 | | _ => { eprintln!("LEA addr mode not supported"); }, [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 110 | match *opcode.src_mode.as_ref().unwrap() { [INFO] [stderr] 111 | Addr { typ: Mode::PCIndirectDisplace, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/console/mod.rs:112:37 [INFO] [stderr] | [INFO] [stderr] 112 | let addr = (self.m68k.pc as i64 + opcode.src_ext.unwrap().displace) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.m68k.pc)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/console/mod.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | / match src_mode { [INFO] [stderr] 146 | | // mem to reg [INFO] [stderr] 147 | | &Addr { typ: Mode::AddrIndirectPostInc, .. } => { [INFO] [stderr] 148 | | let dst_mode = opcode.dst_mode.as_ref().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 207 | | _ => { eprintln!("MOVEM addr mode not supported"); }, [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 145 | match *src_mode { [INFO] [stderr] 146 | // mem to reg [INFO] [stderr] 147 | Addr { typ: Mode::AddrIndirectPostInc, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/console/mod.rs:149:25 [INFO] [stderr] | [INFO] [stderr] 149 | / if let &Mode::MultiRegister((ref addr, ref data)) = &dst_mode.typ { [INFO] [stderr] 150 | | [INFO] [stderr] 151 | | let reg_num = src_mode.reg_num.unwrap(); [INFO] [stderr] 152 | | let op_size = match opcode.size.unwrap() { [INFO] [stderr] ... | [INFO] [stderr] 202 | | self.m68k.addr[reg_num as usize] += inc as u32; [INFO] [stderr] 203 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 149 | if let Mode::MultiRegister((ref addr, ref data)) = dst_mode.typ { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/console/mod.rs:168:45 [INFO] [stderr] | [INFO] [stderr] 168 | (word as u32) + 0xFFFF0000 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/console/mod.rs:171:45 [INFO] [stderr] | [INFO] [stderr] 171 | word as u32 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/console/mod.rs:186:45 [INFO] [stderr] | [INFO] [stderr] 186 | (word as u32) + 0xFFFF0000 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/console/mod.rs:189:45 [INFO] [stderr] | [INFO] [stderr] 189 | word as u32 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/m68k/mod.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | self.pc = (self.pc as i64 + displacement) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(self.pc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/rom/mod.rs:59:44 [INFO] [stderr] | [INFO] [stderr] 59 | .fold(0, |acc, c| (acc << 8) + *c as u32) [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rom/mod.rs:65:44 [INFO] [stderr] | [INFO] [stderr] 65 | .fold(0, |acc, c| (acc << 8) + *c as u16) [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(*c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/opcodes/mod.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / match code { [INFO] [stderr] 39 | | &Code::Bra | &Code::Bsr | &Code::Bhi | &Code::Bls | &Code::Bcc | &Code::Bcs | &Code::Bne | &Code::Beq | &Code::Bvc | &Code::Bvs | &Code::Bpl | &Code::Bmi | &Code::Bge | &Code::Blt | &Code::Bgt | &Code::Ble => true, [INFO] [stderr] 40 | | _ => false, [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | match *code { [INFO] [stderr] 39 | Code::Bra | Code::Bsr | Code::Bhi | Code::Bls | Code::Bcc | Code::Bcs | Code::Bne | Code::Beq | Code::Bvc | Code::Bvs | Code::Bpl | Code::Bmi | Code::Bge | Code::Blt | Code::Bgt | Code::Ble => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 47 [INFO] [stderr] --> src/opcodes/mod.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / pub fn from(cn: &Console, pc: usize) -> Self { [INFO] [stderr] 130 | | let first_word = cn.rom.read_word(pc); [INFO] [stderr] 131 | | let high_byte = first_word & 0xFF00; [INFO] [stderr] 132 | | let high_nybble = first_word & 0xF000; [INFO] [stderr] ... | [INFO] [stderr] 877 | | [INFO] [stderr] 878 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: this `if` has the same condition as a previous if [INFO] [stderr] --> src/opcodes/mod.rs:449:17 [INFO] [stderr] | [INFO] [stderr] 449 | else if high_nybble == 0xC000 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::ifs_same_cond)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/opcodes/mod.rs:358:17 [INFO] [stderr] | [INFO] [stderr] 358 | else if high_nybble == 0xC000 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ifs_same_cond [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:337:34 [INFO] [stderr] | [INFO] [stderr] 337 | let src_value = Some((first_word & 0xFF) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(first_word & 0xFF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:924:22 [INFO] [stderr] | [INFO] [stderr] 924 | Some(cn.rom.read_word(pos) as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(cn.rom.read_word(pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:934:30 [INFO] [stderr] | [INFO] [stderr] 934 | Some(cn.rom.read_word(pos) as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(cn.rom.read_word(pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/opcodes/mod.rs:956:21 [INFO] [stderr] | [INFO] [stderr] 956 | (0x10000 - (word as i64)) * -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:956:32 [INFO] [stderr] | [INFO] [stderr] 956 | (0x10000 - (word as i64)) * -1 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:959:21 [INFO] [stderr] | [INFO] [stderr] 959 | word as i64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:974:32 [INFO] [stderr] | [INFO] [stderr] 974 | let ext_word = cn.rom.read_word(pos) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(cn.rom.read_word(pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:975:32 [INFO] [stderr] | [INFO] [stderr] 975 | let low_byte = (ext_word & 0xFF) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(ext_word & 0xFF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/opcodes/mod.rs:977:21 [INFO] [stderr] | [INFO] [stderr] 977 | (0x100 - low_byte) as i64 * -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/opcodes/mod.rs:1021:17 [INFO] [stderr] | [INFO] [stderr] 1021 | (0x10000 - (word as i64)) * -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:1021:28 [INFO] [stderr] | [INFO] [stderr] 1021 | (0x10000 - (word as i64)) * -1 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:1024:17 [INFO] [stderr] | [INFO] [stderr] 1024 | word as i64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/opcodes/mod.rs:1031:17 [INFO] [stderr] | [INFO] [stderr] 1031 | (0x100000000 - (long as i64)) * -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:1031:32 [INFO] [stderr] | [INFO] [stderr] 1031 | (0x100000000 - (long as i64)) * -1 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(long)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:1034:17 [INFO] [stderr] | [INFO] [stderr] 1034 | long as i64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(long)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/opcodes/mod.rs:1039:17 [INFO] [stderr] | [INFO] [stderr] 1039 | (0x100 - low_byte) as i64 * -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:1039:17 [INFO] [stderr] | [INFO] [stderr] 1039 | (0x100 - low_byte) as i64 * -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(0x100 - low_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:1042:17 [INFO] [stderr] | [INFO] [stderr] 1042 | low_byte as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(low_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/opcodes/mod.rs:1114:36 [INFO] [stderr] | [INFO] [stderr] 1114 | fn format_mode(mode: &Addr, value: &Option, ext: &Option) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ui/mod.rs:88:19 [INFO] [stderr] | [INFO] [stderr] 88 | let num = format!("{}", console.m68k.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `console.m68k.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `truelmao`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/ram/mod.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn read_long(&self, addr: u32) -> u32 { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/ram/mod.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn read_word(&self, addr: u32) -> u16 { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/ram/mod.rs:28:29 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn read_byte(&self, addr: u32) -> u8 { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/opcodes/mod.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | let mut length = 2usize; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `n_set` [INFO] [stderr] --> src/m68k/mod.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn n_set(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/console/mod.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | / match opcode.dst_mode.as_ref().unwrap() { [INFO] [stderr] 49 | | &Addr { typ: Mode::AbsLong, .. } => { [INFO] [stderr] 50 | | let mut new_cc = self.m68k.cc & 0b10000; [INFO] [stderr] 51 | | [INFO] [stderr] ... | [INFO] [stderr] 102 | | _ => { eprintln!("TST addr mode not supported"); }, [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *opcode.dst_mode.as_ref().unwrap() { [INFO] [stderr] 49 | Addr { typ: Mode::AbsLong, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/console/mod.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | / match opcode.size.as_ref().unwrap() { [INFO] [stderr] 53 | | &Size::Long => { [INFO] [stderr] 54 | | let value = self.ram.read_long( [INFO] [stderr] 55 | | opcode.dst_value.unwrap(), [INFO] [stderr] ... | [INFO] [stderr] 97 | | }, [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | match *opcode.size.as_ref().unwrap() { [INFO] [stderr] 53 | Size::Long => { [INFO] [stderr] 54 | let value = self.ram.read_long( [INFO] [stderr] 55 | opcode.dst_value.unwrap(), [INFO] [stderr] 56 | ); [INFO] [stderr] 57 | // get msb [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/console/mod.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | / match opcode.src_mode.as_ref().unwrap() { [INFO] [stderr] 111 | | &Addr { typ: Mode::PCIndirectDisplace, .. } => { [INFO] [stderr] 112 | | let addr = (self.m68k.pc as i64 + opcode.src_ext.unwrap().displace) as u32; [INFO] [stderr] 113 | | self.m68k.addr[reg_num as usize] = addr +2; // for size of instruction maybe ?! TODO: confirm behaviour [INFO] [stderr] 114 | | }, [INFO] [stderr] 115 | | _ => { eprintln!("LEA addr mode not supported"); }, [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 110 | match *opcode.src_mode.as_ref().unwrap() { [INFO] [stderr] 111 | Addr { typ: Mode::PCIndirectDisplace, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/console/mod.rs:112:37 [INFO] [stderr] | [INFO] [stderr] 112 | let addr = (self.m68k.pc as i64 + opcode.src_ext.unwrap().displace) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.m68k.pc)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/console/mod.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | / match src_mode { [INFO] [stderr] 146 | | // mem to reg [INFO] [stderr] 147 | | &Addr { typ: Mode::AddrIndirectPostInc, .. } => { [INFO] [stderr] 148 | | let dst_mode = opcode.dst_mode.as_ref().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 207 | | _ => { eprintln!("MOVEM addr mode not supported"); }, [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 145 | match *src_mode { [INFO] [stderr] 146 | // mem to reg [INFO] [stderr] 147 | Addr { typ: Mode::AddrIndirectPostInc, .. } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/console/mod.rs:149:25 [INFO] [stderr] | [INFO] [stderr] 149 | / if let &Mode::MultiRegister((ref addr, ref data)) = &dst_mode.typ { [INFO] [stderr] 150 | | [INFO] [stderr] 151 | | let reg_num = src_mode.reg_num.unwrap(); [INFO] [stderr] 152 | | let op_size = match opcode.size.unwrap() { [INFO] [stderr] ... | [INFO] [stderr] 202 | | self.m68k.addr[reg_num as usize] += inc as u32; [INFO] [stderr] 203 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 149 | if let Mode::MultiRegister((ref addr, ref data)) = dst_mode.typ { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/console/mod.rs:168:45 [INFO] [stderr] | [INFO] [stderr] 168 | (word as u32) + 0xFFFF0000 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/console/mod.rs:171:45 [INFO] [stderr] | [INFO] [stderr] 171 | word as u32 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/console/mod.rs:186:45 [INFO] [stderr] | [INFO] [stderr] 186 | (word as u32) + 0xFFFF0000 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/console/mod.rs:189:45 [INFO] [stderr] | [INFO] [stderr] 189 | word as u32 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/m68k/mod.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | self.pc = (self.pc as i64 + displacement) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(self.pc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/rom/mod.rs:59:44 [INFO] [stderr] | [INFO] [stderr] 59 | .fold(0, |acc, c| (acc << 8) + *c as u32) [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rom/mod.rs:65:44 [INFO] [stderr] | [INFO] [stderr] 65 | .fold(0, |acc, c| (acc << 8) + *c as u16) [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(*c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/opcodes/mod.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / match code { [INFO] [stderr] 39 | | &Code::Bra | &Code::Bsr | &Code::Bhi | &Code::Bls | &Code::Bcc | &Code::Bcs | &Code::Bne | &Code::Beq | &Code::Bvc | &Code::Bvs | &Code::Bpl | &Code::Bmi | &Code::Bge | &Code::Blt | &Code::Bgt | &Code::Ble => true, [INFO] [stderr] 40 | | _ => false, [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | match *code { [INFO] [stderr] 39 | Code::Bra | Code::Bsr | Code::Bhi | Code::Bls | Code::Bcc | Code::Bcs | Code::Bne | Code::Beq | Code::Bvc | Code::Bvs | Code::Bpl | Code::Bmi | Code::Bge | Code::Blt | Code::Bgt | Code::Ble => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 47 [INFO] [stderr] --> src/opcodes/mod.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / pub fn from(cn: &Console, pc: usize) -> Self { [INFO] [stderr] 130 | | let first_word = cn.rom.read_word(pc); [INFO] [stderr] 131 | | let high_byte = first_word & 0xFF00; [INFO] [stderr] 132 | | let high_nybble = first_word & 0xF000; [INFO] [stderr] ... | [INFO] [stderr] 877 | | [INFO] [stderr] 878 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: this `if` has the same condition as a previous if [INFO] [stderr] --> src/opcodes/mod.rs:449:17 [INFO] [stderr] | [INFO] [stderr] 449 | else if high_nybble == 0xC000 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::ifs_same_cond)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/opcodes/mod.rs:358:17 [INFO] [stderr] | [INFO] [stderr] 358 | else if high_nybble == 0xC000 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ifs_same_cond [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:337:34 [INFO] [stderr] | [INFO] [stderr] 337 | let src_value = Some((first_word & 0xFF) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(first_word & 0xFF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:924:22 [INFO] [stderr] | [INFO] [stderr] 924 | Some(cn.rom.read_word(pos) as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(cn.rom.read_word(pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:934:30 [INFO] [stderr] | [INFO] [stderr] 934 | Some(cn.rom.read_word(pos) as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(cn.rom.read_word(pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/opcodes/mod.rs:956:21 [INFO] [stderr] | [INFO] [stderr] 956 | (0x10000 - (word as i64)) * -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:956:32 [INFO] [stderr] | [INFO] [stderr] 956 | (0x10000 - (word as i64)) * -1 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:959:21 [INFO] [stderr] | [INFO] [stderr] 959 | word as i64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:974:32 [INFO] [stderr] | [INFO] [stderr] 974 | let ext_word = cn.rom.read_word(pos) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(cn.rom.read_word(pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:975:32 [INFO] [stderr] | [INFO] [stderr] 975 | let low_byte = (ext_word & 0xFF) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(ext_word & 0xFF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/opcodes/mod.rs:977:21 [INFO] [stderr] | [INFO] [stderr] 977 | (0x100 - low_byte) as i64 * -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/opcodes/mod.rs:1021:17 [INFO] [stderr] | [INFO] [stderr] 1021 | (0x10000 - (word as i64)) * -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:1021:28 [INFO] [stderr] | [INFO] [stderr] 1021 | (0x10000 - (word as i64)) * -1 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:1024:17 [INFO] [stderr] | [INFO] [stderr] 1024 | word as i64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(word)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/opcodes/mod.rs:1031:17 [INFO] [stderr] | [INFO] [stderr] 1031 | (0x100000000 - (long as i64)) * -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:1031:32 [INFO] [stderr] | [INFO] [stderr] 1031 | (0x100000000 - (long as i64)) * -1 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(long)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:1034:17 [INFO] [stderr] | [INFO] [stderr] 1034 | long as i64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(long)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/opcodes/mod.rs:1039:17 [INFO] [stderr] | [INFO] [stderr] 1039 | (0x100 - low_byte) as i64 * -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:1039:17 [INFO] [stderr] | [INFO] [stderr] 1039 | (0x100 - low_byte) as i64 * -1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(0x100 - low_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/opcodes/mod.rs:1042:17 [INFO] [stderr] | [INFO] [stderr] 1042 | low_byte as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(low_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/opcodes/mod.rs:1114:36 [INFO] [stderr] | [INFO] [stderr] 1114 | fn format_mode(mode: &Addr, value: &Option, ext: &Option) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/ui/mod.rs:88:19 [INFO] [stderr] | [INFO] [stderr] 88 | let num = format!("{}", console.m68k.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `console.m68k.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `truelmao`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c10333b1dd94a6137c15d2d16675ae9e217fc2226514788ada141e912e1413ac"` [INFO] running `"docker" "rm" "-f" "c10333b1dd94a6137c15d2d16675ae9e217fc2226514788ada141e912e1413ac"` [INFO] [stdout] c10333b1dd94a6137c15d2d16675ae9e217fc2226514788ada141e912e1413ac