[INFO] updating cached repository kirhgoff/rust-crawler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kirhgoff/rust-crawler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kirhgoff/rust-crawler" "work/ex/clippy-test-run/sources/stable/gh/kirhgoff/rust-crawler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kirhgoff/rust-crawler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kirhgoff/rust-crawler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirhgoff/rust-crawler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirhgoff/rust-crawler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d22c13b8a85e3de5b572076a4883a5b13e09c7dd [INFO] sha for GitHub repo kirhgoff/rust-crawler: d22c13b8a85e3de5b572076a4883a5b13e09c7dd [INFO] validating manifest of kirhgoff/rust-crawler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kirhgoff/rust-crawler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kirhgoff/rust-crawler [INFO] finished frobbing kirhgoff/rust-crawler [INFO] frobbed toml for kirhgoff/rust-crawler written to work/ex/clippy-test-run/sources/stable/gh/kirhgoff/rust-crawler/Cargo.toml [INFO] started frobbing kirhgoff/rust-crawler [INFO] finished frobbing kirhgoff/rust-crawler [INFO] frobbed toml for kirhgoff/rust-crawler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kirhgoff/rust-crawler/Cargo.toml [INFO] crate kirhgoff/rust-crawler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kirhgoff/rust-crawler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kirhgoff/rust-crawler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4e1d475192e163c3acc841f6c0321c1a0759c19489375ff77fdd8e0fc50f19ed [INFO] running `"docker" "start" "-a" "4e1d475192e163c3acc841f6c0321c1a0759c19489375ff77fdd8e0fc50f19ed"` [INFO] [stderr] Compiling serde v1.0.63 [INFO] [stderr] Checking smallvec v0.3.3 [INFO] [stderr] Compiling phf_shared v0.7.22 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Compiling serde_derive v1.0.63 [INFO] [stderr] Checking openssl v0.9.24 [INFO] [stderr] Checking parking_lot v0.3.8 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking phf v0.7.22 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Compiling string_cache_codegen v0.4.1 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking multiqueue v0.3.2 [INFO] [stderr] Compiling string_cache v0.7.2 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Compiling serde_json v1.0.18 [INFO] [stderr] Compiling markup5ever v0.7.2 [INFO] [stderr] Checking html5ever v0.22.3 [INFO] [stderr] Checking rust-crawler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return String::from_utf8_lossy(&body).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8_lossy(&body).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return links; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `links` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return String::from_utf8_lossy(&body).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8_lossy(&body).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return links; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `links` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:49:11 [INFO] [stderr] | [INFO] [stderr] 49 | while queue.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:100:12 [INFO] [stderr] | [INFO] [stderr] 100 | if !t.join().is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `t.join().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:49:11 [INFO] [stderr] | [INFO] [stderr] 49 | while queue.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:100:12 [INFO] [stderr] | [INFO] [stderr] 100 | if !t.join().is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `t.join().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.17s [INFO] running `"docker" "inspect" "4e1d475192e163c3acc841f6c0321c1a0759c19489375ff77fdd8e0fc50f19ed"` [INFO] running `"docker" "rm" "-f" "4e1d475192e163c3acc841f6c0321c1a0759c19489375ff77fdd8e0fc50f19ed"` [INFO] [stdout] 4e1d475192e163c3acc841f6c0321c1a0759c19489375ff77fdd8e0fc50f19ed