[INFO] updating cached repository kingswanwho/Crawler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kingswanwho/Crawler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kingswanwho/Crawler" "work/ex/clippy-test-run/sources/stable/gh/kingswanwho/Crawler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kingswanwho/Crawler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kingswanwho/Crawler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kingswanwho/Crawler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kingswanwho/Crawler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fbeb2dde9fce41dfa159fb97e898142a99fd7816 [INFO] sha for GitHub repo kingswanwho/Crawler: fbeb2dde9fce41dfa159fb97e898142a99fd7816 [INFO] validating manifest of kingswanwho/Crawler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kingswanwho/Crawler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kingswanwho/Crawler [INFO] finished frobbing kingswanwho/Crawler [INFO] frobbed toml for kingswanwho/Crawler written to work/ex/clippy-test-run/sources/stable/gh/kingswanwho/Crawler/Cargo.toml [INFO] started frobbing kingswanwho/Crawler [INFO] finished frobbing kingswanwho/Crawler [INFO] frobbed toml for kingswanwho/Crawler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kingswanwho/Crawler/Cargo.toml [INFO] crate kingswanwho/Crawler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kingswanwho/Crawler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kingswanwho/Crawler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1cc26dbcbd863af04bee22455a0003e37149af0cbdff94c2d84dd1be4eeb8fa8 [INFO] running `"docker" "start" "-a" "1cc26dbcbd863af04bee22455a0003e37149af0cbdff94c2d84dd1be4eeb8fa8"` [INFO] [stderr] Compiling gcc v0.3.47 [INFO] [stderr] Compiling string_cache v0.2.29 [INFO] [stderr] Compiling html5ever v0.5.4 [INFO] [stderr] Checking tendril v0.2.4 [INFO] [stderr] Checking hyper v0.10.10 [INFO] [stderr] Compiling openssl-sys v0.9.12 [INFO] [stderr] Compiling backtrace-sys v0.1.11 [INFO] [stderr] Compiling openssl v0.9.12 [INFO] [stderr] Checking native-tls v0.1.2 [INFO] [stderr] Checking select v0.3.0 [INFO] [stderr] Checking hyper-native-tls v0.2.2 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking error-chain v0.8.1 [INFO] [stderr] Checking bb v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/crawler.rs:33:4 [INFO] [stderr] | [INFO] [stderr] 33 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/crawler_set.rs:29:4 [INFO] [stderr] | [INFO] [stderr] 29 | set: set, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/crawler.rs:33:4 [INFO] [stderr] | [INFO] [stderr] 33 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/crawler_set.rs:29:4 [INFO] [stderr] | [INFO] [stderr] 29 | set: set, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/crawler.rs:37:3 [INFO] [stderr] | [INFO] [stderr] 37 | crawler [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/crawler.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let crawler = Crawler { [INFO] [stderr] | _______________________^ [INFO] [stderr] 33 | | client: client, [INFO] [stderr] 34 | | bank: Arc::new(Mutex::new(bank)), [INFO] [stderr] 35 | | queue: Arc::new(Mutex::new(deque)), [INFO] [stderr] 36 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sync_pop_url` [INFO] [stderr] --> src/function.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn sync_pop_url(queue: &Arc>>) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `check_empty` [INFO] [stderr] --> src/crawler.rs:58:2 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn check_empty(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `pop` [INFO] [stderr] --> src/crawler.rs:63:2 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn pop(&self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `push` [INFO] [stderr] --> src/crawler.rs:67:2 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn push(&self, url: Url) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/function.rs:63:8 [INFO] [stderr] | [INFO] [stderr] 63 | Err(_) => panic!("Panic!: The argument is not an url!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/function.rs:119:3 [INFO] [stderr] | [INFO] [stderr] 119 | Err(_) => panic!("Panic!: NativeTlsClient get some problems!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/crawler.rs:94:4 [INFO] [stderr] | [INFO] [stderr] 94 | Err(_) => panic!("Cannot send the result to channel!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/crawler_set.rs:85:4 [INFO] [stderr] | [INFO] [stderr] 85 | Err(_) => panic!("The argument is not an absolute url!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/crawler.rs:37:3 [INFO] [stderr] | [INFO] [stderr] 37 | crawler [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/crawler.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let crawler = Crawler { [INFO] [stderr] | _______________________^ [INFO] [stderr] 33 | | client: client, [INFO] [stderr] 34 | | bank: Arc::new(Mutex::new(bank)), [INFO] [stderr] 35 | | queue: Arc::new(Mutex::new(deque)), [INFO] [stderr] 36 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/function.rs:63:8 [INFO] [stderr] | [INFO] [stderr] 63 | Err(_) => panic!("Panic!: The argument is not an url!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/function.rs:119:3 [INFO] [stderr] | [INFO] [stderr] 119 | Err(_) => panic!("Panic!: NativeTlsClient get some problems!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/crawler.rs:94:4 [INFO] [stderr] | [INFO] [stderr] 94 | Err(_) => panic!("Cannot send the result to channel!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/crawler_set.rs:85:4 [INFO] [stderr] | [INFO] [stderr] 85 | Err(_) => panic!("The argument is not an absolute url!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 29.66s [INFO] running `"docker" "inspect" "1cc26dbcbd863af04bee22455a0003e37149af0cbdff94c2d84dd1be4eeb8fa8"` [INFO] running `"docker" "rm" "-f" "1cc26dbcbd863af04bee22455a0003e37149af0cbdff94c2d84dd1be4eeb8fa8"` [INFO] [stdout] 1cc26dbcbd863af04bee22455a0003e37149af0cbdff94c2d84dd1be4eeb8fa8