[INFO] updating cached repository kimrutherford/pombase_rc_string [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kimrutherford/pombase_rc_string [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kimrutherford/pombase_rc_string" "work/ex/clippy-test-run/sources/stable/gh/kimrutherford/pombase_rc_string"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kimrutherford/pombase_rc_string'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kimrutherford/pombase_rc_string" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kimrutherford/pombase_rc_string"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kimrutherford/pombase_rc_string'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cabbbc21a834a7b23adb5552fab390db75310568 [INFO] sha for GitHub repo kimrutherford/pombase_rc_string: cabbbc21a834a7b23adb5552fab390db75310568 [INFO] validating manifest of kimrutherford/pombase_rc_string on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kimrutherford/pombase_rc_string on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kimrutherford/pombase_rc_string [INFO] finished frobbing kimrutherford/pombase_rc_string [INFO] frobbed toml for kimrutherford/pombase_rc_string written to work/ex/clippy-test-run/sources/stable/gh/kimrutherford/pombase_rc_string/Cargo.toml [INFO] started frobbing kimrutherford/pombase_rc_string [INFO] finished frobbing kimrutherford/pombase_rc_string [INFO] frobbed toml for kimrutherford/pombase_rc_string written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kimrutherford/pombase_rc_string/Cargo.toml [INFO] crate kimrutherford/pombase_rc_string has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kimrutherford/pombase_rc_string against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kimrutherford/pombase_rc_string:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0ee2c899fbbabafdf4fcf3a8a4a987aeb38ed87a936879e22db8829f36c63548 [INFO] running `"docker" "start" "-a" "0ee2c899fbbabafdf4fcf3a8a4a987aeb38ed87a936879e22db8829f36c63548"` [INFO] [stderr] Checking weak-table v0.2.3 [INFO] [stderr] Checking serde_json v1.0.26 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling serde_derive v1.0.75 [INFO] [stderr] Checking pombase_rc_string v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `RcString` [INFO] [stderr] --> src/lib.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> RcString { [INFO] [stderr] 34 | | RcString::from("") [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `RcString` [INFO] [stderr] --> src/lib.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> RcString { [INFO] [stderr] 34 | | RcString::from("") [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/test.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | assert_eq!(deserialized_map.field.get(&RcString::from("key")).unwrap().field1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&deserialized_map.field[&RcString::from("key")]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.82s [INFO] running `"docker" "inspect" "0ee2c899fbbabafdf4fcf3a8a4a987aeb38ed87a936879e22db8829f36c63548"` [INFO] running `"docker" "rm" "-f" "0ee2c899fbbabafdf4fcf3a8a4a987aeb38ed87a936879e22db8829f36c63548"` [INFO] [stdout] 0ee2c899fbbabafdf4fcf3a8a4a987aeb38ed87a936879e22db8829f36c63548