[INFO] updating cached repository kimond/rust_cmustify [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kimond/rust_cmustify [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kimond/rust_cmustify" "work/ex/clippy-test-run/sources/stable/gh/kimond/rust_cmustify"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kimond/rust_cmustify'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kimond/rust_cmustify" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kimond/rust_cmustify"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kimond/rust_cmustify'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 39e37a8307c39a623c698c4bbaa040a1955a6b89 [INFO] sha for GitHub repo kimond/rust_cmustify: 39e37a8307c39a623c698c4bbaa040a1955a6b89 [INFO] validating manifest of kimond/rust_cmustify on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kimond/rust_cmustify on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kimond/rust_cmustify [INFO] finished frobbing kimond/rust_cmustify [INFO] frobbed toml for kimond/rust_cmustify written to work/ex/clippy-test-run/sources/stable/gh/kimond/rust_cmustify/Cargo.toml [INFO] started frobbing kimond/rust_cmustify [INFO] finished frobbing kimond/rust_cmustify [INFO] frobbed toml for kimond/rust_cmustify written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kimond/rust_cmustify/Cargo.toml [INFO] crate kimond/rust_cmustify has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kimond/rust_cmustify against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kimond/rust_cmustify:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 21bd08383bd2b6b0c39430ef5ce126e6826ba190f93839f5e02a1b05176f5538 [INFO] running `"docker" "start" "-a" "21bd08383bd2b6b0c39430ef5ce126e6826ba190f93839f5e02a1b05176f5538"` [INFO] [stderr] Checking backtrace-sys v0.1.16 [INFO] [stderr] Checking dbus v0.4.1 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] warning: redundant linker flag specified for library `dbus-1` [INFO] [stderr] [INFO] [stderr] Checking notify-rust v3.4.2 [INFO] [stderr] Checking cmustify v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:18:53 [INFO] [stderr] | [INFO] [stderr] 18 | let mut split_data: Vec<&str> = cmus_data.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | if value_collector.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value_collector.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:18:53 [INFO] [stderr] | [INFO] [stderr] 18 | let mut split_data: Vec<&str> = cmus_data.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | if value_collector.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value_collector.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | assert_eq!(result.get("artist").unwrap(), "Todd"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result["artist"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(result.get("album").unwrap(), "Reno"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result["album"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | assert_eq!(result.get("title").unwrap(), "super song"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result["title"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.59s [INFO] running `"docker" "inspect" "21bd08383bd2b6b0c39430ef5ce126e6826ba190f93839f5e02a1b05176f5538"` [INFO] running `"docker" "rm" "-f" "21bd08383bd2b6b0c39430ef5ce126e6826ba190f93839f5e02a1b05176f5538"` [INFO] [stdout] 21bd08383bd2b6b0c39430ef5ce126e6826ba190f93839f5e02a1b05176f5538