[INFO] updating cached repository kigawas/examples-in-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kigawas/examples-in-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kigawas/examples-in-rust" "work/ex/clippy-test-run/sources/stable/gh/kigawas/examples-in-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kigawas/examples-in-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kigawas/examples-in-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kigawas/examples-in-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kigawas/examples-in-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bc0ce30ca9ac369134ece5875ff23d60edc51da7 [INFO] sha for GitHub repo kigawas/examples-in-rust: bc0ce30ca9ac369134ece5875ff23d60edc51da7 [INFO] validating manifest of kigawas/examples-in-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kigawas/examples-in-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kigawas/examples-in-rust [INFO] finished frobbing kigawas/examples-in-rust [INFO] frobbed toml for kigawas/examples-in-rust written to work/ex/clippy-test-run/sources/stable/gh/kigawas/examples-in-rust/Cargo.toml [INFO] started frobbing kigawas/examples-in-rust [INFO] finished frobbing kigawas/examples-in-rust [INFO] frobbed toml for kigawas/examples-in-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kigawas/examples-in-rust/Cargo.toml [INFO] crate kigawas/examples-in-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kigawas/examples-in-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kigawas/examples-in-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 818da5884357f9b3151ba73e2fa1695e03a19d8da870c34f5f60c49c16390992 [INFO] running `"docker" "start" "-a" "818da5884357f9b3151ba73e2fa1695e03a19d8da870c34f5f60c49c16390992"` [INFO] [stderr] Checking examples-in-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | println!("{} days", 31); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:41:52 [INFO] [stderr] | [INFO] [stderr] 41 | println!("{0}, this is {1}. {1}, this is {0}", "Alice", "Bob"); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:41:61 [INFO] [stderr] | [INFO] [stderr] 41 | println!("{0}, this is {1}. {1}, this is {0}", "Alice", "Bob"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | object = "the lazy dog", [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | subject = "the quick brown fox", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | verb = "jumps over" [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | 1, 2 [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:66:41 [INFO] [stderr] | [INFO] [stderr] 66 | println!("My name is {0}, {1} {0}", "Bond", "James"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:66:49 [INFO] [stderr] | [INFO] [stderr] 66 | println!("My name is {0}, {1} {0}", "Bond", "James"); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chap10/mod.rs:126:25 [INFO] [stderr] | [INFO] [stderr] 126 | ClosedBox { contents: contents } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chap16/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap2/mod.rs:49:46 [INFO] [stderr] | [INFO] [stderr] 49 | println!("One million is written as {}", 1_000_000u32); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/chap5/mod.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | let f = 1.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chap9/mod.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chap9/mod.rs:56:27 [INFO] [stderr] | [INFO] [stderr] 56 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | println!("{} days", 31); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:41:52 [INFO] [stderr] | [INFO] [stderr] 41 | println!("{0}, this is {1}. {1}, this is {0}", "Alice", "Bob"); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:41:61 [INFO] [stderr] | [INFO] [stderr] 41 | println!("{0}, this is {1}. {1}, this is {0}", "Alice", "Bob"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | object = "the lazy dog", [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | subject = "the quick brown fox", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | verb = "jumps over" [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | 1, 2 [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:66:41 [INFO] [stderr] | [INFO] [stderr] 66 | println!("My name is {0}, {1} {0}", "Bond", "James"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap1/mod.rs:66:49 [INFO] [stderr] | [INFO] [stderr] 66 | println!("My name is {0}, {1} {0}", "Bond", "James"); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chap10/mod.rs:126:25 [INFO] [stderr] | [INFO] [stderr] 126 | ClosedBox { contents: contents } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chap16/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/chap2/mod.rs:49:46 [INFO] [stderr] | [INFO] [stderr] 49 | println!("One million is written as {}", 1_000_000u32); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/chap5/mod.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | let f = 1.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chap9/mod.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chap9/mod.rs:56:27 [INFO] [stderr] | [INFO] [stderr] 56 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chap1/mod.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | let pi = 3.1415926; [INFO] [stderr] | ^^^^^^^^^ help: consider: `3.141_592_6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chap1/mod.rs:288:18 [INFO] [stderr] | [INFO] [stderr] 288 | lat: 53.347778, [INFO] [stderr] | ^^^^^^^^^ help: consider: `53.347_778` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chap1/mod.rs:289:19 [INFO] [stderr] | [INFO] [stderr] 289 | lon: -6.259722, [INFO] [stderr] | ^^^^^^^^ help: consider: `6.259_722` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/chap15/mod.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | y: _, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Point { x: ref ref_to_x, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/chap15/mod.rs:302:13 [INFO] [stderr] | [INFO] [stderr] 302 | x: _, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Point { y: ref mut mut_ref_to_y, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chap2/mod.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | inferred_type = 4294967296i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `4_294_967_296i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chap2/mod.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | return Matrix(self.0, self.2, self.1, self.3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Matrix(self.0, self.2, self.1, self.3)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chap3/mod.rs:195:15 [INFO] [stderr] | [INFO] [stderr] 195 | Red = 0xff0000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chap3/mod.rs:196:17 [INFO] [stderr] | [INFO] [stderr] 196 | Green = 0x00ff00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chap3/mod.rs:197:16 [INFO] [stderr] | [INFO] [stderr] 197 | Blue = 0x0000ff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/chap9/mod.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | fn fizzbuzz(n: u32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chap1/mod.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | let pi = 3.1415926; [INFO] [stderr] | ^^^^^^^^^ help: consider: `3.141_592_6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chap1/mod.rs:288:18 [INFO] [stderr] | [INFO] [stderr] 288 | lat: 53.347778, [INFO] [stderr] | ^^^^^^^^^ help: consider: `53.347_778` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chap1/mod.rs:289:19 [INFO] [stderr] | [INFO] [stderr] 289 | lon: -6.259722, [INFO] [stderr] | ^^^^^^^^ help: consider: `6.259_722` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/chap15/mod.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | y: _, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Point { x: ref ref_to_x, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/chap15/mod.rs:302:13 [INFO] [stderr] | [INFO] [stderr] 302 | x: _, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Point { y: ref mut mut_ref_to_y, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chap2/mod.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | inferred_type = 4294967296i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `4_294_967_296i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chap2/mod.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | return Matrix(self.0, self.2, self.1, self.3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Matrix(self.0, self.2, self.1, self.3)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chap3/mod.rs:195:15 [INFO] [stderr] | [INFO] [stderr] 195 | Red = 0xff0000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chap3/mod.rs:196:17 [INFO] [stderr] | [INFO] [stderr] 196 | Green = 0x00ff00, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chap3/mod.rs:197:16 [INFO] [stderr] | [INFO] [stderr] 197 | Blue = 0x0000ff, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/chap9/mod.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | fn fizzbuzz(n: u32) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/chap1/mod.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | let pi = 3.1415926; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/chap1/mod.rs:288:18 [INFO] [stderr] | [INFO] [stderr] 288 | lat: 53.347778, [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `53.347_78` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:109:33 [INFO] [stderr] | [INFO] [stderr] 109 | fn borrow_i32(borrowed_i32: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/chap15/mod.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | let ref ref_c1 = c; [INFO] [stderr] | ----^^^^^^^^^^----- help: try: `let ref_c1 = &c;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:358:5 [INFO] [stderr] | [INFO] [stderr] 358 | / fn print_refs<'a, 'b>(x: &'a i32, y: &'b i32) { [INFO] [stderr] 359 | | println!("x is {} and y is {}", x, y); [INFO] [stderr] 360 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:358:30 [INFO] [stderr] | [INFO] [stderr] 358 | fn print_refs<'a, 'b>(x: &'a i32, y: &'b i32) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:358:42 [INFO] [stderr] | [INFO] [stderr] 358 | fn print_refs<'a, 'b>(x: &'a i32, y: &'b i32) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/chap15/mod.rs:363:22 [INFO] [stderr] | [INFO] [stderr] 363 | fn failed_borrow<'a>() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / fn print_one<'a>(x: &'a i32) { [INFO] [stderr] 391 | | println!("`print_one`: x is {}", x); [INFO] [stderr] 392 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:390:25 [INFO] [stderr] | [INFO] [stderr] 390 | fn print_one<'a>(x: &'a i32) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:395:5 [INFO] [stderr] | [INFO] [stderr] 395 | / fn add_one<'a>(x: &'a mut i32) { [INFO] [stderr] 396 | | *x += 1; [INFO] [stderr] 397 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:402:5 [INFO] [stderr] | [INFO] [stderr] 402 | / fn print_multi<'a, 'b>(x: &'a i32, y: &'b i32) { [INFO] [stderr] 403 | | println!("`print_multi`: x is {}, y is {}", x, y); [INFO] [stderr] 404 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:402:31 [INFO] [stderr] | [INFO] [stderr] 402 | fn print_multi<'a, 'b>(x: &'a i32, y: &'b i32) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:402:43 [INFO] [stderr] | [INFO] [stderr] 402 | fn print_multi<'a, 'b>(x: &'a i32, y: &'b i32) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:436:9 [INFO] [stderr] | [INFO] [stderr] 436 | / fn add_one<'a>(&'a mut self) { [INFO] [stderr] 437 | | self.0 += 1; [INFO] [stderr] 438 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:439:9 [INFO] [stderr] | [INFO] [stderr] 439 | / fn print<'a>(&'a self) { [INFO] [stderr] 440 | | println!("`print`: {}", self.0); [INFO] [stderr] 441 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:520:28 [INFO] [stderr] | [INFO] [stderr] 520 | fn multiply<'a>(first: &'a i32, second: &'a i32) -> i32 { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:520:45 [INFO] [stderr] | [INFO] [stderr] 520 | fn multiply<'a>(first: &'a i32, second: &'a i32) -> i32 { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:526:40 [INFO] [stderr] | [INFO] [stderr] 526 | fn choose_first<'a: 'b, 'b>(first: &'a i32, _: &'b i32) -> &'b i32 { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:545:5 [INFO] [stderr] | [INFO] [stderr] 545 | / fn coerce_static<'a>(_: &'a i32) -> &'a i32 { [INFO] [stderr] 546 | | &NUM [INFO] [stderr] 547 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:573:24 [INFO] [stderr] | [INFO] [stderr] 573 | fn elided_input(x: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:577:5 [INFO] [stderr] | [INFO] [stderr] 577 | / fn annotated_input<'a>(x: &'a i32) { [INFO] [stderr] 578 | | println!("`annotated_input`: {}", x); [INFO] [stderr] 579 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:577:31 [INFO] [stderr] | [INFO] [stderr] 577 | fn annotated_input<'a>(x: &'a i32) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/chap1/mod.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | let pi = 3.1415926; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:587:5 [INFO] [stderr] | [INFO] [stderr] 587 | / fn annotated_pass<'a>(x: &'a i32) -> &'a i32 { [INFO] [stderr] 588 | | x [INFO] [stderr] 589 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/chap16/mod.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | Centimeters(inches as f64 * 2.54) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(inches)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/chap1/mod.rs:288:18 [INFO] [stderr] | [INFO] [stderr] 288 | lat: 53.347778, [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `53.347_78` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/chap3/mod.rs:255:20 [INFO] [stderr] | [INFO] [stderr] 255 | Nil => format!("Nil"), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"Nil".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let unit =` [INFO] [stderr] --> src/chap4/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | let unit = (); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:109:33 [INFO] [stderr] | [INFO] [stderr] 109 | fn borrow_i32(borrowed_i32: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/chap7/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | x; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/chap7/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | x + 1; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/chap7/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | 15; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let z =` [INFO] [stderr] --> src/chap7/mod.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / let z = { [INFO] [stderr] 26 | | // The semicolon suppresses this expression and `()` is assigned to `z` [INFO] [stderr] 27 | | 2 * x; [INFO] [stderr] 28 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/chap7/mod.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | 2 * x; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/chap15/mod.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | let ref ref_c1 = c; [INFO] [stderr] | ----^^^^^^^^^^----- help: try: `let ref_c1 = &c;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:358:5 [INFO] [stderr] | [INFO] [stderr] 358 | / fn print_refs<'a, 'b>(x: &'a i32, y: &'b i32) { [INFO] [stderr] 359 | | println!("x is {} and y is {}", x, y); [INFO] [stderr] 360 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:358:30 [INFO] [stderr] | [INFO] [stderr] 358 | fn print_refs<'a, 'b>(x: &'a i32, y: &'b i32) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] warning: unused label `'inner` [INFO] [stderr] | [INFO] [stderr] --> src/chap8/mod.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / 'inner: loop { [INFO] [stderr] 63 | | println!("Entered the inner loop"); [INFO] [stderr] 64 | | [INFO] [stderr] 65 | | // This would break only the inner loop [INFO] [stderr] ... | [INFO] [stderr] 69 | | break 'outer; [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:358:42 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 358 | fn print_refs<'a, 'b>(x: &'a i32, y: &'b i32) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/chap8/mod.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / 'inner: loop { [INFO] [stderr] 63 | | println!("Entered the inner loop"); [INFO] [stderr] 64 | | [INFO] [stderr] 65 | | // This would break only the inner loop [INFO] [stderr] ... | [INFO] [stderr] 69 | | break 'outer; [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/chap15/mod.rs:363:22 [INFO] [stderr] | [INFO] [stderr] 363 | fn failed_borrow<'a>() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / fn print_one<'a>(x: &'a i32) { [INFO] [stderr] 391 | | println!("`print_one`: x is {}", x); [INFO] [stderr] 392 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:390:25 [INFO] [stderr] | [INFO] [stderr] 390 | fn print_one<'a>(x: &'a i32) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:395:5 [INFO] [stderr] | [INFO] [stderr] 395 | / fn add_one<'a>(x: &'a mut i32) { [INFO] [stderr] 396 | | *x += 1; [INFO] [stderr] 397 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:402:5 [INFO] [stderr] | [INFO] [stderr] 402 | / fn print_multi<'a, 'b>(x: &'a i32, y: &'b i32) { [INFO] [stderr] 403 | | println!("`print_multi`: x is {}, y is {}", x, y); [INFO] [stderr] 404 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:402:31 [INFO] [stderr] | [INFO] [stderr] 402 | fn print_multi<'a, 'b>(x: &'a i32, y: &'b i32) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:402:43 [INFO] [stderr] | [INFO] [stderr] 402 | fn print_multi<'a, 'b>(x: &'a i32, y: &'b i32) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:436:9 [INFO] [stderr] | [INFO] [stderr] 436 | / fn add_one<'a>(&'a mut self) { [INFO] [stderr] 437 | | self.0 += 1; [INFO] [stderr] 438 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:439:9 [INFO] [stderr] | [INFO] [stderr] 439 | / fn print<'a>(&'a self) { [INFO] [stderr] 440 | | println!("`print`: {}", self.0); [INFO] [stderr] 441 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/chap8/mod.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / match name { [INFO] [stderr] 146 | | &"Ferris" => println!("There is a rustacean among us!"), [INFO] [stderr] 147 | | _ => println!("Hello {}", name), [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 145 | match *name { [INFO] [stderr] 146 | "Ferris" => println!("There is a rustacean among us!"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/chap8/mod.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | / match name { [INFO] [stderr] 166 | | &mut "Ferris" => { [INFO] [stderr] 167 | | println!("There is a rustacean among us!"); [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | _ => println!("Hello {}", name), [INFO] [stderr] 170 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 165 | match *name { [INFO] [stderr] 166 | "Ferris" => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/chap8/mod.rs:192:18 [INFO] [stderr] | [INFO] [stderr] 192 | let binary = match boolean { [INFO] [stderr] | __________________^ [INFO] [stderr] 193 | | // The arms of a match must cover all the possible values [INFO] [stderr] 194 | | false => 0, [INFO] [stderr] 195 | | true => 1, [INFO] [stderr] 196 | | // TODO ^ Try commenting out one of these arms [INFO] [stderr] 197 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if boolean { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:520:28 [INFO] [stderr] | [INFO] [stderr] 520 | fn multiply<'a>(first: &'a i32, second: &'a i32) -> i32 { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:520:45 [INFO] [stderr] | [INFO] [stderr] 520 | fn multiply<'a>(first: &'a i32, second: &'a i32) -> i32 { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:526:40 [INFO] [stderr] | [INFO] [stderr] 526 | fn choose_first<'a: 'b, 'b>(first: &'a i32, _: &'b i32) -> &'b i32 { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:545:5 [INFO] [stderr] | [INFO] [stderr] 545 | / fn coerce_static<'a>(_: &'a i32) -> &'a i32 { [INFO] [stderr] 546 | | &NUM [INFO] [stderr] 547 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:573:24 [INFO] [stderr] | [INFO] [stderr] 573 | fn elided_input(x: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:577:5 [INFO] [stderr] | [INFO] [stderr] 577 | / fn annotated_input<'a>(x: &'a i32) { [INFO] [stderr] 578 | | println!("`annotated_input`: {}", x); [INFO] [stderr] 579 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chap15/mod.rs:577:31 [INFO] [stderr] | [INFO] [stderr] 577 | fn annotated_input<'a>(x: &'a i32) { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/chap15/mod.rs:587:5 [INFO] [stderr] | [INFO] [stderr] 587 | / fn annotated_pass<'a>(x: &'a i32) -> &'a i32 { [INFO] [stderr] 588 | | x [INFO] [stderr] 589 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/chap8/mod.rs:259:5 [INFO] [stderr] | [INFO] [stderr] 259 | / match reference { [INFO] [stderr] 260 | | // If `reference`s is pattern matched against `&val`, it results [INFO] [stderr] 261 | | // in a comparison like: [INFO] [stderr] 262 | | // `&i32` [INFO] [stderr] ... | [INFO] [stderr] 266 | | &val => println!("Got a value via destructuring: {:?}", val), [INFO] [stderr] 267 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 259 | match *reference { [INFO] [stderr] 260 | // If `reference`s is pattern matched against `&val`, it results [INFO] [stderr] 261 | // in a comparison like: [INFO] [stderr] 262 | // `&i32` [INFO] [stderr] 263 | // `&val` [INFO] [stderr] 264 | // ^ We see that if the matching `&`s are dropped, then the `i32` [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/chap8/mod.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | let ref _is_a_reference = 3; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^----- help: try: `let _is_a_reference = &3;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/chap8/mod.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | let foo = Foo { x: (1, 2), y: 3 }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/chap16/mod.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | Centimeters(inches as f64 * 2.54) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(inches)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/chap9/mod.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | for n in 1..n + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/chap3/mod.rs:255:20 [INFO] [stderr] | [INFO] [stderr] 255 | Nil => format!("Nil"), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"Nil".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: Could not compile `examples-in-rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let unit =` [INFO] [stderr] --> src/chap4/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | let unit = (); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/chap7/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | x; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/chap7/mod.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | x + 1; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/chap7/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | 15; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let z =` [INFO] [stderr] --> src/chap7/mod.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / let z = { [INFO] [stderr] 26 | | // The semicolon suppresses this expression and `()` is assigned to `z` [INFO] [stderr] 27 | | 2 * x; [INFO] [stderr] 28 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/chap7/mod.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | 2 * x; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner` [INFO] [stderr] --> src/chap8/mod.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / 'inner: loop { [INFO] [stderr] 63 | | println!("Entered the inner loop"); [INFO] [stderr] 64 | | [INFO] [stderr] 65 | | // This would break only the inner loop [INFO] [stderr] ... | [INFO] [stderr] 69 | | break 'outer; [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/chap8/mod.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / 'inner: loop { [INFO] [stderr] 63 | | println!("Entered the inner loop"); [INFO] [stderr] 64 | | [INFO] [stderr] 65 | | // This would break only the inner loop [INFO] [stderr] ... | [INFO] [stderr] 69 | | break 'outer; [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/chap8/mod.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | / match name { [INFO] [stderr] 146 | | &"Ferris" => println!("There is a rustacean among us!"), [INFO] [stderr] 147 | | _ => println!("Hello {}", name), [INFO] [stderr] 148 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 145 | match *name { [INFO] [stderr] 146 | "Ferris" => println!("There is a rustacean among us!"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/chap8/mod.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | / match name { [INFO] [stderr] 166 | | &mut "Ferris" => { [INFO] [stderr] 167 | | println!("There is a rustacean among us!"); [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | _ => println!("Hello {}", name), [INFO] [stderr] 170 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 165 | match *name { [INFO] [stderr] 166 | "Ferris" => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/chap8/mod.rs:192:18 [INFO] [stderr] | [INFO] [stderr] 192 | let binary = match boolean { [INFO] [stderr] | __________________^ [INFO] [stderr] 193 | | // The arms of a match must cover all the possible values [INFO] [stderr] 194 | | false => 0, [INFO] [stderr] 195 | | true => 1, [INFO] [stderr] 196 | | // TODO ^ Try commenting out one of these arms [INFO] [stderr] 197 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if boolean { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/chap8/mod.rs:259:5 [INFO] [stderr] | [INFO] [stderr] 259 | / match reference { [INFO] [stderr] 260 | | // If `reference`s is pattern matched against `&val`, it results [INFO] [stderr] 261 | | // in a comparison like: [INFO] [stderr] 262 | | // `&i32` [INFO] [stderr] ... | [INFO] [stderr] 266 | | &val => println!("Got a value via destructuring: {:?}", val), [INFO] [stderr] 267 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 259 | match *reference { [INFO] [stderr] 260 | // If `reference`s is pattern matched against `&val`, it results [INFO] [stderr] 261 | // in a comparison like: [INFO] [stderr] 262 | // `&i32` [INFO] [stderr] 263 | // `&val` [INFO] [stderr] 264 | // ^ We see that if the matching `&`s are dropped, then the `i32` [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/chap8/mod.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | let ref _is_a_reference = 3; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^----- help: try: `let _is_a_reference = &3;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/chap8/mod.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | let foo = Foo { x: (1, 2), y: 3 }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/chap9/mod.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | for n in 1..n + 1 { [INFO] [stderr] | ^^^^^^^^ help: use: `1..=n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `examples-in-rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "818da5884357f9b3151ba73e2fa1695e03a19d8da870c34f5f60c49c16390992"` [INFO] running `"docker" "rm" "-f" "818da5884357f9b3151ba73e2fa1695e03a19d8da870c34f5f60c49c16390992"` [INFO] [stdout] 818da5884357f9b3151ba73e2fa1695e03a19d8da870c34f5f60c49c16390992