[INFO] updating cached repository khionu/CustomRichStatus [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/khionu/CustomRichStatus [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/khionu/CustomRichStatus" "work/ex/clippy-test-run/sources/stable/gh/khionu/CustomRichStatus"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/khionu/CustomRichStatus'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/khionu/CustomRichStatus" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/khionu/CustomRichStatus"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/khionu/CustomRichStatus'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b7dcefd76f1d17ce04662cd351b45c49dbd1f842 [INFO] sha for GitHub repo khionu/CustomRichStatus: b7dcefd76f1d17ce04662cd351b45c49dbd1f842 [INFO] validating manifest of khionu/CustomRichStatus on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of khionu/CustomRichStatus on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing khionu/CustomRichStatus [INFO] finished frobbing khionu/CustomRichStatus [INFO] frobbed toml for khionu/CustomRichStatus written to work/ex/clippy-test-run/sources/stable/gh/khionu/CustomRichStatus/Cargo.toml [INFO] started frobbing khionu/CustomRichStatus [INFO] finished frobbing khionu/CustomRichStatus [INFO] frobbed toml for khionu/CustomRichStatus written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/khionu/CustomRichStatus/Cargo.toml [INFO] crate khionu/CustomRichStatus has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting khionu/CustomRichStatus against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/khionu/CustomRichStatus:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f74d37f60db5500cf610b6bd3f238d2ed29987e9dba06ceeabf68d7af28d4fae [INFO] running `"docker" "start" "-a" "f74d37f60db5500cf610b6bd3f238d2ed29987e9dba06ceeabf68d7af28d4fae"` [INFO] [stderr] Checking quoted_strings v0.1.0 [INFO] [stderr] Checking serde_yaml v0.8.2 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling serde_derive v1.0.76 [INFO] [stderr] Checking discord-rpc-client v0.2.3 [INFO] [stderr] Checking custom_rich_status v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/command_engine/engine.rs:55:16 [INFO] [stderr] | [INFO] [stderr] 55 | if let None = sub_name { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 56 | | panic!("DEVELOPER ERROR: CREATED OPTIONS OUTSIDE OF COMMAND") [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________- help: try this: `if sub_name.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/command_engine/engine.rs:55:16 [INFO] [stderr] | [INFO] [stderr] 55 | if let None = sub_name { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 56 | | panic!("DEVELOPER ERROR: CREATED OPTIONS OUTSIDE OF COMMAND") [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________- help: try this: `if sub_name.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/models/dto.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / let mut dto = self.clone(); [INFO] [stderr] 45 | | [INFO] [stderr] 46 | | if matches.is_present("CLEAR") { [INFO] [stderr] 47 | | dto = ActivityDto::default(); [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let dto = if matches.is_present("CLEAR") { ActivityDto::default() } else { self.clone() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/state/meta_data.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | let authors = String::from(PKG_AUTHORS.replace(":", ", ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `PKG_AUTHORS.replace(":", ", ")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/models/dto.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / let mut dto = self.clone(); [INFO] [stderr] 45 | | [INFO] [stderr] 46 | | if matches.is_present("CLEAR") { [INFO] [stderr] 47 | | dto = ActivityDto::default(); [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let dto = if matches.is_present("CLEAR") { ActivityDto::default() } else { self.clone() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/utils/time_diff.rs:14:50 [INFO] [stderr] | [INFO] [stderr] 14 | if segments.iter().any(|s| (*s).len() > 2 || (*s).len() < 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(*s).is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/utils/gnr_error.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | fn cause<'a>(&self) -> Option<&Error> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/state/meta_data.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | let authors = String::from(PKG_AUTHORS.replace(":", ", ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `PKG_AUTHORS.replace(":", ", ")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/utils/time_diff.rs:14:50 [INFO] [stderr] | [INFO] [stderr] 14 | if segments.iter().any(|s| (*s).len() > 2 || (*s).len() < 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(*s).is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:57:28 [INFO] [stderr] | [INFO] [stderr] 57 | current_state: match config.retain_state { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 58 | | true => Some(ActivityDto::default()), [INFO] [stderr] 59 | | false => None, [INFO] [stderr] 60 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if config.retain_state { Some(ActivityDto::default()) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/utils/gnr_error.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | fn cause<'a>(&self) -> Option<&Error> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:57:28 [INFO] [stderr] | [INFO] [stderr] 57 | current_state: match config.retain_state { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 58 | | true => Some(ActivityDto::default()), [INFO] [stderr] 59 | | false => None, [INFO] [stderr] 60 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if config.retain_state { Some(ActivityDto::default()) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.39s [INFO] running `"docker" "inspect" "f74d37f60db5500cf610b6bd3f238d2ed29987e9dba06ceeabf68d7af28d4fae"` [INFO] running `"docker" "rm" "-f" "f74d37f60db5500cf610b6bd3f238d2ed29987e9dba06ceeabf68d7af28d4fae"` [INFO] [stdout] f74d37f60db5500cf610b6bd3f238d2ed29987e9dba06ceeabf68d7af28d4fae