[INFO] updating cached repository khaivubui/rust_hello [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/khaivubui/rust_hello [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/khaivubui/rust_hello" "work/ex/clippy-test-run/sources/stable/gh/khaivubui/rust_hello"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/khaivubui/rust_hello'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/khaivubui/rust_hello" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/khaivubui/rust_hello"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/khaivubui/rust_hello'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 61f381012fc9be0319fcf2d9283d92ca3aa000ec [INFO] sha for GitHub repo khaivubui/rust_hello: 61f381012fc9be0319fcf2d9283d92ca3aa000ec [INFO] validating manifest of khaivubui/rust_hello on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of khaivubui/rust_hello on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing khaivubui/rust_hello [INFO] finished frobbing khaivubui/rust_hello [INFO] frobbed toml for khaivubui/rust_hello written to work/ex/clippy-test-run/sources/stable/gh/khaivubui/rust_hello/Cargo.toml [INFO] started frobbing khaivubui/rust_hello [INFO] finished frobbing khaivubui/rust_hello [INFO] frobbed toml for khaivubui/rust_hello written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/khaivubui/rust_hello/Cargo.toml [INFO] crate khaivubui/rust_hello has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting khaivubui/rust_hello against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/khaivubui/rust_hello:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8def8c56d108e8b629ac838b98bcff3332c3fdee5953d727c8a6a6a103349b6b [INFO] running `"docker" "start" "-a" "8def8c56d108e8b629ac838b98bcff3332c3fdee5953d727c8a6a6a103349b6b"` [INFO] [stderr] Checking hello v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:11:8 [INFO] [stderr] | [INFO] [stderr] 11 | if numbers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `numbers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | writeln!(std::io::stderr(), "Usage: gcd NUMBER ...").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `m` and `n` manually [INFO] [stderr] --> src/main.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / let t = m; [INFO] [stderr] 32 | | m = n; [INFO] [stderr] 33 | | n = t; [INFO] [stderr] | |_________________^ help: try: `std::mem::swap(&mut m, &mut n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | m = m % n; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `m %= n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:11:8 [INFO] [stderr] | [INFO] [stderr] 11 | if numbers.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `numbers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | writeln!(std::io::stderr(), "Usage: gcd NUMBER ...").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `m` and `n` manually [INFO] [stderr] --> src/main.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / let t = m; [INFO] [stderr] 32 | | m = n; [INFO] [stderr] 33 | | n = t; [INFO] [stderr] | |_________________^ help: try: `std::mem::swap(&mut m, &mut n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | m = m % n; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `m %= n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.71s [INFO] running `"docker" "inspect" "8def8c56d108e8b629ac838b98bcff3332c3fdee5953d727c8a6a6a103349b6b"` [INFO] running `"docker" "rm" "-f" "8def8c56d108e8b629ac838b98bcff3332c3fdee5953d727c8a6a6a103349b6b"` [INFO] [stdout] 8def8c56d108e8b629ac838b98bcff3332c3fdee5953d727c8a6a6a103349b6b