[INFO] updating cached repository khaale/logparse [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/khaale/logparse [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/khaale/logparse" "work/ex/clippy-test-run/sources/stable/gh/khaale/logparse"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/khaale/logparse'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/khaale/logparse" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/khaale/logparse"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/khaale/logparse'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0a0e16607bb8b58011a71b4d4567dcbf744b55f8 [INFO] sha for GitHub repo khaale/logparse: 0a0e16607bb8b58011a71b4d4567dcbf744b55f8 [INFO] validating manifest of khaale/logparse on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of khaale/logparse on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing khaale/logparse [INFO] finished frobbing khaale/logparse [INFO] frobbed toml for khaale/logparse written to work/ex/clippy-test-run/sources/stable/gh/khaale/logparse/Cargo.toml [INFO] started frobbing khaale/logparse [INFO] finished frobbing khaale/logparse [INFO] frobbed toml for khaale/logparse written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/khaale/logparse/Cargo.toml [INFO] crate khaale/logparse has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting khaale/logparse against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/khaale/logparse:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9ce3e5699bd935101921de7a65bf43cd82668471d5f8561d6822c05c2900efec [INFO] running `"docker" "start" "-a" "9ce3e5699bd935101921de7a65bf43cd82668471d5f8561d6822c05c2900efec"` [INFO] [stderr] Checking itertools v0.5.10 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking logparse v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | EventReader { source: source } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | EventReader { source: source } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/reader.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | p [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 151 | let mut r = test_data!(r#"Pre-execute package Package"#); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/reader.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | let p = EventReader::new(r); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 151 | let mut r = test_data!(r#"Pre-execute package Package"#); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/reader.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | p [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 158 | let mut r = test_data!(r#"Container Name : Container"#); [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/reader.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | let p = EventReader::new(r); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 158 | let mut r = test_data!(r#"Container Name : Container"#); [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/reader.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | p [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 165 | let mut r = test_data!(r#"2017-04-20T10:53:24.6607935+01:00 PRE EXECUTE Task"#); [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/reader.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | let p = EventReader::new(r); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 165 | let mut r = test_data!(r#"2017-04-20T10:53:24.6607935+01:00 PRE EXECUTE Task"#); [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/reader.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | p [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 172 | let mut r = test_data!(r#"2017-04-20T10:53:24.9420381+01:00 POST EXECUTE Task"#); [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/reader.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | let p = EventReader::new(r); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 172 | let mut r = test_data!(r#"2017-04-20T10:53:24.9420381+01:00 POST EXECUTE Task"#); [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/reader.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | p [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 179 | let mut r = test_data!(" [INFO] [stderr] | _____________________- [INFO] [stderr] 180 | | Start... [INFO] [stderr] 181 | | 2017-04-25T16:43:46.8297379+01:00 PRE EXECUTE Container Start [INFO] [stderr] 182 | | 2017-04-25T16:43:52.3297111+01:00 PRE EXECUTE Package End [INFO] [stderr] ... | [INFO] [stderr] 185 | | End.. [INFO] [stderr] 186 | | "); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/reader.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | let p = EventReader::new(r); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 179 | let mut r = test_data!(" [INFO] [stderr] | _____________________- [INFO] [stderr] 180 | | Start... [INFO] [stderr] 181 | | 2017-04-25T16:43:46.8297379+01:00 PRE EXECUTE Container Start [INFO] [stderr] 182 | | 2017-04-25T16:43:52.3297111+01:00 PRE EXECUTE Package End [INFO] [stderr] ... | [INFO] [stderr] 185 | | End.. [INFO] [stderr] 186 | | "); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/reader.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | p [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 193 | let mut r = test_data!("Start... [INFO] [stderr] | _____________________- [INFO] [stderr] 194 | | Pre-execute package Package [INFO] [stderr] 195 | | 2017-04-20T10:53:24.6607935+01:00 PRE EXECUTE Task [INFO] [stderr] 196 | | 2017-04-20T10:53:24.9420381+01:00 POST EXECUTE Task [INFO] [stderr] 197 | | Container Name : Container [INFO] [stderr] 198 | | End.."); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/reader.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | let p = EventReader::new(r); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 193 | let mut r = test_data!("Start... [INFO] [stderr] | _____________________- [INFO] [stderr] 194 | | Pre-execute package Package [INFO] [stderr] 195 | | 2017-04-20T10:53:24.6607935+01:00 PRE EXECUTE Task [INFO] [stderr] 196 | | 2017-04-20T10:53:24.9420381+01:00 POST EXECUTE Task [INFO] [stderr] 197 | | Container Name : Container [INFO] [stderr] 198 | | End.."); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/reader.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | time: dt.clone() [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*dt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/reader.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | .or(self.handle_log_event(line, &*CONTAINER_NAME_RGX).map(Event::ContainerFinished)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.handle_log_event(line, &*CONTAINER_NAME_RGX).map(Event::ContainerFinished))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/reader.rs:81:22 [INFO] [stderr] | [INFO] [stderr] 81 | .or(self.handle_log_event(line, &*PRE_EXECUTE_PACKAGE_RGX).map(Event::PackageStarted)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.handle_log_event(line, &*PRE_EXECUTE_PACKAGE_RGX).map(Event::PackageStarted))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/reader.rs:86:22 [INFO] [stderr] | [INFO] [stderr] 86 | .or(self.handle_ssis_event(line, &dt, &*POST_EXECUTE_TASK_RGX).map(Event::PostExecuteTask)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.handle_ssis_event(line, &dt, &*POST_EXECUTE_TASK_RGX).map(Event::PostExecuteTask))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/reader.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | .or(self.handle_ssis_event(line, &dt, &*PRE_EXECUTE_TASK_RGX).map(Event::PreExecuteTask)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.handle_ssis_event(line, &dt, &*PRE_EXECUTE_TASK_RGX).map(Event::PreExecuteTask))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/model.rs:76:12 [INFO] [stderr] | [INFO] [stderr] 76 | if self.packages.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.packages.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | start_time: evt.time.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `evt.time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:98:27 [INFO] [stderr] | [INFO] [stderr] 98 | fn get_leaf_tasks(tasks : &Vec) -> Vec<&Task> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Task]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/reader.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | time: dt.clone() [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*dt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/reader.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | .or(self.handle_log_event(line, &*CONTAINER_NAME_RGX).map(Event::ContainerFinished)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.handle_log_event(line, &*CONTAINER_NAME_RGX).map(Event::ContainerFinished))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/reader.rs:81:22 [INFO] [stderr] | [INFO] [stderr] 81 | .or(self.handle_log_event(line, &*PRE_EXECUTE_PACKAGE_RGX).map(Event::PackageStarted)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.handle_log_event(line, &*PRE_EXECUTE_PACKAGE_RGX).map(Event::PackageStarted))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/reader.rs:86:22 [INFO] [stderr] | [INFO] [stderr] 86 | .or(self.handle_ssis_event(line, &dt, &*POST_EXECUTE_TASK_RGX).map(Event::PostExecuteTask)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.handle_ssis_event(line, &dt, &*POST_EXECUTE_TASK_RGX).map(Event::PostExecuteTask))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/reader.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | .or(self.handle_ssis_event(line, &dt, &*PRE_EXECUTE_TASK_RGX).map(Event::PreExecuteTask)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.handle_ssis_event(line, &dt, &*PRE_EXECUTE_TASK_RGX).map(Event::PreExecuteTask))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/model.rs:76:12 [INFO] [stderr] | [INFO] [stderr] 76 | if self.packages.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.packages.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/model.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | start_time: evt.time.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `evt.time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/model.rs:221:28 [INFO] [stderr] | [INFO] [stderr] 221 | let actual_task1 = tasks.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tasks[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/model.rs:223:28 [INFO] [stderr] | [INFO] [stderr] 223 | let actual_task2 = tasks.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tasks[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/model.rs:245:28 [INFO] [stderr] | [INFO] [stderr] 245 | let actual_task1 = tasks.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tasks[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/model.rs:248:28 [INFO] [stderr] | [INFO] [stderr] 248 | let actual_task2 = actual_task1.tasks.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&actual_task1.tasks[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:98:27 [INFO] [stderr] | [INFO] [stderr] 98 | fn get_leaf_tasks(tasks : &Vec) -> Vec<&Task> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Task]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.03s [INFO] running `"docker" "inspect" "9ce3e5699bd935101921de7a65bf43cd82668471d5f8561d6822c05c2900efec"` [INFO] running `"docker" "rm" "-f" "9ce3e5699bd935101921de7a65bf43cd82668471d5f8561d6822c05c2900efec"` [INFO] [stdout] 9ce3e5699bd935101921de7a65bf43cd82668471d5f8561d6822c05c2900efec