[INFO] updating cached repository kgtkr/op_abstraction [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kgtkr/op_abstraction [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kgtkr/op_abstraction" "work/ex/clippy-test-run/sources/stable/gh/kgtkr/op_abstraction"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kgtkr/op_abstraction'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kgtkr/op_abstraction" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kgtkr/op_abstraction"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kgtkr/op_abstraction'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9ce8b6763ea8f6a7ea3af47efb12a5cdc92ef059 [INFO] sha for GitHub repo kgtkr/op_abstraction: 9ce8b6763ea8f6a7ea3af47efb12a5cdc92ef059 [INFO] validating manifest of kgtkr/op_abstraction on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kgtkr/op_abstraction on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kgtkr/op_abstraction [INFO] finished frobbing kgtkr/op_abstraction [INFO] frobbed toml for kgtkr/op_abstraction written to work/ex/clippy-test-run/sources/stable/gh/kgtkr/op_abstraction/Cargo.toml [INFO] started frobbing kgtkr/op_abstraction [INFO] finished frobbing kgtkr/op_abstraction [INFO] frobbed toml for kgtkr/op_abstraction written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kgtkr/op_abstraction/Cargo.toml [INFO] crate kgtkr/op_abstraction has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kgtkr/op_abstraction against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kgtkr/op_abstraction:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c5648a27ec132547e6dde443896465f2fbdaa1b2b1c2cbc5d843987de513e6b [INFO] running `"docker" "start" "-a" "4c5648a27ec132547e6dde443896465f2fbdaa1b2b1c2cbc5d843987de513e6b"` [INFO] [stderr] Checking op_abstraction v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:8:12 [INFO] [stderr] | [INFO] [stderr] 8 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 9 | | if b == 1 { [INFO] [stderr] 10 | | a [INFO] [stderr] 11 | | } else { [INFO] [stderr] 12 | | op(i - 1, a, op(i, a, b - 1)) [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 8 | } else if b == 1 { [INFO] [stderr] 9 | a [INFO] [stderr] 10 | } else { [INFO] [stderr] 11 | op(i - 1, a, op(i, a, b - 1)) [INFO] [stderr] 12 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: function is never used: `op` [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | fn op(i: i32, a: i64, b: i64) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:8:12 [INFO] [stderr] | [INFO] [stderr] 8 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 9 | | if b == 1 { [INFO] [stderr] 10 | | a [INFO] [stderr] 11 | | } else { [INFO] [stderr] 12 | | op(i - 1, a, op(i, a, b - 1)) [INFO] [stderr] 13 | | } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 8 | } else if b == 1 { [INFO] [stderr] 9 | a [INFO] [stderr] 10 | } else { [INFO] [stderr] 11 | op(i - 1, a, op(i, a, b - 1)) [INFO] [stderr] 12 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/main.rs:29:33 [INFO] [stderr] | [INFO] [stderr] 29 | assert_eq!(op(2, 1, 1), 1 * 1); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/main.rs:29:33 [INFO] [stderr] | [INFO] [stderr] 29 | assert_eq!(op(2, 1, 1), 1 * 1); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.58s [INFO] running `"docker" "inspect" "4c5648a27ec132547e6dde443896465f2fbdaa1b2b1c2cbc5d843987de513e6b"` [INFO] running `"docker" "rm" "-f" "4c5648a27ec132547e6dde443896465f2fbdaa1b2b1c2cbc5d843987de513e6b"` [INFO] [stdout] 4c5648a27ec132547e6dde443896465f2fbdaa1b2b1c2cbc5d843987de513e6b