[INFO] updating cached repository kevinmehall/panobubble [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kevinmehall/panobubble [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kevinmehall/panobubble" "work/ex/clippy-test-run/sources/stable/gh/kevinmehall/panobubble"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kevinmehall/panobubble'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kevinmehall/panobubble" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kevinmehall/panobubble"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kevinmehall/panobubble'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 475c0285db8cabf9a704913e4c60a053a25ff21f [INFO] sha for GitHub repo kevinmehall/panobubble: 475c0285db8cabf9a704913e4c60a053a25ff21f [INFO] validating manifest of kevinmehall/panobubble on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kevinmehall/panobubble on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kevinmehall/panobubble [INFO] finished frobbing kevinmehall/panobubble [INFO] frobbed toml for kevinmehall/panobubble written to work/ex/clippy-test-run/sources/stable/gh/kevinmehall/panobubble/Cargo.toml [INFO] started frobbing kevinmehall/panobubble [INFO] finished frobbing kevinmehall/panobubble [INFO] frobbed toml for kevinmehall/panobubble written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kevinmehall/panobubble/Cargo.toml [INFO] crate kevinmehall/panobubble has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting kevinmehall/panobubble against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kevinmehall/panobubble:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89678d978e2d68c87bc6a7b55240ae9d992afa73dfb2c2c9b4aa0ade223cd49d [INFO] running `"docker" "start" "-a" "89678d978e2d68c87bc6a7b55240ae9d992afa73dfb2c2c9b4aa0ade223cd49d"` [INFO] [stderr] Compiling phf_shared v0.7.22 [INFO] [stderr] Compiling x11-dl v2.18.3 [INFO] [stderr] Checking new_debug_unreachable v1.0.1 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Checking wayland-sys v0.20.11 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking wayland-commons v0.20.11 [INFO] [stderr] Compiling string_cache_codegen v0.4.1 [INFO] [stderr] Checking wayland-client v0.20.11 [INFO] [stderr] Compiling string_cache v0.7.3 [INFO] [stderr] Checking wayland-protocols v0.20.11 [INFO] [stderr] Checking elementtree v0.5.0 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking glutin v0.17.0 [INFO] [stderr] Checking glium v0.22.0 [INFO] [stderr] Checking panobubble v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/metadata.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return Err(format!("No XMP found in image")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("No XMP found in image"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/metadata.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | const RDF: &'static str = "http://www.w3.org/1999/02/22-rdf-syntax-ns#"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/metadata.rs:50:19 [INFO] [stderr] | [INFO] [stderr] 50 | const GPANO: &'static str = "http://ns.google.com/photos/1.0/panorama/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/metadata.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return Err(format!("No XMP found in image")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("No XMP found in image"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/metadata.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | const RDF: &'static str = "http://www.w3.org/1999/02/22-rdf-syntax-ns#"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/metadata.rs:50:19 [INFO] [stderr] | [INFO] [stderr] 50 | const GPANO: &'static str = "http://ns.google.com/photos/1.0/panorama/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/metadata.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | return Err(format!("No XMP found in image")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No XMP found in image".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/metadata.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | let elem = elem.ok_or(format!("No GPano Description tag"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("No GPano Description tag"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/metadata.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | let elem = elem.ok_or(format!("No GPano Description tag"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No GPano Description tag".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:20:34 [INFO] [stderr] | [INFO] [stderr] 20 | let image_name = args.get(1).ok_or(format!("Missing argument"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Missing argument"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:20:40 [INFO] [stderr] | [INFO] [stderr] 20 | let image_name = args.get(1).ok_or(format!("Missing argument"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Missing argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | File::open(image_name).unwrap().take(1024*64).read_to_end(&mut buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:60:19 [INFO] [stderr] | [INFO] [stderr] 60 | let program = program!(&display, [INFO] [stderr] | ___________________^ [INFO] [stderr] 61 | | 140 => { [INFO] [stderr] 62 | | vertex: " [INFO] [stderr] 63 | | #version 140 [INFO] [stderr] ... | [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | ).unwrap(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:167:60 [INFO] [stderr] | [INFO] [stderr] 167 | let idle = yaw_rate == 0.0 && pitch_rate == 0.0 && zoom_rate == 1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(zoom_rate - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:167:60 [INFO] [stderr] | [INFO] [stderr] 167 | let idle = yaw_rate == 0.0 && pitch_rate == 0.0 && zoom_rate == 1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:169:35 [INFO] [stderr] | [INFO] [stderr] 169 | let mut ev_handler = |ev| match ev { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 170 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 171 | | [INFO] [stderr] 172 | | glutin::WindowEvent::CloseRequested => closed = true, [INFO] [stderr] ... | [INFO] [stderr] 220 | | _ => (), [INFO] [stderr] 221 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 169 | let mut ev_handler = |ev| if let glutin::Event::WindowEvent { event, .. } = ev { match event { [INFO] [stderr] 170 | [INFO] [stderr] 171 | glutin::WindowEvent::CloseRequested => closed = true, [INFO] [stderr] 172 | glutin::WindowEvent::KeyboardInput { input, .. } => { [INFO] [stderr] 173 | [INFO] [stderr] 174 | let speed = 1.0 / 4.0 / 60.0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:201:38 [INFO] [stderr] | [INFO] [stderr] 201 | position.x / width as f64 * 2.0 - 1.0, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:202:39 [INFO] [stderr] | [INFO] [stderr] 202 | (position.y / height as f64 * 2.0 - 1.0) * (height as f64 / width as f64) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:202:69 [INFO] [stderr] | [INFO] [stderr] 202 | (position.y / height as f64 * 2.0 - 1.0) * (height as f64 / width as f64) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:202:85 [INFO] [stderr] | [INFO] [stderr] 202 | (position.y / height as f64 * 2.0 - 1.0) * (height as f64 / width as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:212:35 [INFO] [stderr] | [INFO] [stderr] 212 | zoom *= 1.0 + y as f64 * 0.08; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `panobubble`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/metadata.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | return Err(format!("No XMP found in image")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No XMP found in image".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/metadata.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | let elem = elem.ok_or(format!("No GPano Description tag"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("No GPano Description tag"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/metadata.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | let elem = elem.ok_or(format!("No GPano Description tag"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"No GPano Description tag".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:20:34 [INFO] [stderr] | [INFO] [stderr] 20 | let image_name = args.get(1).ok_or(format!("Missing argument"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Missing argument"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:20:40 [INFO] [stderr] | [INFO] [stderr] 20 | let image_name = args.get(1).ok_or(format!("Missing argument"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Missing argument".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | File::open(image_name).unwrap().take(1024*64).read_to_end(&mut buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:60:19 [INFO] [stderr] | [INFO] [stderr] 60 | let program = program!(&display, [INFO] [stderr] | ___________________^ [INFO] [stderr] 61 | | 140 => { [INFO] [stderr] 62 | | vertex: " [INFO] [stderr] 63 | | #version 140 [INFO] [stderr] ... | [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | ).unwrap(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:167:60 [INFO] [stderr] | [INFO] [stderr] 167 | let idle = yaw_rate == 0.0 && pitch_rate == 0.0 && zoom_rate == 1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(zoom_rate - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:167:60 [INFO] [stderr] | [INFO] [stderr] 167 | let idle = yaw_rate == 0.0 && pitch_rate == 0.0 && zoom_rate == 1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:169:35 [INFO] [stderr] | [INFO] [stderr] 169 | let mut ev_handler = |ev| match ev { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 170 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 171 | | [INFO] [stderr] 172 | | glutin::WindowEvent::CloseRequested => closed = true, [INFO] [stderr] ... | [INFO] [stderr] 220 | | _ => (), [INFO] [stderr] 221 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 169 | let mut ev_handler = |ev| if let glutin::Event::WindowEvent { event, .. } = ev { match event { [INFO] [stderr] 170 | [INFO] [stderr] 171 | glutin::WindowEvent::CloseRequested => closed = true, [INFO] [stderr] 172 | glutin::WindowEvent::KeyboardInput { input, .. } => { [INFO] [stderr] 173 | [INFO] [stderr] 174 | let speed = 1.0 / 4.0 / 60.0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:201:38 [INFO] [stderr] | [INFO] [stderr] 201 | position.x / width as f64 * 2.0 - 1.0, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:202:39 [INFO] [stderr] | [INFO] [stderr] 202 | (position.y / height as f64 * 2.0 - 1.0) * (height as f64 / width as f64) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:202:69 [INFO] [stderr] | [INFO] [stderr] 202 | (position.y / height as f64 * 2.0 - 1.0) * (height as f64 / width as f64) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:202:85 [INFO] [stderr] | [INFO] [stderr] 202 | (position.y / height as f64 * 2.0 - 1.0) * (height as f64 / width as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:212:35 [INFO] [stderr] | [INFO] [stderr] 212 | zoom *= 1.0 + y as f64 * 0.08; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `panobubble`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "89678d978e2d68c87bc6a7b55240ae9d992afa73dfb2c2c9b4aa0ade223cd49d"` [INFO] running `"docker" "rm" "-f" "89678d978e2d68c87bc6a7b55240ae9d992afa73dfb2c2c9b4aa0ade223cd49d"` [INFO] [stdout] 89678d978e2d68c87bc6a7b55240ae9d992afa73dfb2c2c9b4aa0ade223cd49d