[INFO] updating cached repository kevincharm/ykk [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kevincharm/ykk [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kevincharm/ykk" "work/ex/clippy-test-run/sources/stable/gh/kevincharm/ykk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kevincharm/ykk'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kevincharm/ykk" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kevincharm/ykk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kevincharm/ykk'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eec44397de7bba576301213850b6dd2823084896 [INFO] sha for GitHub repo kevincharm/ykk: eec44397de7bba576301213850b6dd2823084896 [INFO] validating manifest of kevincharm/ykk on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kevincharm/ykk on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kevincharm/ykk [INFO] finished frobbing kevincharm/ykk [INFO] frobbed toml for kevincharm/ykk written to work/ex/clippy-test-run/sources/stable/gh/kevincharm/ykk/Cargo.toml [INFO] started frobbing kevincharm/ykk [INFO] finished frobbing kevincharm/ykk [INFO] frobbed toml for kevincharm/ykk written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kevincharm/ykk/Cargo.toml [INFO] crate kevincharm/ykk has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kevincharm/ykk against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kevincharm/ykk:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f9ae1c5ca3ddf8e822fb7aa204683c1a85f9beb6593f3526371db3be30705a9b [INFO] running `"docker" "start" "-a" "f9ae1c5ca3ddf8e822fb7aa204683c1a85f9beb6593f3526371db3be30705a9b"` [INFO] [stderr] Checking ykk v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser/central_dir_file_header.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | header [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser/central_dir_file_header.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | let header = CentralDirectoryFileHeader { [INFO] [stderr] | __________________^ [INFO] [stderr] 64 | | version, [INFO] [stderr] 65 | | version_needed, [INFO] [stderr] 66 | | flags, [INFO] [stderr] ... | [INFO] [stderr] 82 | | file_comment, [INFO] [stderr] 83 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser/end_of_central_dir_header.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | header [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser/end_of_central_dir_header.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | let header = EndOfCentralDirectoryHeader { [INFO] [stderr] | __________________^ [INFO] [stderr] 33 | | disk_num, [INFO] [stderr] 34 | | disk_num_with_cd, [INFO] [stderr] 35 | | disk_entries, [INFO] [stderr] ... | [INFO] [stderr] 40 | | comment, [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser/local_file_header.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | header [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser/local_file_header.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | let header = LocalFileHeader { [INFO] [stderr] | __________________^ [INFO] [stderr] 61 | | version, [INFO] [stderr] 62 | | flags, [INFO] [stderr] 63 | | compression, [INFO] [stderr] ... | [INFO] [stderr] 74 | | data_descriptor, [INFO] [stderr] 75 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/tag.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | 0x04034b50 => Ok(Magic::LocalFile), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0403_4b50` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/tag.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | 0x02014b50 => Ok(Magic::CentralDirectoryFile), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0201_4b50` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/tag.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | 0x06054b50 => Ok(Magic::EndOfCentralDirectory), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0605_4b50` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser/central_dir_file_header.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | header [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser/central_dir_file_header.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | let header = CentralDirectoryFileHeader { [INFO] [stderr] | __________________^ [INFO] [stderr] 64 | | version, [INFO] [stderr] 65 | | version_needed, [INFO] [stderr] 66 | | flags, [INFO] [stderr] ... | [INFO] [stderr] 82 | | file_comment, [INFO] [stderr] 83 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser/end_of_central_dir_header.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | header [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser/end_of_central_dir_header.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | let header = EndOfCentralDirectoryHeader { [INFO] [stderr] | __________________^ [INFO] [stderr] 33 | | disk_num, [INFO] [stderr] 34 | | disk_num_with_cd, [INFO] [stderr] 35 | | disk_entries, [INFO] [stderr] ... | [INFO] [stderr] 40 | | comment, [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser/local_file_header.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | header [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser/local_file_header.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | let header = LocalFileHeader { [INFO] [stderr] | __________________^ [INFO] [stderr] 61 | | version, [INFO] [stderr] 62 | | flags, [INFO] [stderr] 63 | | compression, [INFO] [stderr] ... | [INFO] [stderr] 74 | | data_descriptor, [INFO] [stderr] 75 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/tag.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | 0x04034b50 => Ok(Magic::LocalFile), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0403_4b50` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/tag.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | 0x02014b50 => Ok(Magic::CentralDirectoryFile), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0201_4b50` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/tag.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | 0x06054b50 => Ok(Magic::EndOfCentralDirectory), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0605_4b50` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser/local_file_header.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / let mut data_descriptor_len = 0; [INFO] [stderr] 52 | | if (flags >> 2) & 0x01 == 1 { [INFO] [stderr] 53 | | data_descriptor_len = 3; [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let data_descriptor_len = if (flags >> 2) & 0x01 == 1 { 3 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/parser/tag.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | Err(_) => panic!("Failed to read next tag!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser/local_file_header.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / let mut data_descriptor_len = 0; [INFO] [stderr] 52 | | if (flags >> 2) & 0x01 == 1 { [INFO] [stderr] 53 | | data_descriptor_len = 3; [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let data_descriptor_len = if (flags >> 2) & 0x01 == 1 { 3 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/parser/tag.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | Err(_) => panic!("Failed to read next tag!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.19s [INFO] running `"docker" "inspect" "f9ae1c5ca3ddf8e822fb7aa204683c1a85f9beb6593f3526371db3be30705a9b"` [INFO] running `"docker" "rm" "-f" "f9ae1c5ca3ddf8e822fb7aa204683c1a85f9beb6593f3526371db3be30705a9b"` [INFO] [stdout] f9ae1c5ca3ddf8e822fb7aa204683c1a85f9beb6593f3526371db3be30705a9b