[INFO] updating cached repository kevbot18/simple-particles [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kevbot18/simple-particles [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kevbot18/simple-particles" "work/ex/clippy-test-run/sources/stable/gh/kevbot18/simple-particles"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kevbot18/simple-particles'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kevbot18/simple-particles" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kevbot18/simple-particles"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kevbot18/simple-particles'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8ea5009901c9a09c82b75d68ebc3b96c39c4bfd5 [INFO] sha for GitHub repo kevbot18/simple-particles: 8ea5009901c9a09c82b75d68ebc3b96c39c4bfd5 [INFO] validating manifest of kevbot18/simple-particles on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kevbot18/simple-particles on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kevbot18/simple-particles [INFO] finished frobbing kevbot18/simple-particles [INFO] frobbed toml for kevbot18/simple-particles written to work/ex/clippy-test-run/sources/stable/gh/kevbot18/simple-particles/Cargo.toml [INFO] started frobbing kevbot18/simple-particles [INFO] finished frobbing kevbot18/simple-particles [INFO] frobbed toml for kevbot18/simple-particles written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kevbot18/simple-particles/Cargo.toml [INFO] crate kevbot18/simple-particles has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kevbot18/simple-particles against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kevbot18/simple-particles:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 29b344eecf7935e480f6c0419bedb69e7f55013e41f86c4f025a27100ed487a4 [INFO] running `"docker" "start" "-a" "29b344eecf7935e480f6c0419bedb69e7f55013e41f86c4f025a27100ed487a4"` [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Compiling x11-dl v2.17.0 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking rayon-core v1.3.0 [INFO] [stderr] Checking num-rational v0.1.40 [INFO] [stderr] Checking piston2d-graphics v0.21.1 [INFO] [stderr] Compiling glutin v0.9.2 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Checking png v0.9.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking pistoncore-input v0.19.0 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking pistoncore-window v0.28.0 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking pistoncore-event_loop v0.33.0 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Checking piston v0.33.0 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking pistoncore-glutin_window v0.39.1 [INFO] [stderr] Checking gfx v0.16.1 [INFO] [stderr] Checking gfx_device_gl v0.14.5 [INFO] [stderr] Checking piston-gfx_texture v0.26.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.43.0 [INFO] [stderr] Checking piston_window v0.70.0 [INFO] [stderr] Checking simple-particles v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/particle.rs:39:6 [INFO] [stderr] | [INFO] [stderr] 39 | if self.x - self.size == world.x { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `((self.x - self.size) - world.x).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/particle.rs:39:6 [INFO] [stderr] | [INFO] [stderr] 39 | if self.x - self.size == world.x { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/particle.rs:42:6 [INFO] [stderr] | [INFO] [stderr] 42 | if self.y - self.size == world.y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `((self.y - self.size) - world.y).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/particle.rs:42:6 [INFO] [stderr] | [INFO] [stderr] 42 | if self.y - self.size == world.y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/particle.rs:45:6 [INFO] [stderr] | [INFO] [stderr] 45 | if self.x + self.size == world.x + world.width { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.x + self.size - (world.x + world.width)).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/particle.rs:45:6 [INFO] [stderr] | [INFO] [stderr] 45 | if self.x + self.size == world.x + world.width { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/particle.rs:48:6 [INFO] [stderr] | [INFO] [stderr] 48 | if self.y + self.size == world.y + world.height { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.y + self.size - (world.y + world.height)).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/particle.rs:48:6 [INFO] [stderr] | [INFO] [stderr] 48 | if self.y + self.size == world.y + world.height { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:54:8 [INFO] [stderr] | [INFO] [stderr] 54 | for ref mut p in &mut balls { [INFO] [stderr] | ^^^^^^^^^ ---------- help: try: `let p = &mut &mut balls;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `simple-particles`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/particle.rs:39:6 [INFO] [stderr] | [INFO] [stderr] 39 | if self.x - self.size == world.x { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `((self.x - self.size) - world.x).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/particle.rs:39:6 [INFO] [stderr] | [INFO] [stderr] 39 | if self.x - self.size == world.x { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/particle.rs:42:6 [INFO] [stderr] | [INFO] [stderr] 42 | if self.y - self.size == world.y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `((self.y - self.size) - world.y).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/particle.rs:42:6 [INFO] [stderr] | [INFO] [stderr] 42 | if self.y - self.size == world.y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/particle.rs:45:6 [INFO] [stderr] | [INFO] [stderr] 45 | if self.x + self.size == world.x + world.width { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.x + self.size - (world.x + world.width)).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/particle.rs:45:6 [INFO] [stderr] | [INFO] [stderr] 45 | if self.x + self.size == world.x + world.width { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/particle.rs:48:6 [INFO] [stderr] | [INFO] [stderr] 48 | if self.y + self.size == world.y + world.height { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.y + self.size - (world.y + world.height)).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/particle.rs:48:6 [INFO] [stderr] | [INFO] [stderr] 48 | if self.y + self.size == world.y + world.height { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:54:8 [INFO] [stderr] | [INFO] [stderr] 54 | for ref mut p in &mut balls { [INFO] [stderr] | ^^^^^^^^^ ---------- help: try: `let p = &mut &mut balls;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `simple-particles`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "29b344eecf7935e480f6c0419bedb69e7f55013e41f86c4f025a27100ed487a4"` [INFO] running `"docker" "rm" "-f" "29b344eecf7935e480f6c0419bedb69e7f55013e41f86c4f025a27100ed487a4"` [INFO] [stdout] 29b344eecf7935e480f6c0419bedb69e7f55013e41f86c4f025a27100ed487a4