[INFO] updating cached repository kevbot18/permutate
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/kevbot18/permutate
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/kevbot18/permutate" "work/ex/clippy-test-run/sources/stable/gh/kevbot18/permutate"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kevbot18/permutate'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/kevbot18/permutate" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kevbot18/permutate"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kevbot18/permutate'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] fc653205b0992684a9f77e4983c055ea0705721c
[INFO] sha for GitHub repo kevbot18/permutate: fc653205b0992684a9f77e4983c055ea0705721c
[INFO] validating manifest of kevbot18/permutate on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of kevbot18/permutate on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing kevbot18/permutate
[INFO] finished frobbing kevbot18/permutate
[INFO] frobbed toml for kevbot18/permutate written to work/ex/clippy-test-run/sources/stable/gh/kevbot18/permutate/Cargo.toml
[INFO] started frobbing kevbot18/permutate
[INFO] finished frobbing kevbot18/permutate
[INFO] frobbed toml for kevbot18/permutate written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kevbot18/permutate/Cargo.toml
[INFO] crate kevbot18/permutate has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting kevbot18/permutate against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kevbot18/permutate:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e6a9df15cd701305c7e1228130fb6ec89ae46224ea85eb2d79459b06361602d0
[INFO] running `"docker" "start" "-a" "e6a9df15cd701305c7e1228130fb6ec89ae46224ea85eb2d79459b06361602d0"`
[INFO] [stderr]     Checking permutate v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: the loop variable `i` is only used to index `args`.
[INFO] [stderr]  --> src/main.rs:8:18
[INFO] [stderr]   |
[INFO] [stderr] 8 |         for i in 1..args.len() {
[INFO] [stderr]   |                  ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]   |
[INFO] [stderr] 8 |         for <item> in args.iter().skip(1) {
[INFO] [stderr]   |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping elements of `array` manually
[INFO] [stderr]   --> src/main.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 | /         let temp: &str = array[j];
[INFO] [stderr] 31 | |         array[j] = array[i];
[INFO] [stderr] 32 | |         array[i] = temp;
[INFO] [stderr]    | |_______________________^ help: try: `array.swap(j, i)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 | /         let mut j = 0;
[INFO] [stderr] 27 | |         if i%2 == 1 {
[INFO] [stderr] 28 | |             j = p[i];
[INFO] [stderr] 29 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> j = if i%2 == 1 { p[i] } else { 0 };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `args`.
[INFO] [stderr]  --> src/main.rs:8:18
[INFO] [stderr]   |
[INFO] [stderr] 8 |         for i in 1..args.len() {
[INFO] [stderr]   |                  ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]   |
[INFO] [stderr] 8 |         for <item> in args.iter().skip(1) {
[INFO] [stderr]   |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping elements of `array` manually
[INFO] [stderr]   --> src/main.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 | /         let temp: &str = array[j];
[INFO] [stderr] 31 | |         array[j] = array[i];
[INFO] [stderr] 32 | |         array[i] = temp;
[INFO] [stderr]    | |_______________________^ help: try: `array.swap(j, i)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 | /         let mut j = 0;
[INFO] [stderr] 27 | |         if i%2 == 1 {
[INFO] [stderr] 28 | |             j = p[i];
[INFO] [stderr] 29 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> j = if i%2 == 1 { p[i] } else { 0 };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.82s
[INFO] running `"docker" "inspect" "e6a9df15cd701305c7e1228130fb6ec89ae46224ea85eb2d79459b06361602d0"`
[INFO] running `"docker" "rm" "-f" "e6a9df15cd701305c7e1228130fb6ec89ae46224ea85eb2d79459b06361602d0"`
[INFO] [stdout] e6a9df15cd701305c7e1228130fb6ec89ae46224ea85eb2d79459b06361602d0