[INFO] updating cached repository kesselborn/rsdocs2docset [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kesselborn/rsdocs2docset [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kesselborn/rsdocs2docset" "work/ex/clippy-test-run/sources/stable/gh/kesselborn/rsdocs2docset"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kesselborn/rsdocs2docset'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kesselborn/rsdocs2docset" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kesselborn/rsdocs2docset"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kesselborn/rsdocs2docset'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f4290060d73125fbe5f058aa2b56f2903a7dd670 [INFO] sha for GitHub repo kesselborn/rsdocs2docset: f4290060d73125fbe5f058aa2b56f2903a7dd670 [INFO] validating manifest of kesselborn/rsdocs2docset on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kesselborn/rsdocs2docset on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kesselborn/rsdocs2docset [INFO] finished frobbing kesselborn/rsdocs2docset [INFO] frobbed toml for kesselborn/rsdocs2docset written to work/ex/clippy-test-run/sources/stable/gh/kesselborn/rsdocs2docset/Cargo.toml [INFO] started frobbing kesselborn/rsdocs2docset [INFO] finished frobbing kesselborn/rsdocs2docset [INFO] frobbed toml for kesselborn/rsdocs2docset written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kesselborn/rsdocs2docset/Cargo.toml [INFO] crate kesselborn/rsdocs2docset has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kesselborn/rsdocs2docset against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kesselborn/rsdocs2docset:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0dd1745b54a1b3ba74acf2f5795fc9433d7e649314140006a4f54b515c0d5557 [INFO] running `"docker" "start" "-a" "0dd1745b54a1b3ba74acf2f5795fc9433d7e649314140006a4f54b515c0d5557"` [INFO] [stderr] Compiling libc v0.2.19 [INFO] [stderr] Checking phf_shared v0.7.20 [INFO] [stderr] Checking mac v0.0.2 [INFO] [stderr] Checking serde v0.8.22 [INFO] [stderr] Compiling sqlite3-src v0.2.4 [INFO] [stderr] Compiling syn v0.10.6 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking thread-id v3.0.0 [INFO] [stderr] Checking term_size v0.2.1 [INFO] [stderr] Checking aho-corasick v0.6.1 [INFO] [stderr] Checking thread_local v0.3.2 [INFO] [stderr] Checking futf v0.1.2 [INFO] [stderr] Checking phf v0.7.20 [INFO] [stderr] Checking clap v2.19.3 [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Checking tendril v0.2.3 [INFO] [stderr] Checking sqlite3-sys v0.11.1 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking sqlite v0.23.2 [INFO] [stderr] Compiling phf_generator v0.7.20 [INFO] [stderr] Compiling string_cache_codegen v0.3.1 [INFO] [stderr] Compiling phf_codegen v0.7.20 [INFO] [stderr] Compiling string_cache v0.3.0 [INFO] [stderr] Compiling html5ever-atoms v0.1.3 [INFO] [stderr] Compiling html5ever v0.12.1 [INFO] [stderr] Checking rsdocs2docset v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dom/mod.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | entry_name: entry_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dom/mod.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | anchor_name: anchor_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `anchor_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dom/mod.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | is_section: is_section, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_section` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dom/mod.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | entry_name: entry_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dom/mod.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | anchor_name: anchor_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `anchor_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dom/mod.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | is_section: is_section, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_section` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/dom/manipulator.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn add_dash_links(mut dom: &mut RcDom, entries: &[Option]) { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/dom/fixtures.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | dom [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/dom/fixtures.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | let dom = parse_document(RcDom::default(), opts) [INFO] [stderr] | _______________^ [INFO] [stderr] 15 | | .from_utf8() [INFO] [stderr] 16 | | .read_from(&mut format!("{}", s).as_bytes()) [INFO] [stderr] 17 | | .unwrap(); [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/dom/manipulator.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn add_dash_links(mut dom: &mut RcDom, entries: &[Option]) { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dom/parser_tests.rs:14:45 [INFO] [stderr] | [INFO] [stderr] 14 | assert_eq!(*e.anchor_name.split("/").nth(4).unwrap(), *"HEAP"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dom/parser_tests.rs:33:45 [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(*e.anchor_name.split("/").nth(4).unwrap(), *"Cow"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dom/parser_tests.rs:52:45 [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(*e.anchor_name.split("/").nth(4).unwrap(), *"metadata"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dom/parser_tests.rs:71:45 [INFO] [stderr] | [INFO] [stderr] 71 | assert_eq!(*e.anchor_name.split("/").nth(4).unwrap(), *"println"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dom/parser_tests.rs:91:45 [INFO] [stderr] | [INFO] [stderr] 91 | assert_eq!(*e.anchor_name.split("/").nth(4).unwrap(), *"borrow"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dom/parser_tests.rs:111:45 [INFO] [stderr] | [INFO] [stderr] 111 | assert_eq!(*e.anchor_name.split("/").nth(4).unwrap(), *"to_mut"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dom/parser_tests.rs:130:45 [INFO] [stderr] | [INFO] [stderr] 130 | assert_eq!(*e.anchor_name.split("/").nth(4).unwrap(), *"of"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dom/parser_tests.rs:148:45 [INFO] [stderr] | [INFO] [stderr] 148 | assert_eq!(*e.anchor_name.split("/").nth(4).unwrap(), *"collections"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dom/parser_tests.rs:167:45 [INFO] [stderr] | [INFO] [stderr] 167 | assert_eq!(*e.anchor_name.split("/").nth(4).unwrap(), *"Bytes"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dom/parser_tests.rs:185:45 [INFO] [stderr] | [INFO] [stderr] 185 | assert_eq!(*e.anchor_name.split("/").nth(4).unwrap(), *"Binary"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dom/parser_tests.rs:202:45 [INFO] [stderr] | [INFO] [stderr] 202 | assert_eq!(*e.anchor_name.split("/").nth(4).unwrap(), *"Item"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dom/manipulator_tests.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let ref html_element = dom.document.borrow().children[0]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^------------------------------------- help: try: `let html_element = &dom.document.borrow().children[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:103:10 [INFO] [stderr] | [INFO] [stderr] 103 | .expect(format!("can't create parent dir of {}", [INFO] [stderr] | __________^ [INFO] [stderr] 104 | | path.to_str().expect("can't stringify path")) [INFO] [stderr] 105 | | .as_str()); [INFO] [stderr] | |______________________^ help: try this: `unwrap_or_else(|| panic!("can't create parent dir of {}", path.to_str().expect("can't stringify path")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:103:10 [INFO] [stderr] | [INFO] [stderr] 103 | .expect(format!("can't create parent dir of {}", [INFO] [stderr] | __________^ [INFO] [stderr] 104 | | path.to_str().expect("can't stringify path")) [INFO] [stderr] 105 | | .as_str()); [INFO] [stderr] | |______________________^ help: try this: `unwrap_or_else(|| panic!("can't create parent dir of {}", path.to_str().expect("can't stringify path")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 37.01s [INFO] running `"docker" "inspect" "0dd1745b54a1b3ba74acf2f5795fc9433d7e649314140006a4f54b515c0d5557"` [INFO] running `"docker" "rm" "-f" "0dd1745b54a1b3ba74acf2f5795fc9433d7e649314140006a4f54b515c0d5557"` [INFO] [stdout] 0dd1745b54a1b3ba74acf2f5795fc9433d7e649314140006a4f54b515c0d5557