[INFO] updating cached repository kespindler/playlog-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kespindler/playlog-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kespindler/playlog-rs" "work/ex/clippy-test-run/sources/stable/gh/kespindler/playlog-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kespindler/playlog-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kespindler/playlog-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kespindler/playlog-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kespindler/playlog-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a1a5755b472baa14f9632f268544eb13f6714ed1 [INFO] sha for GitHub repo kespindler/playlog-rs: a1a5755b472baa14f9632f268544eb13f6714ed1 [INFO] validating manifest of kespindler/playlog-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kespindler/playlog-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kespindler/playlog-rs [INFO] finished frobbing kespindler/playlog-rs [INFO] frobbed toml for kespindler/playlog-rs written to work/ex/clippy-test-run/sources/stable/gh/kespindler/playlog-rs/Cargo.toml [INFO] started frobbing kespindler/playlog-rs [INFO] finished frobbing kespindler/playlog-rs [INFO] frobbed toml for kespindler/playlog-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kespindler/playlog-rs/Cargo.toml [INFO] crate kespindler/playlog-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kespindler/playlog-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kespindler/playlog-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ff35b6c5ea6cc56953f063614c9d9668313ec5741b04572ef8ef4a30219e6815 [INFO] running `"docker" "start" "-a" "ff35b6c5ea6cc56953f063614c9d9668313ec5741b04572ef8ef4a30219e6815"` [INFO] [stderr] Checking chrono v0.4.4 [INFO] [stderr] Checking playlog v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/json_handler.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | /// Copied from slog-rs/bunyan [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/json_handler.rs:57:38 [INFO] [stderr] | [INFO] [stderr] 57 | fn write(&self, record: &Record) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | /// This is a stand-in for now, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/lib.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | /// This is a stand-in for now, but [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:64:1 [INFO] [stderr] | [INFO] [stderr] 64 | / macro_rules! log { [INFO] [stderr] 65 | | ( $name:expr, $level:expr, $message:expr, $args:expr ) => { [INFO] [stderr] 66 | | { [INFO] [stderr] 67 | | if __get_log_level($name) >= $level { [INFO] [stderr] ... | [INFO] [stderr] 79 | | }; [INFO] [stderr] 80 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/lib.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | fn __get_log_level(name: &str) -> Level { [INFO] [stderr] | ^^^^ help: consider using `_name` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/lib.rs:35:23 [INFO] [stderr] | [INFO] [stderr] 35 | fn __get_log_handlers(name: &str) -> Vec { [INFO] [stderr] | ^^^^ help: consider using `_name` instead [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `JsonHandler` [INFO] [stderr] --> src/json_handler.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | pub struct JsonHandler { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `DEFAULT_HANDLER` [INFO] [stderr] --> src/lib.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / const DEFAULT_HANDLER: JsonHandler = JsonHandler{ [INFO] [stderr] 29 | | /// Stand-in for now. We do want a sane default, but [INFO] [stderr] 30 | | /// Json is probably not that sane default. [INFO] [stderr] 31 | | pretty_print: true [INFO] [stderr] 32 | | }; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/json_handler.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | stdout().write(s.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/map.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/json_handler.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | /// Copied from slog-rs/bunyan [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/json_handler.rs:57:38 [INFO] [stderr] | [INFO] [stderr] 57 | fn write(&self, record: &Record) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/lib.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | /// This is a stand-in for now, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/lib.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | /// This is a stand-in for now, but [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/lib.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | fn __get_log_level(name: &str) -> Level { [INFO] [stderr] | ^^^^ help: consider using `_name` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `name` [INFO] [stderr] --> src/lib.rs:35:23 [INFO] [stderr] | [INFO] [stderr] 35 | fn __get_log_handlers(name: &str) -> Vec { [INFO] [stderr] | ^^^^ help: consider using `_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/map.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/json_handler.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | stdout().write(s.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/lib.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.85s [INFO] running `"docker" "inspect" "ff35b6c5ea6cc56953f063614c9d9668313ec5741b04572ef8ef4a30219e6815"` [INFO] running `"docker" "rm" "-f" "ff35b6c5ea6cc56953f063614c9d9668313ec5741b04572ef8ef4a30219e6815"` [INFO] [stdout] ff35b6c5ea6cc56953f063614c9d9668313ec5741b04572ef8ef4a30219e6815