[INFO] updating cached repository keringar/rar2zip [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/keringar/rar2zip [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/keringar/rar2zip" "work/ex/clippy-test-run/sources/stable/gh/keringar/rar2zip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/keringar/rar2zip'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/keringar/rar2zip" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keringar/rar2zip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keringar/rar2zip'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0b4b696fca308724e36396ea7b116b599c523ead [INFO] sha for GitHub repo keringar/rar2zip: 0b4b696fca308724e36396ea7b116b599c523ead [INFO] validating manifest of keringar/rar2zip on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of keringar/rar2zip on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing keringar/rar2zip [INFO] finished frobbing keringar/rar2zip [INFO] frobbed toml for keringar/rar2zip written to work/ex/clippy-test-run/sources/stable/gh/keringar/rar2zip/Cargo.toml [INFO] started frobbing keringar/rar2zip [INFO] finished frobbing keringar/rar2zip [INFO] frobbed toml for keringar/rar2zip written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keringar/rar2zip/Cargo.toml [INFO] crate keringar/rar2zip has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting keringar/rar2zip against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/keringar/rar2zip:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fdf2e6f8aede4a364c7092e321f828314a068157d12fd5d22665cd14aa92281b [INFO] running `"docker" "start" "-a" "fdf2e6f8aede4a364c7092e321f828314a068157d12fd5d22665cd14aa92281b"` [INFO] [stderr] Checking random v0.12.2 [INFO] [stderr] Compiling unrar_sys v0.2.0 [INFO] [stderr] Checking walkdir v2.0.1 [INFO] [stderr] Checking num-bigint v0.1.41 [INFO] [stderr] Checking temporary v0.6.3 [INFO] [stderr] Checking num-rational v0.1.40 [INFO] [stderr] Checking num v0.1.41 [INFO] [stderr] Checking unrar v0.4.3 [INFO] [stderr] Checking rar2zip v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:39:44 [INFO] [stderr] | [INFO] [stderr] 39 | Ok(mut open_archive) => if let Err(_) = open_archive.process() { [INFO] [stderr] | _____________________________________- ^^^^^^ [INFO] [stderr] 40 | | eprintln!("ERROR: Could not extract rar archive"); [INFO] [stderr] 41 | | return; [INFO] [stderr] 42 | | }, [INFO] [stderr] | |_____________- help: try this: `if open_archive.process().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:39:44 [INFO] [stderr] | [INFO] [stderr] 39 | Ok(mut open_archive) => if let Err(_) = open_archive.process() { [INFO] [stderr] | _____________________________________- ^^^^^^ [INFO] [stderr] 40 | | eprintln!("ERROR: Could not extract rar archive"); [INFO] [stderr] 41 | | return; [INFO] [stderr] 42 | | }, [INFO] [stderr] | |_____________- help: try this: `if open_archive.process().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.94s [INFO] running `"docker" "inspect" "fdf2e6f8aede4a364c7092e321f828314a068157d12fd5d22665cd14aa92281b"` [INFO] running `"docker" "rm" "-f" "fdf2e6f8aede4a364c7092e321f828314a068157d12fd5d22665cd14aa92281b"` [INFO] [stdout] fdf2e6f8aede4a364c7092e321f828314a068157d12fd5d22665cd14aa92281b