[INFO] updating cached repository keringar/dci-bot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/keringar/dci-bot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/keringar/dci-bot" "work/ex/clippy-test-run/sources/stable/gh/keringar/dci-bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/keringar/dci-bot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/keringar/dci-bot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keringar/dci-bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keringar/dci-bot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 16fc0f0f47c1e8463d3acd75509c23b37cb3a3eb [INFO] sha for GitHub repo keringar/dci-bot: 16fc0f0f47c1e8463d3acd75509c23b37cb3a3eb [INFO] validating manifest of keringar/dci-bot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of keringar/dci-bot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing keringar/dci-bot [INFO] finished frobbing keringar/dci-bot [INFO] frobbed toml for keringar/dci-bot written to work/ex/clippy-test-run/sources/stable/gh/keringar/dci-bot/Cargo.toml [INFO] started frobbing keringar/dci-bot [INFO] finished frobbing keringar/dci-bot [INFO] frobbed toml for keringar/dci-bot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keringar/dci-bot/Cargo.toml [INFO] crate keringar/dci-bot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting keringar/dci-bot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/keringar/dci-bot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e6029b01d3a6191a76e5e120eabc576a22711bb5f8fe77ec0dbb855254386d86 [INFO] running `"docker" "start" "-a" "e6029b01d3a6191a76e5e120eabc576a22711bb5f8fe77ec0dbb855254386d86"` [INFO] [stderr] Compiling serde v1.0.67 [INFO] [stderr] Checking tendril v0.3.1 [INFO] [stderr] Checking libflate v0.1.15 [INFO] [stderr] Checking rusqlite v0.13.0 [INFO] [stderr] Compiling string_cache_codegen v0.4.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Compiling string_cache v0.6.2 [INFO] [stderr] Compiling markup5ever v0.3.2 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking serde_json v1.0.22 [INFO] [stderr] Checking orca v0.5.0 [INFO] [stderr] Checking reqwest v0.8.6 [INFO] [stderr] Checking html5ever v0.18.0 [INFO] [stderr] Checking select v0.4.2 [INFO] [stderr] Checking dci-bot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:3:23 [INFO] [stderr] | [INFO] [stderr] 3 | pub const EVENT_URL: &'static str = "https://www.dci.org/events"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:4:22 [INFO] [stderr] | [INFO] [stderr] 4 | pub const BASE_URL: &'static str = "https://www.dci.org"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:5:21 [INFO] [stderr] | [INFO] [stderr] 5 | pub const DB_PATH: &'static str = "./event.db"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:8:30 [INFO] [stderr] | [INFO] [stderr] 8 | pub const START_TIME_QUERY: &'static str = "startDate"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:9:28 [INFO] [stderr] | [INFO] [stderr] 9 | pub const END_TIME_QUERY: &'static str = "toDate"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:12:36 [INFO] [stderr] | [INFO] [stderr] 12 | pub const ITEMS_PARENT_CONTAINER: &'static str = "events-items"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:13:32 [INFO] [stderr] | [INFO] [stderr] 13 | pub const ITEMS_LINK_DETAILS: &'static str = "link details"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:16:34 [INFO] [stderr] | [INFO] [stderr] 16 | pub const TZ_CONTENT_CONTAINER: &'static str = "line-up-holder limit"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | pub const TIME_TABLE: &'static str = "time-table"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | pub const INFO_SECTION_CLASS: &'static str = "info-holder"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:21:30 [INFO] [stderr] | [INFO] [stderr] 21 | pub const INFO_DATE_MARKER: &'static str = "/slice/dist/images/icons/watch_grey_icon.svg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | pub const INFO_LOCATION_MARKER: &'static str = "/slice/dist/images/icons/location_grey_icon.svg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | pub const SUBREDDIT: &'static str = "/r/drumcorps"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | pub const APP_ID: &'static str = "AOBwXdKkVWSjTg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | pub const USERNAME: &'static str = "DrumCorpsBot"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | pub const ENV_PASSWORD: &'static str = "DCI_PASSWORD"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | pub const ENV_SECRET: &'static str = "DCI_SECRET"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bot.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | if matching_events.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!matching_events.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/bot.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / fn create_listing_from_strings( [INFO] [stderr] 99 | | &self, [INFO] [stderr] 100 | | url: String, [INFO] [stderr] 101 | | date: String, [INFO] [stderr] ... | [INFO] [stderr] 119 | | }) [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bot.rs:122:35 [INFO] [stderr] | [INFO] [stderr] 122 | fn create_post(&self, events: &Vec) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[EventListing]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bot.rs:147:32 [INFO] [stderr] | [INFO] [stderr] 147 | let next = format!("|------|-----------------------------------------|\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"|------|-----------------------------------------|\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/scraper.rs:168:10 [INFO] [stderr] | [INFO] [stderr] 168 | ) -> Result<(Vec<(String, String)>, String, String), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:3:23 [INFO] [stderr] | [INFO] [stderr] 3 | pub const EVENT_URL: &'static str = "https://www.dci.org/events"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:4:22 [INFO] [stderr] | [INFO] [stderr] 4 | pub const BASE_URL: &'static str = "https://www.dci.org"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:5:21 [INFO] [stderr] | [INFO] [stderr] 5 | pub const DB_PATH: &'static str = "./event.db"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:8:30 [INFO] [stderr] | [INFO] [stderr] 8 | pub const START_TIME_QUERY: &'static str = "startDate"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:9:28 [INFO] [stderr] | [INFO] [stderr] 9 | pub const END_TIME_QUERY: &'static str = "toDate"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:12:36 [INFO] [stderr] | [INFO] [stderr] 12 | pub const ITEMS_PARENT_CONTAINER: &'static str = "events-items"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:13:32 [INFO] [stderr] | [INFO] [stderr] 13 | pub const ITEMS_LINK_DETAILS: &'static str = "link details"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:16:34 [INFO] [stderr] | [INFO] [stderr] 16 | pub const TZ_CONTENT_CONTAINER: &'static str = "line-up-holder limit"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | pub const TIME_TABLE: &'static str = "time-table"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | pub const INFO_SECTION_CLASS: &'static str = "info-holder"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:21:30 [INFO] [stderr] | [INFO] [stderr] 21 | pub const INFO_DATE_MARKER: &'static str = "/slice/dist/images/icons/watch_grey_icon.svg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | pub const INFO_LOCATION_MARKER: &'static str = "/slice/dist/images/icons/location_grey_icon.svg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | pub const SUBREDDIT: &'static str = "/r/drumcorps"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | pub const APP_ID: &'static str = "AOBwXdKkVWSjTg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | pub const USERNAME: &'static str = "DrumCorpsBot"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | pub const ENV_PASSWORD: &'static str = "DCI_PASSWORD"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/strings.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | pub const ENV_SECRET: &'static str = "DCI_SECRET"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bot.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | if matching_events.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!matching_events.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/bot.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / fn create_listing_from_strings( [INFO] [stderr] 99 | | &self, [INFO] [stderr] 100 | | url: String, [INFO] [stderr] 101 | | date: String, [INFO] [stderr] ... | [INFO] [stderr] 119 | | }) [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bot.rs:122:35 [INFO] [stderr] | [INFO] [stderr] 122 | fn create_post(&self, events: &Vec) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[EventListing]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bot.rs:147:32 [INFO] [stderr] | [INFO] [stderr] 147 | let next = format!("|------|-----------------------------------------|\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"|------|-----------------------------------------|\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/scraper.rs:168:10 [INFO] [stderr] | [INFO] [stderr] 168 | ) -> Result<(Vec<(String, String)>, String, String), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 45.62s [INFO] running `"docker" "inspect" "e6029b01d3a6191a76e5e120eabc576a22711bb5f8fe77ec0dbb855254386d86"` [INFO] running `"docker" "rm" "-f" "e6029b01d3a6191a76e5e120eabc576a22711bb5f8fe77ec0dbb855254386d86"` [INFO] [stdout] e6029b01d3a6191a76e5e120eabc576a22711bb5f8fe77ec0dbb855254386d86