[INFO] updating cached repository keorn/parity-spec [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/keorn/parity-spec [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/keorn/parity-spec" "work/ex/clippy-test-run/sources/stable/gh/keorn/parity-spec"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/keorn/parity-spec'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/keorn/parity-spec" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keorn/parity-spec"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keorn/parity-spec'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e9e650cdf7f570fc365281f24cbc26c25b712c9f [INFO] sha for GitHub repo keorn/parity-spec: e9e650cdf7f570fc365281f24cbc26c25b712c9f [INFO] validating manifest of keorn/parity-spec on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of keorn/parity-spec on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing keorn/parity-spec [INFO] finished frobbing keorn/parity-spec [INFO] frobbed toml for keorn/parity-spec written to work/ex/clippy-test-run/sources/stable/gh/keorn/parity-spec/Cargo.toml [INFO] started frobbing keorn/parity-spec [INFO] finished frobbing keorn/parity-spec [INFO] frobbed toml for keorn/parity-spec written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keorn/parity-spec/Cargo.toml [INFO] crate keorn/parity-spec has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting keorn/parity-spec against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/keorn/parity-spec:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 66bb0d141bcfd65660101bdce02bcb5e91e1ea3812bdd6344a90e02fc8333b93 [INFO] running `"docker" "start" "-a" "66bb0d141bcfd65660101bdce02bcb5e91e1ea3812bdd6344a90e02fc8333b93"` [INFO] [stderr] Compiling syn v0.11.4 [INFO] [stderr] Checking serde_json v0.9.6 [INFO] [stderr] Compiling serde_codegen_internals v0.13.0 [INFO] [stderr] Compiling serde_derive v0.9.7 [INFO] [stderr] Checking chain_spec v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:238:3 [INFO] [stderr] | [INFO] [stderr] 238 | engine: engine, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `engine` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:238:3 [INFO] [stderr] | [INFO] [stderr] 238 | engine: engine, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `engine` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:121:2 [INFO] [stderr] | [INFO] [stderr] 121 | /// Read Geth chain spec. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:178:19 [INFO] [stderr] | [INFO] [stderr] 178 | homesteadBlock: 9223372036854775807, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:180:16 [INFO] [stderr] | [INFO] [stderr] 180 | eip155Block: 9223372036854775807, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:181:16 [INFO] [stderr] | [INFO] [stderr] 181 | eip158Block: 9223372036854775807, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:182:16 [INFO] [stderr] | [INFO] [stderr] 182 | eip160Block: 9223372036854775807, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:185:2 [INFO] [stderr] | [INFO] [stderr] 185 | /// Construct Parity chain spec. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:211:20 [INFO] [stderr] | [INFO] [stderr] 211 | eip98Transition: 9223372036854775807, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:121:2 [INFO] [stderr] | [INFO] [stderr] 121 | /// Read Geth chain spec. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:178:19 [INFO] [stderr] | [INFO] [stderr] 178 | homesteadBlock: 9223372036854775807, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:180:16 [INFO] [stderr] | [INFO] [stderr] 180 | eip155Block: 9223372036854775807, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:181:16 [INFO] [stderr] | [INFO] [stderr] 181 | eip158Block: 9223372036854775807, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:182:16 [INFO] [stderr] | [INFO] [stderr] 182 | eip160Block: 9223372036854775807, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:185:2 [INFO] [stderr] | [INFO] [stderr] 185 | /// Construct Parity chain spec. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:211:20 [INFO] [stderr] | [INFO] [stderr] 211 | eip98Transition: 9223372036854775807, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: field is never used: `eip158Block` [INFO] [stderr] --> src/main.rs:27:2 [INFO] [stderr] | [INFO] [stderr] 27 | eip158Block: u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `eip158Block` [INFO] [stderr] --> src/main.rs:27:2 [INFO] [stderr] | [INFO] [stderr] 27 | eip158Block: u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:207:42 [INFO] [stderr] | [INFO] [stderr] 207 | accountStartNonce: start_nonce.clone().unwrap_or("0x0".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "0x0".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:207:42 [INFO] [stderr] | [INFO] [stderr] 207 | accountStartNonce: start_nonce.clone().unwrap_or("0x0".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "0x0".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.81s [INFO] running `"docker" "inspect" "66bb0d141bcfd65660101bdce02bcb5e91e1ea3812bdd6344a90e02fc8333b93"` [INFO] running `"docker" "rm" "-f" "66bb0d141bcfd65660101bdce02bcb5e91e1ea3812bdd6344a90e02fc8333b93"` [INFO] [stdout] 66bb0d141bcfd65660101bdce02bcb5e91e1ea3812bdd6344a90e02fc8333b93