[INFO] updating cached repository kenrick95/adventofcode2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kenrick95/adventofcode2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kenrick95/adventofcode2017" "work/ex/clippy-test-run/sources/stable/gh/kenrick95/adventofcode2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kenrick95/adventofcode2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kenrick95/adventofcode2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenrick95/adventofcode2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenrick95/adventofcode2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 75b1830f323d6de54e59c637eb7893cf09257f77 [INFO] sha for GitHub repo kenrick95/adventofcode2017: 75b1830f323d6de54e59c637eb7893cf09257f77 [INFO] validating manifest of kenrick95/adventofcode2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kenrick95/adventofcode2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kenrick95/adventofcode2017 [INFO] finished frobbing kenrick95/adventofcode2017 [INFO] frobbed toml for kenrick95/adventofcode2017 written to work/ex/clippy-test-run/sources/stable/gh/kenrick95/adventofcode2017/Cargo.toml [INFO] started frobbing kenrick95/adventofcode2017 [INFO] finished frobbing kenrick95/adventofcode2017 [INFO] frobbed toml for kenrick95/adventofcode2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenrick95/adventofcode2017/Cargo.toml [INFO] crate kenrick95/adventofcode2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kenrick95/adventofcode2017 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kenrick95/adventofcode2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c1368cc714a4c5dac0bdfca93203a69af4809bfce486f28cc12b300be7e353a3 [INFO] running `"docker" "start" "-a" "c1368cc714a4c5dac0bdfca93203a69af4809bfce486f28cc12b300be7e353a3"` [INFO] [stderr] Checking regex v0.2.5 [INFO] [stderr] Checking aoc2017 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/day23part2.rs:14:11 [INFO] [stderr] | [INFO] [stderr] 14 | let mut d = 2; [INFO] [stderr] | ^ [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/day23part2.rs:14:11 [INFO] [stderr] | [INFO] [stderr] 14 | let mut d = 2; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/day23part2.rs:15:11 [INFO] [stderr] | [INFO] [stderr] 15 | let mut e = 2; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/day23part2.rs:16:11 [INFO] [stderr] | [INFO] [stderr] 16 | let mut g = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/day23part2.rs:17:11 [INFO] [stderr] | [INFO] [stderr] 17 | let mut h = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/day23part2.rs:15:11 [INFO] [stderr] | [INFO] [stderr] 15 | let mut e = 2; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/day23part2.rs:16:11 [INFO] [stderr] | [INFO] [stderr] 16 | let mut g = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/day23part2.rs:17:11 [INFO] [stderr] | [INFO] [stderr] 17 | let mut h = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day23part2.rs:10:19 [INFO] [stderr] | [INFO] [stderr] 10 | b = b * 100 + 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day23part2.rs:10:19 [INFO] [stderr] | [INFO] [stderr] 10 | b = b * 100 + 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/day23part2.rs:15:7 [INFO] [stderr] | [INFO] [stderr] 15 | let mut e = 2; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/day23part2.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | let mut g = 0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/day23part2.rs:8:3 [INFO] [stderr] | [INFO] [stderr] 8 | / let mut c = b; [INFO] [stderr] 9 | | if a != 0 { [INFO] [stderr] 10 | | b = b * 100 + 100000; [INFO] [stderr] 11 | | c = b + 17000; [INFO] [stderr] 12 | | } [INFO] [stderr] | |___^ help: it is more idiomatic to write: `let c = if a != 0 { ..; b + 17000 } else { b };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/day23part2.rs:15:7 [INFO] [stderr] | [INFO] [stderr] 15 | let mut e = 2; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/day23part2.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | let mut g = 0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/day23part2.rs:8:3 [INFO] [stderr] | [INFO] [stderr] 8 | / let mut c = b; [INFO] [stderr] 9 | | if a != 0 { [INFO] [stderr] 10 | | b = b * 100 + 100000; [INFO] [stderr] 11 | | c = b + 17000; [INFO] [stderr] 12 | | } [INFO] [stderr] | |___^ help: it is more idiomatic to write: `let c = if a != 0 { ..; b + 17000 } else { b };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.91s [INFO] running `"docker" "inspect" "c1368cc714a4c5dac0bdfca93203a69af4809bfce486f28cc12b300be7e353a3"` [INFO] running `"docker" "rm" "-f" "c1368cc714a4c5dac0bdfca93203a69af4809bfce486f28cc12b300be7e353a3"` [INFO] [stdout] c1368cc714a4c5dac0bdfca93203a69af4809bfce486f28cc12b300be7e353a3