[INFO] updating cached repository kenpratt/jvm-assembler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kenpratt/jvm-assembler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kenpratt/jvm-assembler" "work/ex/clippy-test-run/sources/stable/gh/kenpratt/jvm-assembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kenpratt/jvm-assembler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kenpratt/jvm-assembler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenpratt/jvm-assembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenpratt/jvm-assembler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 13c90ce76d099b743656568e1c46ad8204c68e63 [INFO] sha for GitHub repo kenpratt/jvm-assembler: 13c90ce76d099b743656568e1c46ad8204c68e63 [INFO] validating manifest of kenpratt/jvm-assembler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kenpratt/jvm-assembler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kenpratt/jvm-assembler [INFO] finished frobbing kenpratt/jvm-assembler [INFO] frobbed toml for kenpratt/jvm-assembler written to work/ex/clippy-test-run/sources/stable/gh/kenpratt/jvm-assembler/Cargo.toml [INFO] started frobbing kenpratt/jvm-assembler [INFO] finished frobbing kenpratt/jvm-assembler [INFO] frobbed toml for kenpratt/jvm-assembler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenpratt/jvm-assembler/Cargo.toml [INFO] crate kenpratt/jvm-assembler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kenpratt/jvm-assembler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kenpratt/jvm-assembler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d4e0c8c8df8807b9a5caecaba09980a1c97131677becff4feac5c74404872be [INFO] running `"docker" "start" "-a" "1d4e0c8c8df8807b9a5caecaba09980a1c97131677becff4feac5c74404872be"` [INFO] [stderr] Checking jvm-assembler v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | this_class: this_class, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `this_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | super_class: super_class, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `super_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | methods: methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `methods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | name_index: name_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | descriptor_index: descriptor_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_builder.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_builder.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | classfile: classfile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `classfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_builder.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_builder.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | name_index: name_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_builder.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | descriptor_index: descriptor_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/pretty_printing.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | write!(f, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/pretty_printing.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | write!(f, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | Deserializer { stream: stream, bytes_taken: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | this_class: this_class, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `this_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | super_class: super_class, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `super_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | methods: methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `methods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | name_index: name_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | descriptor_index: descriptor_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/classfile.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_builder.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_builder.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | classfile: classfile, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `classfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_builder.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | access_flags: access_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `access_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_builder.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | name_index: name_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/class_builder.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | descriptor_index: descriptor_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `descriptor_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/pretty_printing.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | write!(f, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/pretty_printing.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | write!(f, "\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:57:24 [INFO] [stderr] | [INFO] [stderr] 57 | Deserializer { stream: stream, bytes_taken: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/classfile.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | const CAFEBABE: u32 = 0xCAFEBABE; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xCAFE_BABE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/classfile.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | const CAFEBABE: u32 = 0xCAFEBABE; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xCAFE_BABE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serialization.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | let mut buf = &mut Deserializer::new(Box::new(stream.bytes().map(|r| r.unwrap()))); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serialization.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | let mut code_buf = &mut Deserializer::new(Box::new(code.into_iter())); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serialization.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | let mut attribute_name_index; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serialization.rs:380:17 [INFO] [stderr] | [INFO] [stderr] 380 | let mut body_buf = &mut attribute_body; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serialization.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | let mut buf = &mut Deserializer::new(Box::new(stream.bytes().map(|r| r.unwrap()))); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serialization.rs:416:13 [INFO] [stderr] | [INFO] [stderr] 416 | let mut buf2 = &mut Deserializer::new(Box::new(attribute_body.into_iter())); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serialization.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | let mut code_buf = &mut Deserializer::new(Box::new(code.into_iter())); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serialization.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | let mut attribute_name_index; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serialization.rs:380:17 [INFO] [stderr] | [INFO] [stderr] 380 | let mut body_buf = &mut attribute_body; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/serialization.rs:416:13 [INFO] [stderr] | [INFO] [stderr] 416 | let mut buf2 = &mut Deserializer::new(Box::new(attribute_body.into_iter())); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/class_builder.rs:162:27 [INFO] [stderr] | [INFO] [stderr] 162 | if string_index > ::std::u8::MAX as u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(::std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/class_builder.rs:306:33 [INFO] [stderr] | [INFO] [stderr] 306 | let frame = if offset > ::std::u8::MAX as u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(::std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/class_builder.rs:317:29 [INFO] [stderr] | [INFO] [stderr] 317 | self.stack_index += instruction.size() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(instruction.size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/class_builder.rs:323:29 [INFO] [stderr] | [INFO] [stderr] 323 | self.stack_index += instruction.size() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(instruction.size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/class_builder.rs:339:34 [INFO] [stderr] | [INFO] [stderr] 339 | self.curr_stack_depth -= n as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/class_builder.rs:352:33 [INFO] [stderr] | [INFO] [stderr] 352 | let label_pos = labels.get(l).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&labels[l]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in self.enumerate()` or similar iterators [INFO] [stderr] --> src/pretty_printing.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | for item in self { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pretty_printing.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | if self.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pretty_printing.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | if self.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/class_builder.rs:162:27 [INFO] [stderr] | [INFO] [stderr] 162 | if string_index > ::std::u8::MAX as u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(::std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/class_builder.rs:306:33 [INFO] [stderr] | [INFO] [stderr] 306 | let frame = if offset > ::std::u8::MAX as u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(::std::u8::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/serialization.rs:94:10 [INFO] [stderr] | [INFO] [stderr] 94 | ((v[0] as u16) << 8) + (v[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(v[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/serialization.rs:94:32 [INFO] [stderr] | [INFO] [stderr] 94 | ((v[0] as u16) << 8) + (v[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(v[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/serialization.rs:108:10 [INFO] [stderr] | [INFO] [stderr] 108 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/serialization.rs:108:34 [INFO] [stderr] | [INFO] [stderr] 108 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/serialization.rs:108:58 [INFO] [stderr] | [INFO] [stderr] 108 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/serialization.rs:108:80 [INFO] [stderr] | [INFO] [stderr] 108 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/serialization.rs:122:32 [INFO] [stderr] | [INFO] [stderr] 122 | let v = buf.take_bytes(len as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | (0..len).into_iter().map(|_| Constant::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/class_builder.rs:317:29 [INFO] [stderr] | [INFO] [stderr] 317 | self.stack_index += instruction.size() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(instruction.size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/class_builder.rs:323:29 [INFO] [stderr] | [INFO] [stderr] 323 | self.stack_index += instruction.size() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(instruction.size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | (0..len).into_iter().map(|_| Interface::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/class_builder.rs:339:34 [INFO] [stderr] | [INFO] [stderr] 339 | self.curr_stack_depth -= n as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | (0..len).into_iter().map(|_| Field::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | (0..len).into_iter().map(|_| Method::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/class_builder.rs:352:33 [INFO] [stderr] | [INFO] [stderr] 352 | let label_pos = labels.get(l).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&labels[l]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | (0..len).into_iter().map(|_| Attribute::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | (0..len).into_iter().map(|_| ExceptionTableEntry::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | (0..len).into_iter().map(|_| LineNumberTableEntry::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | (0..len).into_iter().map(|_| StackMapFrame::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | (0..len).into_iter().map(|_| VerificationType::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in self.enumerate()` or similar iterators [INFO] [stderr] --> src/pretty_printing.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | for item in self { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:544:30 [INFO] [stderr] | [INFO] [stderr] 544 | let locals = (0..k).into_iter().map(|_| VerificationType::deserialize(buf, classfile)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pretty_printing.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | if self.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pretty_printing.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | if self.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/serialization.rs:94:10 [INFO] [stderr] | [INFO] [stderr] 94 | ((v[0] as u16) << 8) + (v[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(v[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/serialization.rs:94:32 [INFO] [stderr] | [INFO] [stderr] 94 | ((v[0] as u16) << 8) + (v[1] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(v[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/serialization.rs:108:10 [INFO] [stderr] | [INFO] [stderr] 108 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/serialization.rs:108:34 [INFO] [stderr] | [INFO] [stderr] 108 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/serialization.rs:108:58 [INFO] [stderr] | [INFO] [stderr] 108 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/serialization.rs:108:80 [INFO] [stderr] | [INFO] [stderr] 108 | ((v[0] as u32) << 24) + ((v[1] as u32) << 16) + ((v[2] as u32) << 8) + (v[3] as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/serialization.rs:122:32 [INFO] [stderr] | [INFO] [stderr] 122 | let v = buf.take_bytes(len as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | (0..len).into_iter().map(|_| Constant::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | (0..len).into_iter().map(|_| Interface::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | (0..len).into_iter().map(|_| Field::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | (0..len).into_iter().map(|_| Method::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | (0..len).into_iter().map(|_| Attribute::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | (0..len).into_iter().map(|_| ExceptionTableEntry::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | (0..len).into_iter().map(|_| LineNumberTableEntry::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | (0..len).into_iter().map(|_| StackMapFrame::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | (0..len).into_iter().map(|_| VerificationType::deserialize(buf, classfile)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/serialization.rs:544:30 [INFO] [stderr] | [INFO] [stderr] 544 | let locals = (0..k).into_iter().map(|_| VerificationType::deserialize(buf, classfile)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..k)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.04s [INFO] running `"docker" "inspect" "1d4e0c8c8df8807b9a5caecaba09980a1c97131677becff4feac5c74404872be"` [INFO] running `"docker" "rm" "-f" "1d4e0c8c8df8807b9a5caecaba09980a1c97131677becff4feac5c74404872be"` [INFO] [stdout] 1d4e0c8c8df8807b9a5caecaba09980a1c97131677becff4feac5c74404872be