[INFO] updating cached repository kennethlove/temperature_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kennethlove/temperature_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kennethlove/temperature_rust" "work/ex/clippy-test-run/sources/stable/gh/kennethlove/temperature_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kennethlove/temperature_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kennethlove/temperature_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kennethlove/temperature_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kennethlove/temperature_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 23f7124498c11e528c3c67a19c44233237eb90d9 [INFO] sha for GitHub repo kennethlove/temperature_rust: 23f7124498c11e528c3c67a19c44233237eb90d9 [INFO] validating manifest of kennethlove/temperature_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kennethlove/temperature_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kennethlove/temperature_rust [INFO] finished frobbing kennethlove/temperature_rust [INFO] frobbed toml for kennethlove/temperature_rust written to work/ex/clippy-test-run/sources/stable/gh/kennethlove/temperature_rust/Cargo.toml [INFO] started frobbing kennethlove/temperature_rust [INFO] finished frobbing kennethlove/temperature_rust [INFO] frobbed toml for kennethlove/temperature_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kennethlove/temperature_rust/Cargo.toml [INFO] crate kennethlove/temperature_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kennethlove/temperature_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kennethlove/temperature_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 53105f4b46fb22f65b70961b2cce73e9a370ca61744880fae98fd94be4dc6428 [INFO] running `"docker" "start" "-a" "53105f4b46fb22f65b70961b2cce73e9a370ca61744880fae98fd94be4dc6428"` [INFO] [stderr] Checking libflate v0.1.5 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking serde_urlencoded v0.4.2 [INFO] [stderr] Compiling serde_derive v1.0.2 [INFO] [stderr] Checking reqwest v0.5.1 [INFO] [stderr] Checking temperature v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | let ref feels_like = json["current_observation"]["feelslike_string"].to_string(); [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------------------------------------------------------- help: try: `let feels_like = &json["current_observation"]["feelslike_string"].to_string();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | let ref weather = json["current_observation"]["weather"].to_string(); [INFO] [stderr] | ----^^^^^^^^^^^------------------------------------------------------ help: try: `let weather = &json["current_observation"]["weather"].to_string();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | let ref feels_like = json["current_observation"]["feelslike_string"].to_string(); [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------------------------------------------------------- help: try: `let feels_like = &json["current_observation"]["feelslike_string"].to_string();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | let ref weather = json["current_observation"]["weather"].to_string(); [INFO] [stderr] | ----^^^^^^^^^^^------------------------------------------------------ help: try: `let weather = &json["current_observation"]["weather"].to_string();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.25s [INFO] running `"docker" "inspect" "53105f4b46fb22f65b70961b2cce73e9a370ca61744880fae98fd94be4dc6428"` [INFO] running `"docker" "rm" "-f" "53105f4b46fb22f65b70961b2cce73e9a370ca61744880fae98fd94be4dc6428"` [INFO] [stdout] 53105f4b46fb22f65b70961b2cce73e9a370ca61744880fae98fd94be4dc6428