[INFO] updating cached repository kenan-rhoton/rusthammer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kenan-rhoton/rusthammer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kenan-rhoton/rusthammer" "work/ex/clippy-test-run/sources/stable/gh/kenan-rhoton/rusthammer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kenan-rhoton/rusthammer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kenan-rhoton/rusthammer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenan-rhoton/rusthammer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenan-rhoton/rusthammer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] da044ada1adcb776d998b4a0a2521aeb2d494047 [INFO] sha for GitHub repo kenan-rhoton/rusthammer: da044ada1adcb776d998b4a0a2521aeb2d494047 [INFO] validating manifest of kenan-rhoton/rusthammer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kenan-rhoton/rusthammer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kenan-rhoton/rusthammer [INFO] finished frobbing kenan-rhoton/rusthammer [INFO] frobbed toml for kenan-rhoton/rusthammer written to work/ex/clippy-test-run/sources/stable/gh/kenan-rhoton/rusthammer/Cargo.toml [INFO] started frobbing kenan-rhoton/rusthammer [INFO] finished frobbing kenan-rhoton/rusthammer [INFO] frobbed toml for kenan-rhoton/rusthammer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kenan-rhoton/rusthammer/Cargo.toml [INFO] crate kenan-rhoton/rusthammer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kenan-rhoton/rusthammer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kenan-rhoton/rusthammer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2300fba882357f12010e576a6e5864db7c33ab32209266326ab0c59104784195 [INFO] running `"docker" "start" "-a" "2300fba882357f12010e576a6e5864db7c33ab32209266326ab0c59104784195"` [INFO] [stderr] Checking hammer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/units/fight/status.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / return Fight { [INFO] [stderr] 7 | | winner: status.unit.name.clone(), [INFO] [stderr] 8 | | rounds: round, [INFO] [stderr] 9 | | wound_ratio: status.wound_ratio(), [INFO] [stderr] ... | [INFO] [stderr] 12 | | kill_damage: enemy_status.wounds_suffered [INFO] [stderr] 13 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 6 | Fight { [INFO] [stderr] 7 | winner: status.unit.name.clone(), [INFO] [stderr] 8 | rounds: round, [INFO] [stderr] 9 | wound_ratio: status.wound_ratio(), [INFO] [stderr] 10 | round_efficiency: 100.0 / (round as f64 * status.unit.points as f64), [INFO] [stderr] 11 | wound_efficiency: 100.0 * (status.wound_ratio() / status.unit.points as f64), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/units/fight/status.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return target.unit.size < 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `target.unit.size < 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/units/fight/status.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return self.attacker.fight(&mut self.defender) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.attacker.fight(&mut self.defender)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/units/fight/status.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | return self.defender.fight(&mut self.attacker) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.defender.fight(&mut self.attacker)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/units/fight/status.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / return Fight { [INFO] [stderr] 7 | | winner: status.unit.name.clone(), [INFO] [stderr] 8 | | rounds: round, [INFO] [stderr] 9 | | wound_ratio: status.wound_ratio(), [INFO] [stderr] ... | [INFO] [stderr] 12 | | kill_damage: enemy_status.wounds_suffered [INFO] [stderr] 13 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 6 | Fight { [INFO] [stderr] 7 | winner: status.unit.name.clone(), [INFO] [stderr] 8 | rounds: round, [INFO] [stderr] 9 | wound_ratio: status.wound_ratio(), [INFO] [stderr] 10 | round_efficiency: 100.0 / (round as f64 * status.unit.points as f64), [INFO] [stderr] 11 | wound_efficiency: 100.0 * (status.wound_ratio() / status.unit.points as f64), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/units/fight/status.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | return target.unit.size < 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `target.unit.size < 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/units/fight/status.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return self.attacker.fight(&mut self.defender) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.attacker.fight(&mut self.defender)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/units/fight/status.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | return self.defender.fight(&mut self.attacker) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.defender.fight(&mut self.attacker)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/units/fight/tests.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | kill_damage: 8.666666119999999 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `8.666_666_119_999_999` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/units/fight/tests.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | kill_damage: 17.333332239999997 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `17.333_332_239_999_997` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/units/fight/tests.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | kill_damage: 12.666665933333334 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `12.666_665_933_333_334` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/units/fight/tests.rs:63:27 [INFO] [stderr] | [INFO] [stderr] 63 | round_efficiency: 0.0196078431372549, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.019_607_843_137_254_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/units/fight/tests.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | kill_damage: 101.9999952400001 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `101.999_995_240_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/units/fight/tests.rs:93:22 [INFO] [stderr] | [INFO] [stderr] 93 | wound_ratio: 0.5827160657777778, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.582_716_065_777_777_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/units/fight/tests.rs:95:27 [INFO] [stderr] | [INFO] [stderr] 95 | wound_efficiency: 0.5827160657777778, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.582_716_065_777_777_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/weapons/unit_extension.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | * self.get_size() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.get_size())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/units/weapons/mod.rs:30:39 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn merge_weapon(weapon_list : &Vec, target : &Weapon) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Weapon]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/units/weapons/mod.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | extra: if w.extra.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!w.extra.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/probabilities/dice.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | (7 - num) as f64 / 6.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(7 - num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/units/change/mod.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | fn remove_weapon(&self, target : &String) -> Unit { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/units/change/mod.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | ..lead.clone() [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/units/change/mod.rs:56:37 [INFO] [stderr] | [INFO] [stderr] 56 | fn add_special(&self, special : &String) -> Unit { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/units/change/mod.rs:64:40 [INFO] [stderr] | [INFO] [stderr] 64 | fn remove_special(&self, special : &String) -> Unit { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/fight/status.rs:10:36 [INFO] [stderr] | [INFO] [stderr] 10 | round_efficiency: 100.0 / (round as f64 * status.unit.points as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(round)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/fight/status.rs:10:51 [INFO] [stderr] | [INFO] [stderr] 10 | round_efficiency: 100.0 / (round as f64 * status.unit.points as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(status.unit.points)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/fight/status.rs:11:59 [INFO] [stderr] | [INFO] [stderr] 11 | wound_efficiency: 100.0 * (status.wound_ratio() / status.unit.points as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(status.unit.points)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/fight/status.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | wound_buffer: (unit.size * unit.wounds) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(unit.size * unit.wounds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/fight/status.rs:42:69 [INFO] [stderr] | [INFO] [stderr] 42 | let new_size = self.original_size - (self.wounds_suffered / self.unit.wounds as f64).floor() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.unit.wounds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/fight/status.rs:58:36 [INFO] [stderr] | [INFO] [stderr] 58 | self.wounds_suffered = ((self.original_size - self.unit.size) [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 59 | | * self.unit.wounds) as f64; [INFO] [stderr] | |______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | self.wounds_suffered = f64::from((self.original_size - self.unit.size) [INFO] [stderr] 59 | * self.unit.wounds); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/fight/status.rs:67:61 [INFO] [stderr] | [INFO] [stderr] 67 | self.wounds_suffered += target.unit.deathrattle() * target.round_casualties as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target.round_casualties)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/units/special/mod.rs:7:29 [INFO] [stderr] | [INFO] [stderr] 7 | fn get_number(save_string : &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/special/mod.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | (target - 1) as f64/6.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/units/mod.rs:101:31 [INFO] [stderr] | [INFO] [stderr] 101 | fn find_result(&self, s : &String) -> UnitResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/units/mod.rs:102:65 [INFO] [stderr] | [INFO] [stderr] 102 | self.results.clone().into_iter().find(|x| x.scenario == s.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/units/mod.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | format!("{}", unit.name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `unit.name.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/mod.rs:133:31 [INFO] [stderr] | [INFO] [stderr] 133 | res * 100.0 / merged.points as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(merged.points)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/mod.rs:156:35 [INFO] [stderr] | [INFO] [stderr] 156 | res * 100.0 / merged.points as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(merged.points)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commands.rs:3:22 [INFO] [stderr] | [INFO] [stderr] 3 | fn fetch_unit(path : &String) -> Unit { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/weapons/unit_extension.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | * self.get_size() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.get_size())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/units/weapons/mod.rs:30:39 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn merge_weapon(weapon_list : &Vec, target : &Weapon) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Weapon]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/units/weapons/mod.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | extra: if w.extra.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!w.extra.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/probabilities/dice.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | (7 - num) as f64 / 6.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(7 - num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/units/probabilities/dice.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | assert_eq!(roll_over(0),1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/units/probabilities/dice.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | assert_eq!(roll_over(0),1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/units/probabilities/dice.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | assert_eq!(roll_over(1),1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/units/probabilities/dice.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | assert_eq!(roll_over(1),1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/units/probabilities/dice.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | assert_eq!(roll_over(4),0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/units/probabilities/dice.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | assert_eq!(roll_over(4),0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/units/probabilities/dice.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | assert_eq!(roll_over(6),1.0/6.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/units/probabilities/dice.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | assert_eq!(roll_over(6),1.0/6.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/units/probabilities/dice.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | assert_eq!(roll_over(7),0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/units/probabilities/dice.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | assert_eq!(roll_over(7),0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/units/change/mod.rs:23:38 [INFO] [stderr] | [INFO] [stderr] 23 | fn remove_weapon(&self, target : &String) -> Unit { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/units/change/mod.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | ..lead.clone() [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/units/change/mod.rs:56:37 [INFO] [stderr] | [INFO] [stderr] 56 | fn add_special(&self, special : &String) -> Unit { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/units/change/mod.rs:64:40 [INFO] [stderr] | [INFO] [stderr] 64 | fn remove_special(&self, special : &String) -> Unit { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/fight/status.rs:10:36 [INFO] [stderr] | [INFO] [stderr] 10 | round_efficiency: 100.0 / (round as f64 * status.unit.points as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(round)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/fight/status.rs:10:51 [INFO] [stderr] | [INFO] [stderr] 10 | round_efficiency: 100.0 / (round as f64 * status.unit.points as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(status.unit.points)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/fight/status.rs:11:59 [INFO] [stderr] | [INFO] [stderr] 11 | wound_efficiency: 100.0 * (status.wound_ratio() / status.unit.points as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(status.unit.points)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/fight/status.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | wound_buffer: (unit.size * unit.wounds) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(unit.size * unit.wounds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/fight/status.rs:42:69 [INFO] [stderr] | [INFO] [stderr] 42 | let new_size = self.original_size - (self.wounds_suffered / self.unit.wounds as f64).floor() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.unit.wounds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/fight/status.rs:58:36 [INFO] [stderr] | [INFO] [stderr] 58 | self.wounds_suffered = ((self.original_size - self.unit.size) [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 59 | | * self.unit.wounds) as f64; [INFO] [stderr] | |______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | self.wounds_suffered = f64::from((self.original_size - self.unit.size) [INFO] [stderr] 59 | * self.unit.wounds); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/fight/status.rs:67:61 [INFO] [stderr] | [INFO] [stderr] 67 | self.wounds_suffered += target.unit.deathrattle() * target.round_casualties as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target.round_casualties)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/units/special/mod.rs:7:29 [INFO] [stderr] | [INFO] [stderr] 7 | fn get_number(save_string : &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/special/mod.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | (target - 1) as f64/6.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(target - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/units/mod.rs:101:31 [INFO] [stderr] | [INFO] [stderr] 101 | fn find_result(&self, s : &String) -> UnitResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/units/mod.rs:102:65 [INFO] [stderr] | [INFO] [stderr] 102 | self.results.clone().into_iter().find(|x| x.scenario == s.to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/units/mod.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | format!("{}", unit.name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `unit.name.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/mod.rs:133:31 [INFO] [stderr] | [INFO] [stderr] 133 | res * 100.0 / merged.points as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(merged.points)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units/mod.rs:156:35 [INFO] [stderr] | [INFO] [stderr] 156 | res * 100.0 / merged.points as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(merged.points)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commands.rs:3:22 [INFO] [stderr] | [INFO] [stderr] 3 | fn fetch_unit(path : &String) -> Unit { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `hammer`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2300fba882357f12010e576a6e5864db7c33ab32209266326ab0c59104784195"` [INFO] running `"docker" "rm" "-f" "2300fba882357f12010e576a6e5864db7c33ab32209266326ab0c59104784195"` [INFO] [stdout] 2300fba882357f12010e576a6e5864db7c33ab32209266326ab0c59104784195