[INFO] updating cached repository kemingy/spelling_corrector [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kemingy/spelling_corrector [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kemingy/spelling_corrector" "work/ex/clippy-test-run/sources/stable/gh/kemingy/spelling_corrector"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kemingy/spelling_corrector'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kemingy/spelling_corrector" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kemingy/spelling_corrector"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kemingy/spelling_corrector'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7a94b6456d16bea37cebc41f955e3c7faa1122a1 [INFO] sha for GitHub repo kemingy/spelling_corrector: 7a94b6456d16bea37cebc41f955e3c7faa1122a1 [INFO] validating manifest of kemingy/spelling_corrector on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kemingy/spelling_corrector on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kemingy/spelling_corrector [INFO] finished frobbing kemingy/spelling_corrector [INFO] frobbed toml for kemingy/spelling_corrector written to work/ex/clippy-test-run/sources/stable/gh/kemingy/spelling_corrector/Cargo.toml [INFO] started frobbing kemingy/spelling_corrector [INFO] finished frobbing kemingy/spelling_corrector [INFO] frobbed toml for kemingy/spelling_corrector written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kemingy/spelling_corrector/Cargo.toml [INFO] crate kemingy/spelling_corrector has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kemingy/spelling_corrector against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kemingy/spelling_corrector:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb346994684fa9628f1c91996915e772427e3e59f3f85e0e280bf9f8e22024f1 [INFO] running `"docker" "start" "-a" "bb346994684fa9628f1c91996915e772427e3e59f3f85e0e280bf9f8e22024f1"` [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Checking spelling_corrector v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:60:8 [INFO] [stderr] | [INFO] [stderr] 60 | if known_words.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!known_words.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:85:18 [INFO] [stderr] | [INFO] [stderr] 85 | let splits = (0..word.len() + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `(0..=word.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:90:30 [INFO] [stderr] | [INFO] [stderr] 90 | .filter(|(_, right)| right.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!right.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:101:36 [INFO] [stderr] | [INFO] [stderr] 101 | .filter(|(_, right)| right.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!right.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:102:64 [INFO] [stderr] | [INFO] [stderr] 102 | .map(|(left, right)| left.to_string() + &letters[i..i+1] + &right[1..]) [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:108:64 [INFO] [stderr] | [INFO] [stderr] 108 | .map(|(left, right)| left.to_string() + &letters[i..i+1] + &right.to_string()) [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:60:8 [INFO] [stderr] | [INFO] [stderr] 60 | if known_words.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!known_words.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:85:18 [INFO] [stderr] | [INFO] [stderr] 85 | let splits = (0..word.len() + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `(0..=word.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:90:30 [INFO] [stderr] | [INFO] [stderr] 90 | .filter(|(_, right)| right.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!right.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:101:36 [INFO] [stderr] | [INFO] [stderr] 101 | .filter(|(_, right)| right.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!right.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:102:64 [INFO] [stderr] | [INFO] [stderr] 102 | .map(|(left, right)| left.to_string() + &letters[i..i+1] + &right[1..]) [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:108:64 [INFO] [stderr] | [INFO] [stderr] 108 | .map(|(left, right)| left.to_string() + &letters[i..i+1] + &right.to_string()) [INFO] [stderr] | ^^^^^^ help: use: `i..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.05s [INFO] running `"docker" "inspect" "bb346994684fa9628f1c91996915e772427e3e59f3f85e0e280bf9f8e22024f1"` [INFO] running `"docker" "rm" "-f" "bb346994684fa9628f1c91996915e772427e3e59f3f85e0e280bf9f8e22024f1"` [INFO] [stdout] bb346994684fa9628f1c91996915e772427e3e59f3f85e0e280bf9f8e22024f1