[INFO] updating cached repository kellpossible/rustynotes [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kellpossible/rustynotes [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kellpossible/rustynotes" "work/ex/clippy-test-run/sources/stable/gh/kellpossible/rustynotes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kellpossible/rustynotes'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kellpossible/rustynotes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kellpossible/rustynotes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kellpossible/rustynotes'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bb4df786a9b9d1506699e238c12c8a52bd081981 [INFO] sha for GitHub repo kellpossible/rustynotes: bb4df786a9b9d1506699e238c12c8a52bd081981 [INFO] validating manifest of kellpossible/rustynotes on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kellpossible/rustynotes on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kellpossible/rustynotes [INFO] finished frobbing kellpossible/rustynotes [INFO] frobbed toml for kellpossible/rustynotes written to work/ex/clippy-test-run/sources/stable/gh/kellpossible/rustynotes/Cargo.toml [INFO] started frobbing kellpossible/rustynotes [INFO] finished frobbing kellpossible/rustynotes [INFO] frobbed toml for kellpossible/rustynotes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kellpossible/rustynotes/Cargo.toml [INFO] crate kellpossible/rustynotes has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kellpossible/rustynotes against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kellpossible/rustynotes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 661af8526f847cad6d708a325e380561512bba09d701dd2290150cfaadf5d7a3 [INFO] running `"docker" "start" "-a" "661af8526f847cad6d708a325e380561512bba09d701dd2290150cfaadf5d7a3"` [INFO] [stderr] Compiling byteorder v1.2.4 [INFO] [stderr] Compiling slab v0.4.1 [INFO] [stderr] Compiling futures v0.1.23 [INFO] [stderr] Compiling lazycell v0.6.0 [INFO] [stderr] Compiling matches v0.1.7 [INFO] [stderr] Compiling encoding_index_tests v0.1.4 [INFO] [stderr] Compiling stable_deref_trait v1.1.1 [INFO] [stderr] Compiling linked-hash-map v0.4.2 [INFO] [stderr] Compiling crossbeam-utils v0.5.0 [INFO] [stderr] Compiling string v0.1.1 [INFO] [stderr] Compiling indexmap v1.0.1 [INFO] [stderr] Compiling htmlescape v0.3.1 [INFO] [stderr] Compiling sha1 v0.6.0 [INFO] [stderr] Compiling lazycell v1.0.0 [INFO] [stderr] Compiling actix-web v0.7.3 [INFO] [stderr] Compiling crossbeam-utils v0.3.2 [INFO] [stderr] Compiling log v0.4.3 [INFO] [stderr] Compiling ring v0.13.2 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Compiling iovec v0.1.2 [INFO] [stderr] Compiling net2 v0.2.33 [INFO] [stderr] Compiling rand v0.4.2 [INFO] [stderr] Compiling socket2 v0.3.7 [INFO] [stderr] Compiling hostname v0.1.5 [INFO] [stderr] Compiling encoding-index-korean v1.20141219.5 [INFO] [stderr] Compiling encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Compiling encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Compiling encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Compiling encoding-index-japanese v1.20141219.5 [INFO] [stderr] Compiling unicode-bidi v0.3.4 [INFO] [stderr] Compiling owning_ref v0.3.3 [INFO] [stderr] Compiling lru-cache v0.1.1 [INFO] [stderr] Compiling walkdir v2.2.0 [INFO] [stderr] Compiling base64 v0.9.2 [INFO] [stderr] Compiling bytes v0.4.9 [INFO] [stderr] Compiling resolv-conf v0.6.1 [INFO] [stderr] Compiling aho-corasick v0.6.6 [INFO] [stderr] Compiling nom v4.0.0 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Compiling smallvec v0.6.4 [INFO] [stderr] Compiling mio v0.6.15 [INFO] [stderr] Compiling tokio-executor v0.1.3 [INFO] [stderr] Compiling futures-cpupool v0.1.8 [INFO] [stderr] Compiling lock_api v0.1.3 [INFO] [stderr] Compiling encoding v0.2.33 [INFO] [stderr] Compiling unicase v2.1.0 [INFO] [stderr] Compiling idna v0.1.5 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Compiling dbghelp-sys v0.2.0 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Compiling toml v0.4.6 [INFO] [stderr] Checking url v1.7.1 [INFO] [stderr] Compiling parking_lot_core v0.2.14 [INFO] [stderr] Compiling tokio-io v0.1.7 [INFO] [stderr] Compiling http v0.1.10 [INFO] [stderr] Compiling tokio-timer v0.2.5 [INFO] [stderr] Compiling pest_derive v1.0.8 [INFO] [stderr] Compiling rust-embed v3.0.1 [INFO] [stderr] Compiling crossbeam-epoch v0.4.3 [INFO] [stderr] Compiling crossbeam-epoch v0.5.2 [INFO] [stderr] Compiling phf_shared v0.7.22 [INFO] [stderr] Compiling syn v0.14.8 [INFO] [stderr] Compiling backtrace v0.3.9 [INFO] [stderr] Compiling mime v0.3.9 [INFO] [stderr] Compiling flate2 v1.0.2 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Compiling parking_lot v0.6.3 [INFO] [stderr] Compiling tokio-codec v0.1.0 [INFO] [stderr] Compiling tokio-reactor v0.1.3 [INFO] [stderr] Checking chrono v0.4.5 [INFO] [stderr] Compiling regex v1.0.2 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Compiling phf v0.7.22 [INFO] [stderr] Compiling crossbeam-deque v0.3.1 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking tokio-signal v0.2.2 [INFO] [stderr] Checking crossbeam-channel v0.2.4 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking env_logger v0.5.12 [INFO] [stderr] Checking comrak v0.2.14 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Compiling tokio-udp v0.1.1 [INFO] [stderr] Compiling tokio-tcp v0.1.1 [INFO] [stderr] Compiling tokio-threadpool v0.1.5 [INFO] [stderr] Checking trust-dns-proto v0.4.0 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling actix_derive v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.71 [INFO] [stderr] Compiling tokio-fs v0.1.3 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Compiling tokio v0.1.7 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Compiling failure v0.1.2 [INFO] [stderr] Checking actix v0.7.3 [INFO] [stderr] Compiling askama_shared v0.7.1 [INFO] [stderr] Compiling askama_derive v0.7.1 [INFO] [stderr] Checking askama v0.7.1 [INFO] [stderr] Compiling rustynotes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/note.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/note.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | markdown_content: markdown_content [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `markdown_content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/note.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/note.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | note: note [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `note` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/note.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/note.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | markdown_content: markdown_content [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `markdown_content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/note.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/note.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | note: note [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `note` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/note.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return new_note; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_note` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/note.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return new_note_ref; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_note_ref` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/note.rs:101:8 [INFO] [stderr] | [INFO] [stderr] 101 | return ref_notes.iter().find(|&n| n.id == id).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ref_notes.iter().find(|&n| n.id == id).unwrap().clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/note.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return new_note_ref; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_note_ref` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/note.rs:93:51 [INFO] [stderr] | [INFO] [stderr] 93 | new_note_ref.note.server_edit_time = Some(new_note_ref.note.edit_time.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_note_ref.note.edit_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/note.rs:110:51 [INFO] [stderr] | [INFO] [stderr] 110 | new_note_ref.note.server_edit_time = Some(new_note_ref.note.edit_time.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_note_ref.note.edit_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/note.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return new_note; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_note` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/note.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return new_note_ref; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_note_ref` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/note.rs:101:8 [INFO] [stderr] | [INFO] [stderr] 101 | return ref_notes.iter().find(|&n| n.id == id).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ref_notes.iter().find(|&n| n.id == id).unwrap().clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/note.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return new_note_ref; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_note_ref` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/note.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | fn new(title: String, markdown_content: String) -> Note { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clone_for_edit` [INFO] [stderr] --> src/note.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | fn clone_for_edit(&self) -> Note { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `DebugNoteBackend` [INFO] [stderr] --> src/note.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | struct DebugNoteBackend { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/note.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | fn new() -> DebugNoteBackend { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/note.rs:93:51 [INFO] [stderr] | [INFO] [stderr] 93 | new_note_ref.note.server_edit_time = Some(new_note_ref.note.edit_time.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_note_ref.note.edit_time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/note.rs:110:51 [INFO] [stderr] | [INFO] [stderr] 110 | new_note_ref.note.server_edit_time = Some(new_note_ref.note.edit_time.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_note_ref.note.edit_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 54s [INFO] running `"docker" "inspect" "661af8526f847cad6d708a325e380561512bba09d701dd2290150cfaadf5d7a3"` [INFO] running `"docker" "rm" "-f" "661af8526f847cad6d708a325e380561512bba09d701dd2290150cfaadf5d7a3"` [INFO] [stdout] 661af8526f847cad6d708a325e380561512bba09d701dd2290150cfaadf5d7a3