[INFO] updating cached repository kegato/letsencrypt-inwx [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kegato/letsencrypt-inwx [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kegato/letsencrypt-inwx" "work/ex/clippy-test-run/sources/stable/gh/kegato/letsencrypt-inwx"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kegato/letsencrypt-inwx'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kegato/letsencrypt-inwx" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kegato/letsencrypt-inwx"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kegato/letsencrypt-inwx'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 12f7ebc88b90f2bacc1cf10d7e174c49711cadcd [INFO] sha for GitHub repo kegato/letsencrypt-inwx: 12f7ebc88b90f2bacc1cf10d7e174c49711cadcd [INFO] validating manifest of kegato/letsencrypt-inwx on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kegato/letsencrypt-inwx on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kegato/letsencrypt-inwx [INFO] finished frobbing kegato/letsencrypt-inwx [INFO] frobbed toml for kegato/letsencrypt-inwx written to work/ex/clippy-test-run/sources/stable/gh/kegato/letsencrypt-inwx/Cargo.toml [INFO] started frobbing kegato/letsencrypt-inwx [INFO] finished frobbing kegato/letsencrypt-inwx [INFO] frobbed toml for kegato/letsencrypt-inwx written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kegato/letsencrypt-inwx/Cargo.toml [INFO] crate kegato/letsencrypt-inwx has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kegato/letsencrypt-inwx against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kegato/letsencrypt-inwx:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3ed98a5e99aee767cd14fa0a79a0889e9a4779b245330c7584a04fa54dd0ca0d [INFO] running `"docker" "start" "-a" "3ed98a5e99aee767cd14fa0a79a0889e9a4779b245330c7584a04fa54dd0ca0d"` [INFO] [stderr] Compiling proc-macro-hack-impl v0.4.1 [INFO] [stderr] Checking radix_trie v0.1.4 [INFO] [stderr] Checking sxd-document v0.3.0 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Compiling syn v0.15.20 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Compiling proc-macro-hack v0.4.1 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.5 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking sxd-xpath v0.4.2 [INFO] [stderr] Checking data-encoding-macro v0.1.5 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking trust-dns v0.15.0 [INFO] [stderr] Checking letsencrypt-inwx v1.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:92:4 [INFO] [stderr] | [INFO] [stderr] 92 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rpc.rs:92:4 [INFO] [stderr] | [INFO] [stderr] 92 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rpc.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 20 | | &RpcError::InvalidResponse => write!(f, "The inwx api did not return a valid response"), [INFO] [stderr] 21 | | &RpcError::ConnectionError(ref e) => write!(f, "Could not connect to the inwx api: {}", e) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | match *self { [INFO] [stderr] 20 | RpcError::InvalidResponse => write!(f, "The inwx api did not return a valid response"), [INFO] [stderr] 21 | RpcError::ConnectionError(ref e) => write!(f, "Could not connect to the inwx api: {}", e) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/rpc.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | .map_err(|e| RpcError::ConnectionError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RpcError::ConnectionError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/inwx.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 20 | | &InwxError::RpcError(ref e) => write!(f, "The inwx api call failed: {}", e), [INFO] [stderr] 21 | | &InwxError::ApiError { ref method, ref msg } => write!(f, "{}: {}", method, msg) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | match *self { [INFO] [stderr] 20 | InwxError::RpcError(ref e) => write!(f, "The inwx api call failed: {}", e), [INFO] [stderr] 21 | InwxError::ApiError { ref method, ref msg } => write!(f, "{}: {}", method, msg) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/inwx.rs:34:48 [INFO] [stderr] | [INFO] [stderr] 34 | let response = request.send(API_URL).map_err(|e| InwxError::RpcError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `InwxError::RpcError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dns.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | if !domain.ends_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dns.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | if domain.ends_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rpc.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 20 | | &RpcError::InvalidResponse => write!(f, "The inwx api did not return a valid response"), [INFO] [stderr] 21 | | &RpcError::ConnectionError(ref e) => write!(f, "Could not connect to the inwx api: {}", e) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | match *self { [INFO] [stderr] 20 | RpcError::InvalidResponse => write!(f, "The inwx api did not return a valid response"), [INFO] [stderr] 21 | RpcError::ConnectionError(ref e) => write!(f, "Could not connect to the inwx api: {}", e) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/rpc.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | .map_err(|e| RpcError::ConnectionError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RpcError::ConnectionError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/inwx.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 20 | | &InwxError::RpcError(ref e) => write!(f, "The inwx api call failed: {}", e), [INFO] [stderr] 21 | | &InwxError::ApiError { ref method, ref msg } => write!(f, "{}: {}", method, msg) [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | match *self { [INFO] [stderr] 20 | InwxError::RpcError(ref e) => write!(f, "The inwx api call failed: {}", e), [INFO] [stderr] 21 | InwxError::ApiError { ref method, ref msg } => write!(f, "{}: {}", method, msg) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/inwx.rs:34:48 [INFO] [stderr] | [INFO] [stderr] 34 | let response = request.send(API_URL).map_err(|e| InwxError::RpcError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `InwxError::RpcError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dns.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | if !domain.ends_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/dns.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | if domain.ends_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:29:32 [INFO] [stderr] | [INFO] [stderr] 29 | let mut lines = content.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:170:2 [INFO] [stderr] | [INFO] [stderr] 170 | match op(&api) { [INFO] [stderr] | _____^ [INFO] [stderr] 171 | | Err(e) => { [INFO] [stderr] 172 | | err = Some(e); [INFO] [stderr] 173 | | }, [INFO] [stderr] 174 | | _ => {} [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 170 | if let Err(e) = op(&api) { [INFO] [stderr] 171 | err = Some(e); [INFO] [stderr] 172 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:178:10 [INFO] [stderr] | [INFO] [stderr] 178 | if let None = err { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 179 | | err = Some(e); [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________- help: try this: `if err.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:29:32 [INFO] [stderr] | [INFO] [stderr] 29 | let mut lines = content.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:170:2 [INFO] [stderr] | [INFO] [stderr] 170 | match op(&api) { [INFO] [stderr] | _____^ [INFO] [stderr] 171 | | Err(e) => { [INFO] [stderr] 172 | | err = Some(e); [INFO] [stderr] 173 | | }, [INFO] [stderr] 174 | | _ => {} [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 170 | if let Err(e) = op(&api) { [INFO] [stderr] 171 | err = Some(e); [INFO] [stderr] 172 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:178:10 [INFO] [stderr] | [INFO] [stderr] 178 | if let None = err { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 179 | | err = Some(e); [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________- help: try this: `if err.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 49.81s [INFO] running `"docker" "inspect" "3ed98a5e99aee767cd14fa0a79a0889e9a4779b245330c7584a04fa54dd0ca0d"` [INFO] running `"docker" "rm" "-f" "3ed98a5e99aee767cd14fa0a79a0889e9a4779b245330c7584a04fa54dd0ca0d"` [INFO] [stdout] 3ed98a5e99aee767cd14fa0a79a0889e9a4779b245330c7584a04fa54dd0ca0d