[INFO] updating cached repository keathley/bf
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/keathley/bf
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/keathley/bf" "work/ex/clippy-test-run/sources/stable/gh/keathley/bf"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/keathley/bf'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/keathley/bf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keathley/bf"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keathley/bf'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ee0333994d3059a4f7765fc404fbb694a33c66c0
[INFO] sha for GitHub repo keathley/bf: ee0333994d3059a4f7765fc404fbb694a33c66c0
[INFO] validating manifest of keathley/bf on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of keathley/bf on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing keathley/bf
[INFO] finished frobbing keathley/bf
[INFO] frobbed toml for keathley/bf written to work/ex/clippy-test-run/sources/stable/gh/keathley/bf/Cargo.toml
[INFO] started frobbing keathley/bf
[INFO] finished frobbing keathley/bf
[INFO] frobbed toml for keathley/bf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/keathley/bf/Cargo.toml
[INFO] crate keathley/bf has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting keathley/bf against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/keathley/bf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cec9c0ad5e79b2c65f59033fa7e690d0da2cd4bda4ff488b0dc9a63cdf791670
[INFO] running `"docker" "start" "-a" "cec9c0ad5e79b2c65f59033fa7e690d0da2cd4bda4ff488b0dc9a63cdf791670"`
[INFO] [stderr]     Checking atty v0.2.2
[INFO] [stderr]     Checking term_size v0.3.0
[INFO] [stderr]     Checking clap v2.24.2
[INFO] [stderr]     Checking bf v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/interpreter/optimized.rs:51:53
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 bytecode.push(Op::JumpIfDataNotZero{offset: offset});
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/interpreter/optimized.rs:51:53
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 bytecode.push(Op::JumpIfDataNotZero{offset: offset});
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `bytecode_to_string`
[INFO] [stderr]   --> src/interpreter/optimized.rs:17:1
[INFO] [stderr]    |
[INFO] [stderr] 17 | fn bytecode_to_string(ops: &Ops) -> String {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/parser.rs:14:24
[INFO] [stderr]    |
[INFO] [stderr] 14 |     pub fn parse(text: &String) -> Program {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/parser.rs:23:27
[INFO] [stderr]    |
[INFO] [stderr] 23 |     fn is_valid_symbol(s: &String) -> bool {
[INFO] [stderr]    |                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/interpreter/naive.rs:11:13
[INFO] [stderr]    |
[INFO] [stderr] 11 |         let ref instruction = program.instructions[pc];
[INFO] [stderr]    |         ----^^^^^^^^^^^^^^^---------------------------- help: try: `let instruction = &program.instructions[pc];`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/interpreter/optimized.rs:17:28
[INFO] [stderr]    |
[INFO] [stderr] 17 | fn bytecode_to_string(ops: &Ops) -> String {
[INFO] [stderr]    |                            ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/interpreter/optimized.rs:18:25
[INFO] [stderr]    |
[INFO] [stderr] 18 |       ops.iter().map(|op| match op {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 19 | |         &Op::IncPointer(count) => format!("inc pointer: {}", count),
[INFO] [stderr] 20 | |         &Op::DecPointer(count) => format!("dec pointer: {}", count),
[INFO] [stderr] 21 | |         &Op::IncData(count) => format!("inc data: {}", count),
[INFO] [stderr] ...  |
[INFO] [stderr] 26 | |         &Op::JumpIfDataNotZero{offset} => format!("Jumping back to {}", offset)
[INFO] [stderr] 27 | |     })
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 18 |     ops.iter().map(|op| match *op {
[INFO] [stderr] 19 |         Op::IncPointer(count) => format!("inc pointer: {}", count),
[INFO] [stderr] 20 |         Op::DecPointer(count) => format!("dec pointer: {}", count),
[INFO] [stderr] 21 |         Op::IncData(count) => format!("inc data: {}", count),
[INFO] [stderr] 22 |         Op::DecData(count) => format!("dec data: {}", count),
[INFO] [stderr] 23 |         Op::Read           => format!("reading"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/interpreter/optimized.rs:23:32
[INFO] [stderr]    |
[INFO] [stderr] 23 |         &Op::Read           => format!("reading"),
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"reading".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/interpreter/optimized.rs:24:32
[INFO] [stderr]    |
[INFO] [stderr] 24 |         &Op::Write          => format!("writing"),
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"writing".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `bytecode_to_string`
[INFO] [stderr]   --> src/interpreter/optimized.rs:17:1
[INFO] [stderr]    |
[INFO] [stderr] 17 | fn bytecode_to_string(ops: &Ops) -> String {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/parser.rs:14:24
[INFO] [stderr]    |
[INFO] [stderr] 14 |     pub fn parse(text: &String) -> Program {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/parser.rs:23:27
[INFO] [stderr]    |
[INFO] [stderr] 23 |     fn is_valid_symbol(s: &String) -> bool {
[INFO] [stderr]    |                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/interpreter/naive.rs:11:13
[INFO] [stderr]    |
[INFO] [stderr] 11 |         let ref instruction = program.instructions[pc];
[INFO] [stderr]    |         ----^^^^^^^^^^^^^^^---------------------------- help: try: `let instruction = &program.instructions[pc];`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/interpreter/optimized.rs:17:28
[INFO] [stderr]    |
[INFO] [stderr] 17 | fn bytecode_to_string(ops: &Ops) -> String {
[INFO] [stderr]    |                            ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/interpreter/optimized.rs:18:25
[INFO] [stderr]    |
[INFO] [stderr] 18 |       ops.iter().map(|op| match op {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 19 | |         &Op::IncPointer(count) => format!("inc pointer: {}", count),
[INFO] [stderr] 20 | |         &Op::DecPointer(count) => format!("dec pointer: {}", count),
[INFO] [stderr] 21 | |         &Op::IncData(count) => format!("inc data: {}", count),
[INFO] [stderr] ...  |
[INFO] [stderr] 26 | |         &Op::JumpIfDataNotZero{offset} => format!("Jumping back to {}", offset)
[INFO] [stderr] 27 | |     })
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 18 |     ops.iter().map(|op| match *op {
[INFO] [stderr] 19 |         Op::IncPointer(count) => format!("inc pointer: {}", count),
[INFO] [stderr] 20 |         Op::DecPointer(count) => format!("dec pointer: {}", count),
[INFO] [stderr] 21 |         Op::IncData(count) => format!("inc data: {}", count),
[INFO] [stderr] 22 |         Op::DecData(count) => format!("dec data: {}", count),
[INFO] [stderr] 23 |         Op::Read           => format!("reading"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/interpreter/optimized.rs:23:32
[INFO] [stderr]    |
[INFO] [stderr] 23 |         &Op::Read           => format!("reading"),
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"reading".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/interpreter/optimized.rs:24:32
[INFO] [stderr]    |
[INFO] [stderr] 24 |         &Op::Write          => format!("writing"),
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"writing".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.62s
[INFO] running `"docker" "inspect" "cec9c0ad5e79b2c65f59033fa7e690d0da2cd4bda4ff488b0dc9a63cdf791670"`
[INFO] running `"docker" "rm" "-f" "cec9c0ad5e79b2c65f59033fa7e690d0da2cd4bda4ff488b0dc9a63cdf791670"`
[INFO] [stdout] cec9c0ad5e79b2c65f59033fa7e690d0da2cd4bda4ff488b0dc9a63cdf791670