[INFO] updating cached repository kdeal/repo-notify [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kdeal/repo-notify [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kdeal/repo-notify" "work/ex/clippy-test-run/sources/stable/gh/kdeal/repo-notify"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kdeal/repo-notify'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kdeal/repo-notify" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kdeal/repo-notify"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kdeal/repo-notify'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ac3cd747638b4f4095ddab49d9eb4a3fb148bd13 [INFO] sha for GitHub repo kdeal/repo-notify: ac3cd747638b4f4095ddab49d9eb4a3fb148bd13 [INFO] validating manifest of kdeal/repo-notify on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kdeal/repo-notify on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kdeal/repo-notify [INFO] finished frobbing kdeal/repo-notify [INFO] frobbed toml for kdeal/repo-notify written to work/ex/clippy-test-run/sources/stable/gh/kdeal/repo-notify/Cargo.toml [INFO] started frobbing kdeal/repo-notify [INFO] finished frobbing kdeal/repo-notify [INFO] frobbed toml for kdeal/repo-notify written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kdeal/repo-notify/Cargo.toml [INFO] crate kdeal/repo-notify has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kdeal/repo-notify against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kdeal/repo-notify:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 93387a2673f18be87b2b65231501fe492c51cb93eb86a84985afed86507a078b [INFO] running `"docker" "start" "-a" "93387a2673f18be87b2b65231501fe492c51cb93eb86a84985afed86507a078b"` [INFO] [stderr] Compiling scopeguard v0.3.2 [INFO] [stderr] Compiling libc v0.2.31 [INFO] [stderr] Compiling futures v0.1.16 [INFO] [stderr] Compiling lazy_static v0.2.8 [INFO] [stderr] Checking text_io v0.1.6 [INFO] [stderr] Compiling backtrace-sys v0.1.14 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking dirs v1.0.4 [INFO] [stderr] Checking rpassword v1.0.2 [INFO] [stderr] Compiling coco v0.1.1 [INFO] [stderr] Checking textwrap v0.8.0 [INFO] [stderr] Checking clap v2.26.2 [INFO] [stderr] Compiling rand v0.3.16 [INFO] [stderr] Compiling num_cpus v1.6.2 [INFO] [stderr] Compiling rayon-core v1.2.1 [INFO] [stderr] Compiling rayon v0.7.1 [INFO] [stderr] Compiling ring v0.11.0 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking webpki v0.14.0 [INFO] [stderr] Checking rustls v0.9.0 [INFO] [stderr] Checking webpki-roots v0.11.0 [INFO] [stderr] Checking tokio-rustls v0.2.4 [INFO] [stderr] Checking hyper-rustls v0.8.0 [INFO] [stderr] Checking github-rs v0.5.1 [INFO] [stderr] Checking repo-notify v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/todoist.rs:61:53 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn comment(comment: NewComment, token: &String) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:137:3 [INFO] [stderr] | [INFO] [stderr] 137 | ) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/todoist.rs:61:53 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn comment(comment: NewComment, token: &String) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:137:3 [INFO] [stderr] | [INFO] [stderr] 137 | ) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/config.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / fn expand_config_path<'a>(config_file: &'a str) -> PathBuf { [INFO] [stderr] 28 | | let mut path = String::from(config_file); [INFO] [stderr] 29 | | if path.starts_with("~") { [INFO] [stderr] 30 | | // TODO: Make this better [INFO] [stderr] ... | [INFO] [stderr] 37 | | PathBuf::from(config_file) [INFO] [stderr] 38 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | if path.starts_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/config.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn load<'a>(config_file: &'a str) -> (Repos, Config) { [INFO] [stderr] 41 | | let mut repos: Repos = BTreeMap::new(); [INFO] [stderr] 42 | | let mut config = Config::default(); [INFO] [stderr] 43 | | [INFO] [stderr] ... | [INFO] [stderr] 65 | | (repos, config) [INFO] [stderr] 66 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/config.rs:68:1 [INFO] [stderr] | [INFO] [stderr] 68 | / pub fn save<'a>(config_file: &'a str, repos: Repos, config: Config) { [INFO] [stderr] 69 | | let mut config_table: Table = Table::new(); [INFO] [stderr] 70 | | config_table.insert("config".to_string(), Value::try_from(config).unwrap()); [INFO] [stderr] 71 | | [INFO] [stderr] ... | [INFO] [stderr] 89 | | .expect("failed to write config"); [INFO] [stderr] 90 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/config.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / fn expand_config_path<'a>(config_file: &'a str) -> PathBuf { [INFO] [stderr] 28 | | let mut path = String::from(config_file); [INFO] [stderr] 29 | | if path.starts_with("~") { [INFO] [stderr] 30 | | // TODO: Make this better [INFO] [stderr] ... | [INFO] [stderr] 37 | | PathBuf::from(config_file) [INFO] [stderr] 38 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | if path.starts_with("~") { [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/config.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn load<'a>(config_file: &'a str) -> (Repos, Config) { [INFO] [stderr] 41 | | let mut repos: Repos = BTreeMap::new(); [INFO] [stderr] 42 | | let mut config = Config::default(); [INFO] [stderr] 43 | | [INFO] [stderr] ... | [INFO] [stderr] 65 | | (repos, config) [INFO] [stderr] 66 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/config.rs:68:1 [INFO] [stderr] | [INFO] [stderr] 68 | / pub fn save<'a>(config_file: &'a str, repos: Repos, config: Config) { [INFO] [stderr] 69 | | let mut config_table: Table = Table::new(); [INFO] [stderr] 70 | | config_table.insert("config".to_string(), Value::try_from(config).unwrap()); [INFO] [stderr] 71 | | [INFO] [stderr] ... | [INFO] [stderr] 89 | | .expect("failed to write config"); [INFO] [stderr] 90 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/todoist.rs:53:25 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn get_tasks(token: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/todoist.rs:61:44 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn comment(comment: NewComment, token: &String) -> () { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/todoist.rs:74:42 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn create_task(task: NewTask, token: &String) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:75:1 [INFO] [stderr] | [INFO] [stderr] 75 | / fn add<'a>(args: &'a ArgMatches, mut repos: Repos) -> Repos { [INFO] [stderr] 76 | | let repo_name = args.value_of("repository").unwrap().to_string(); [INFO] [stderr] 77 | | println!("Adding {} to watched repositories", repo_name); [INFO] [stderr] 78 | | repos.insert(repo_name, Repo::default()); [INFO] [stderr] 79 | | repos [INFO] [stderr] 80 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:135:12 [INFO] [stderr] | [INFO] [stderr] 135 | tasks: &Vec, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Task]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:136:12 [INFO] [stderr] | [INFO] [stderr] 136 | token: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/todoist.rs:53:25 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn get_tasks(token: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/todoist.rs:61:44 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn comment(comment: NewComment, token: &String) -> () { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/todoist.rs:74:42 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn create_task(task: NewTask, token: &String) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:75:1 [INFO] [stderr] | [INFO] [stderr] 75 | / fn add<'a>(args: &'a ArgMatches, mut repos: Repos) -> Repos { [INFO] [stderr] 76 | | let repo_name = args.value_of("repository").unwrap().to_string(); [INFO] [stderr] 77 | | println!("Adding {} to watched repositories", repo_name); [INFO] [stderr] 78 | | repos.insert(repo_name, Repo::default()); [INFO] [stderr] 79 | | repos [INFO] [stderr] 80 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:135:12 [INFO] [stderr] | [INFO] [stderr] 135 | tasks: &Vec, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Task]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:136:12 [INFO] [stderr] | [INFO] [stderr] 136 | token: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 50.17s [INFO] running `"docker" "inspect" "93387a2673f18be87b2b65231501fe492c51cb93eb86a84985afed86507a078b"` [INFO] running `"docker" "rm" "-f" "93387a2673f18be87b2b65231501fe492c51cb93eb86a84985afed86507a078b"` [INFO] [stdout] 93387a2673f18be87b2b65231501fe492c51cb93eb86a84985afed86507a078b