[INFO] updating cached repository kcotugno/ripper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kcotugno/ripper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kcotugno/ripper" "work/ex/clippy-test-run/sources/stable/gh/kcotugno/ripper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kcotugno/ripper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kcotugno/ripper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kcotugno/ripper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kcotugno/ripper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5bc1ecb70e568f2d91d61d7e821c765e10b0b87a [INFO] sha for GitHub repo kcotugno/ripper: 5bc1ecb70e568f2d91d61d7e821c765e10b0b87a [INFO] validating manifest of kcotugno/ripper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kcotugno/ripper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kcotugno/ripper [INFO] finished frobbing kcotugno/ripper [INFO] frobbed toml for kcotugno/ripper written to work/ex/clippy-test-run/sources/stable/gh/kcotugno/ripper/Cargo.toml [INFO] started frobbing kcotugno/ripper [INFO] finished frobbing kcotugno/ripper [INFO] frobbed toml for kcotugno/ripper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kcotugno/ripper/Cargo.toml [INFO] crate kcotugno/ripper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kcotugno/ripper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kcotugno/ripper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3d2789e4a1bc0901d844dfceaac6100de6ba53925940114c0504782b62c7e03c [INFO] running `"docker" "start" "-a" "3d2789e4a1bc0901d844dfceaac6100de6ba53925940114c0504782b62c7e03c"` [INFO] [stderr] Compiling libc v0.2.44 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking ripper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ripper/lib.rs:185:31 [INFO] [stderr] | [INFO] [stderr] 185 | Err(error) => Err(String::from(format!("Should be ok, {}", error))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Should be ok, {}", error)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ripper/lib.rs:193:31 [INFO] [stderr] | [INFO] [stderr] 193 | Err(error) => Err(String::from(format!("Should be ok, {}", error))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Should be ok, {}", error)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ripper/lib.rs:201:26 [INFO] [stderr] | [INFO] [stderr] 201 | Ok(v) => Err(String::from(format!("Should have returned error, {}", v))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Should have returned error, {}", v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ripper/lib.rs:208:25 [INFO] [stderr] | [INFO] [stderr] 208 | Err(String::from(expected)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ripper/lib.rs:222:25 [INFO] [stderr] | [INFO] [stderr] 222 | Err(String::from(format!("octets do not match: {}", addr))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("octets do not match: {}", addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/ripper/lib.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | / fn ipv6_with_segments( [INFO] [stderr] 230 | | ip: IpAddr, [INFO] [stderr] 231 | | a: u16, [INFO] [stderr] 232 | | b: u16, [INFO] [stderr] ... | [INFO] [stderr] 249 | | } [INFO] [stderr] 250 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ripper/lib.rs:246:25 [INFO] [stderr] | [INFO] [stderr] 246 | Err(String::from(format!("segments do not match: {}", addr))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("segments do not match: {}", addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.77s [INFO] running `"docker" "inspect" "3d2789e4a1bc0901d844dfceaac6100de6ba53925940114c0504782b62c7e03c"` [INFO] running `"docker" "rm" "-f" "3d2789e4a1bc0901d844dfceaac6100de6ba53925940114c0504782b62c7e03c"` [INFO] [stdout] 3d2789e4a1bc0901d844dfceaac6100de6ba53925940114c0504782b62c7e03c